public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Rémi Cardona" <remi@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] Requiring two sets of eyes for all eclass commits
Date: Tue, 27 Apr 2010 21:11:17 +0200	[thread overview]
Message-ID: <4BD736D5.9020201@gentoo.org> (raw)
In-Reply-To: <4BD32D26.5090005@gentoo.org>

Le 24/04/2010 19:40, Petteri Räty a écrit :
> What do you think about not allowing commits to eclasses without
> mentioning an another developer who has reviewed and approved the diff
> in the commit message? There's enough people on gentoo-dev for urgent
> stuff too.

More bureaucracy and policies when we arguably have enough (or even too
much...?) My vote is a clear and resounding *no*.

If someone f*cks up, revert the commit if the issue isn't fixed quickly.

If that someone f*cks up again, call devrel on his ass.

If anything, we should be working on versionned eclasses rather than VCS
hooks.

My 2 euro cents.

Cheers,

Rémi



      parent reply	other threads:[~2010-04-27 19:13 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-24 17:40 [gentoo-dev] Requiring two sets of eyes for all eclass commits Petteri Räty
2010-04-24 18:10 ` Arun Raghavan
2010-04-24 18:14 ` Alexis Ballier
2010-04-25 10:14   ` Petteri Räty
2010-04-25 22:42     ` Alistair Bush
2010-04-25 13:10       ` Petteri Räty
2010-04-25 15:22         ` Jorge Manuel B. S. Vicetto
2010-04-26 17:58       ` Steev Klimaszewski
2010-04-25 10:06 ` [gentoo-dev] " Ryan Hill
2010-04-25 10:11   ` Petteri Räty
2010-04-25 11:36     ` Ryan Hill
2010-04-25 12:01       ` Alec Warner
2010-04-25 21:06         ` Ryan Hill
2010-04-25 12:04       ` Richard Freeman
2010-04-26 16:19     ` Paul Varner
2010-04-25 10:54 ` [gentoo-dev] " Roy Bamford
2010-04-27 19:11 ` Rémi Cardona [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BD736D5.9020201@gentoo.org \
    --to=remi@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox