From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1O5yql-0004aq-55 for garchives@archives.gentoo.org; Sun, 25 Apr 2010 10:14:07 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 59E00E081A; Sun, 25 Apr 2010 10:14:05 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id C1C54E0809 for ; Sun, 25 Apr 2010 10:14:01 +0000 (UTC) Received: from [82.130.46.197] (qiv5.kyla.fi [82.130.46.197]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTP id 136FB1B4044 for ; Sun, 25 Apr 2010 10:14:00 +0000 (UTC) Message-ID: <4BD415F0.2040007@gentoo.org> Date: Sun, 25 Apr 2010 13:14:08 +0300 From: =?UTF-8?B?UGV0dGVyaSBSw6R0eQ==?= User-Agent: Mozilla/5.0 (X11; U; Linux i686; fi; rv:1.8.1.23) Gecko/20090916 Thunderbird/2.0.0.23 Mnenhy/0.7.6.666 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Requiring two sets of eyes for all eclass commits References: <4BD32D26.5090005@gentoo.org> <20100424201404.32b5ad52@gentoo.org> In-Reply-To: <20100424201404.32b5ad52@gentoo.org> X-Enigmail-Version: 1.0.1 OpenPGP: id=B8E4ECF0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigC9A4D51CA696B1496520170B" X-Archives-Salt: 92288991-0d5f-4c9d-a22f-f8cc103f3947 X-Archives-Hash: 605097eba3daf44a87f8648a608584c1 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigC9A4D51CA696B1496520170B Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04/24/2010 09:14 PM, Alexis Ballier wrote: > On Sat, 24 Apr 2010 20:40:54 +0300 > Petteri R=C3=A4ty wrote: >=20 >> 17:34 < Betelgeuse> robbat2|na: how easy to it to prevent commits to >> CVS if the commit message doesn't match a certain pattern? >> 17:36 <@robbat2|na> go and checkout the CVSROOT and there should be an= >> example there >> 17:37 < Betelgeuse> robbat2|na: Ok so doable then. Thanks. >> >> What do you think about not allowing commits to eclasses without >> mentioning an another developer who has reviewed and approved the diff= >> in the commit message? There's enough people on gentoo-dev for urgent >> stuff too. >=20 > no thanks; we already have the policy to require that major changes to > broad impact eclasses have gone through -dev, no need to add more > bureaucracy. >=20 But the policy is not tested by the quizzes and we have had cases lately where large diffs have been committed without gentoo-dev review. With peer review it's likely that the reviewer is familiar with what should be sent to gentoo-dev as hesitant/new people won't give their approval that easily. Regards, Petteri --------------enigC9A4D51CA696B1496520170B Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBCAAGBQJL1BXwAAoJEPeUsk245OzwkJ4P/2YiOhHr7LYOlHKgYSyVOksW UOQn6VWIpuH8KQonpt0KU/tHftKXrLGr0jYKkedyNTYEWwv1oShjCGy1S4HWFBSi Z1Ieuunrt3VPPX7aZyMm+8hnSQgc+4ycXZGe+2KRnau6NvOZjUDwXrd4vRgAvzCB Lqu/l6AzxEKND0I64Y++tZmATA/viub2c3tBbu9qmwr0X433EzWtVS7O41cj1j5S 1GExqQf4j9Gr9wLRycmewbkbvDuvi8jgV5thoSsOIrt/E6ZSZhvSUXWlku6NmRcJ GunCk2eBESCUckmdIvn6EHS+7dTodKcGKxh053QGRBqdNF70ylHWH/34Gbze2WYK pLjEqkKr86qgQR7QPS1GmV6j0JhqVSkGnjmBCOlIaBtnyeUSxsSLcQ40cijKZjmR g3POsHjs960yiFl7fW5wcKrvNK8nsBfg2WtdBLzeOUm7bKK27mjwLKZJdEiuz96i 9c6rkkgENq0gwAXKsFF+r41j27DmYe3gj9fxbGvVFDBjBuqy3TiuVtlqckTLBdaF Wu5fSGijLKDqVl+cGyH9C5B2D+3h8HiYrFjU5iBWiX7zC1aWTt00eOcKEpPJA80N C+tznJ0auOAddm1VBFtSL1IaBSXE7iHl12LKPXhlHx+LjmPW2hNHBJ+d71d/DSOv O5oJI6Y0+Oqg/AZuL3Nn =EgZq -----END PGP SIGNATURE----- --------------enigC9A4D51CA696B1496520170B--