From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1O6R1q-0005CN-1M for garchives@archives.gentoo.org; Mon, 26 Apr 2010 16:19:26 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id B80EFE0809; Mon, 26 Apr 2010 16:19:22 +0000 (UTC) Received: from caromailp3.nss.vzwnet.com (caromailp3.vzwnet.com [69.78.1.244]) by pigeon.gentoo.org (Postfix) with ESMTP id 433B0E0776 for ; Mon, 26 Apr 2010 16:19:10 +0000 (UTC) Received: from txsldns1.nss.vzwnet.com (txsldns1.nss.txsl.vzwnet.com [10.215.210.71]) by caromailp3.nss.vzwnet.com (8.14.3/8.14.3/2.0.0) with ESMTP id o3QGJ8tZ022152 for ; Mon, 26 Apr 2010 09:19:08 -0700 (PDT) Received: from txslpc1d36.wkst.vzwnet.com (txslpc1d36.wkst.vzwnet.com [10.215.206.62]) by txsldns1.nss.vzwnet.com (8.13.8+Sun/8.13.8/1.0.1) with ESMTP id o3QGJ852022452 for ; Mon, 26 Apr 2010 11:19:08 -0500 (CDT) Received: by txslpc1d36.wkst.vzwnet.com (Postfix, from userid 1000) id 0BCA0C48039; Mon, 26 Apr 2010 11:19:08 -0500 (CDT) Subject: Re: [gentoo-dev] Re: Requiring two sets of eyes for all eclass commits From: Paul Varner To: gentoo-dev@lists.gentoo.org In-Reply-To: <4BD4153F.5000509@gentoo.org> References: <4BD32D26.5090005@gentoo.org> <20100425040601.5dc8e5d7@gentoo.org> <4BD4153F.5000509@gentoo.org> Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: quoted-printable Date: Mon, 26 Apr 2010 11:19:07 -0500 Message-ID: <1272298747.3664.4.camel@txslpc1d36.wkst.vzwnet.com> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 X-Mailer: Evolution 2.28.3.1 X-Archives-Salt: c684ea64-4194-4a68-af7a-37a33e15aab6 X-Archives-Hash: 8cba68fee76cb8782289084d73703cd3 On Sun, 2010-04-25 at 13:11 +0300, Petteri R=E4ty wrote: > On 04/25/2010 01:06 PM, Ryan Hill wrote: > > On Sat, 24 Apr 2010 20:40:54 +0300 > > Petteri R=E4ty wrote: > >=20 > >> What do you think about not allowing commits to eclasses without > >> mentioning an another developer who has reviewed and approved the diff > >> in the commit message? There's enough people on gentoo-dev for urgent > >> stuff too. > >=20 > > I think it's a good idea to strongly encourage it, but actually forcing= it > > through cvs? No thanks. I'm not tracking down another dev just to fix= a > > spelling mistake. :P > >=20 > >=20 >=20 > How did the spelling mistake get there in the first place? A review > system should reduce having them in the first place. Because the reviewer missed it. gentoolkit-0.3.0 is currently being developed by the user community and I review everything before I commit to the gentoolkit repository. It is amazing, how much still gets through the review process (including spelling errors). While reviews will catch a lot of stuff, they won't catch everything. Finally, my opinion is in line with Ryan's. Strongly encourage it, but do not force it through cvs. Regards, Paul