From mboxrd@z Thu Jan 1 00:00:00 1970
Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org)
by finch.gentoo.org with esmtp (Exim 4.60)
(envelope-from <gentoo-commits+bounces-321107-garchives=archives.gentoo.org@lists.gentoo.org>)
id 1Pu9sK-0004KT-H3
for garchives@archives.gentoo.org; Mon, 28 Feb 2011 20:39:27 +0000
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
by pigeon.gentoo.org (Postfix) with SMTP id EC8E9E0521;
Mon, 28 Feb 2011 20:39:16 +0000 (UTC)
Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183])
by pigeon.gentoo.org (Postfix) with ESMTP id BB80FE0521
for <gentoo-commits@lists.gentoo.org>; Mon, 28 Feb 2011 20:39:16 +0000 (UTC)
Received: from pelican.gentoo.org (unknown [66.219.59.40])
(using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits))
(No client certificate requested)
by smtp.gentoo.org (Postfix) with ESMTPS id 3675C1B40AE
for <gentoo-commits@lists.gentoo.org>; Mon, 28 Feb 2011 20:39:16 +0000 (UTC)
Received: from localhost.localdomain (localhost [127.0.0.1])
by pelican.gentoo.org (Postfix) with ESMTP id 97E298006A
for <gentoo-commits@lists.gentoo.org>; Mon, 28 Feb 2011 20:39:15 +0000 (UTC)
From: "Zac Medico" <zmedico@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Content-type: text/plain; charset=UTF-8
Reply-To: gentoo-dev@lists.gentoo.org, "Zac Medico" <zmedico@gentoo.org>
Message-ID: <afd70ceacf522efeb64ea0cbf4626c7533e2c021.zmedico@gentoo>
Subject: [gentoo-commits] proj/portage:master commit in: pym/repoman/
X-VCS-Repository: proj/portage
X-VCS-Files: pym/repoman/checks.py
X-VCS-Directories: pym/repoman/
X-VCS-Committer: zmedico
X-VCS-Committer-Name: Zac Medico
X-VCS-Revision: afd70ceacf522efeb64ea0cbf4626c7533e2c021
Date: Mon, 28 Feb 2011 20:39:15 +0000 (UTC)
Precedence: bulk
List-Post: <mailto:gentoo-commits@lists.gentoo.org>
List-Help: <mailto:gentoo-commits+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-commits+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-commits+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-commits.gentoo.org>
X-BeenThere: gentoo-commits@lists.gentoo.org
Content-Transfer-Encoding: quoted-printable
X-Archives-Salt:
X-Archives-Hash: ade9405e148a8a3f5729f0e5ab113d89
commit: afd70ceacf522efeb64ea0cbf4626c7533e2c021
Author: Zac Medico <zmedico <AT> gentoo <DOT> org>
AuthorDate: Mon Feb 28 20:37:22 2011 +0000
Commit: Zac Medico <zmedico <AT> gentoo <DOT> org>
CommitDate: Mon Feb 28 20:37:22 2011 +0000
URL: http://git.overlays.gentoo.org/gitweb/?p=3Dproj/portage.git;a=
=3Dcommit;h=3Dafd70cea
repoman: variable.usedwithhelpers ignore quoted
---
pym/repoman/checks.py | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/pym/repoman/checks.py b/pym/repoman/checks.py
index 566984a..200b542 100644
--- a/pym/repoman/checks.py
+++ b/pym/repoman/checks.py
@@ -333,7 +333,9 @@ class NoOffsetWithHelpers(LineCheck):
helpers """
=20
repoman_check_name =3D 'variable.usedwithhelpers'
- re =3D re.compile(r'^[^#]*\b(dodir|dohard|exeinto|insinto|into)\s+"?\$\=
{?(D|ROOT|ED|EROOT|EPREFIX)\b.*')
+ # Ignore matches in quoted strings like this:
+ # elog "installed into ${ROOT}usr/share/php5/apc/."
+ re =3D re.compile(r'^[^#"\']*\b(dodir|dohard|exeinto|insinto|into)\s+"?=
\$\{?(D|ROOT|ED|EROOT|EPREFIX)\b.*')
error =3D errors.NO_OFFSET_WITH_HELPERS
=20
class ImplicitRuntimeDeps(LineCheck):