From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 1BE9B13877A for ; Tue, 19 Aug 2014 12:18:54 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id E921CE0A65; Tue, 19 Aug 2014 12:18:06 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id ADAA4E0976 for ; Tue, 19 Aug 2014 12:17:49 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id DA4D134002D for ; Tue, 19 Aug 2014 12:17:43 +0000 (UTC) Received: from localhost.localdomain (localhost [127.0.0.1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id C21A33BBF for ; Tue, 19 Aug 2014 07:01:05 +0000 (UTC) From: "Michał Górny" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Michał Górny" Message-ID: <1407789850.852f5b5d7f2dd138a1d1b5dfa92b12bba51cf0a4.mgorny@gentoo> Subject: [gentoo-commits] proj/portage:master commit in: bin/ X-VCS-Repository: proj/portage X-VCS-Files: bin/misc-functions.sh X-VCS-Directories: bin/ X-VCS-Committer: mgorny X-VCS-Committer-Name: Michał Górny X-VCS-Revision: 852f5b5d7f2dd138a1d1b5dfa92b12bba51cf0a4 X-VCS-Branch: master Date: Tue, 19 Aug 2014 07:01:05 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Archives-Salt: 624d2518-6666-4256-946c-ff755298c921 X-Archives-Hash: a892396f3f127b4389a83fb3eab41074 Message-ID: <20140819070105.IzYbsE0iOMzjvJYJjkk34zaxfekLdM0-aeMtA-3i6ls@z> commit: 852f5b5d7f2dd138a1d1b5dfa92b12bba51cf0a4 Author: Michał Górny gentoo org> AuthorDate: Thu Jul 24 08:03:52 2014 +0000 Commit: Michał Górny gentoo org> CommitDate: Mon Aug 11 20:44:10 2014 +0000 URL: http://sources.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=852f5b5d QA: Warn when systemd units use /etc/conf.d Acked-by: Alexander Berntsen gentoo.org> Acked-by: Brian Dolbec gentoo.org> Reviewed-by: Anthony G. Basile gentoo.org> --- bin/misc-functions.sh | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/bin/misc-functions.sh b/bin/misc-functions.sh index 4e0f1fc..961738f 100755 --- a/bin/misc-functions.sh +++ b/bin/misc-functions.sh @@ -595,6 +595,21 @@ install_qa_check() { done fi + # Common mistakes in systemd service files. + if type -P pkg-config >/dev/null && pkg-config --exists systemd; then + systemddir=$(pkg-config --variable=systemdsystemunitdir systemd) + else + systemddir=/usr/lib/systemd/system + fi + if [[ -d ${ED%/}${systemddir} ]]; then + f=$(grep -sH '^EnvironmentFile.*=.*/etc/conf\.d' "${ED%/}${systemddir}"/*.service) + if [[ -n ${f} ]] ; then + eqawarn "QA Notice: systemd units using /etc/conf.d detected:" + eqawarn "${f//${D}}" + eqawarn "See: https://wiki.gentoo.org/wiki/Project:Systemd/conf.d_files" + fi + fi + # Look for leaking LDFLAGS into pkg-config files f=$(egrep -sH '^Libs.*-Wl,(-O[012]|--hash-style)' "${ED}"/usr/*/pkgconfig/*.pc) if [[ -n ${f} ]] ; then