[gentoo-commits] gentoo-x86 commit in kde-base/katepart/files: katepart-4.10.4-crash.patch

[gentoo-commits] gentoo-x86 commit in kde-base/katepart/files: katepart-4.10.4-crash.patch

[Michael Palimaka (kensington)]

kensington    13/06/22 15:02:40

  Added:                katepart-4.10.4-crash.patch
  Log:
  Backport crash patch from upstream.
  
  (Portage version: 2.1.12.5/cvs/Linux x86_64, signed Manifest commit with key 675D0D2C)

Revision  Changes    Path
1.1                  kde-base/katepart/files/katepart-4.10.4-crash.patch

file : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/kde-base/katepart/files/katepart-4.10.4-crash.patch?rev=1.1&view=markup
plain: http://sources.gentoo.org/viewvc.cgi/gentoo-x86/kde-base/katepart/files/katepart-4.10.4-crash.patch?rev=1.1&content-type=text/plain

Index: katepart-4.10.4-crash.patch
===================================================================
From d2e34218068432ba9c312591067e53eda67cb68a Mon Sep 17 00:00:00 2001
From: Dominik Haumann <dhaumann@kde.org>
Date: Wed, 12 Jun 2013 22:30:32 +0200
Subject: [PATCH] fix crash in passive notification system

@packagers / distributions: Better backport this to you 4.10.4 packages.

FIXED-IN: 4.10.5
BUG: 320302
---
 part/view/katemessagewidget.cpp | 21 +++++++++++++++++++--
 1 file changed, 19 insertions(+), 2 deletions(-)

diff --git a/part/view/katemessagewidget.cpp b/part/view/katemessagewidget.cpp
index d3c895f..6c227c0 100644
--- a/part/view/katemessagewidget.cpp
+++ b/part/view/katemessagewidget.cpp
@@ -225,11 +225,28 @@ void KateMessageWidget::startAutoHideTimer()
     return;
   }
 
+  // switching KateViews may result isVisible() == true and still m_messageList.size() == 0.
+  // The problem is that the hideEvent is never called for the KMessageWidget, if the
+  // parent widget is hidden. In that case, we 'miss' that the notification is gone...
+  if (m_messageList.size() == 0) {
+    m_hideAnimationRunning = false;
+    m_autoHideTimerRunning = false;
+    m_autoHideTime = -1;
+
+    if (isVisible()) {
+      m_hideAnimationRunning = true;
+      if (m_fadeEffect) {
+        m_fadeEffect->fadeOut();
+      } else {
+        m_messageWidget->animatedHide();
+      }
+    }
+    return;
+  }
+
   // remember that auto hide timer is running
   m_autoHideTimerRunning = true;
 
-  // the message must still still be valid
-  Q_ASSERT(m_messageList.size());
   KTextEditor::Message* message = m_messageList[0];
   QTimer::singleShot(m_autoHideTime == 0 ? (6*1000) : m_autoHideTime, message, SLOT(deleteLater()));
 }
-- 
1.8.2.1

[gentoo-commits] gentoo-x86 commit in kde-base/katepart/files: katepart-4.10.4-crash.patch

[Johannes Huber (johu)]

johu        13/12/14 21:49:44

  Removed:              katepart-4.10.4-crash.patch
  Log:
  Remove unused patch.
  
  (Portage version: 2.2.7/cvs/Linux x86_64, signed Manifest commit with key F3CFD2BD)