From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id BB02A158046 for ; Tue, 14 Oct 2025 12:59:42 +0000 (UTC) Received: from lists.gentoo.org (bobolink.gentoo.org [140.211.166.189]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519) (No client certificate requested) (Authenticated sender: relay-lists.gentoo.org@gentoo.org) by smtp.gentoo.org (Postfix) with ESMTPSA id A26B434102E for ; Tue, 14 Oct 2025 12:59:42 +0000 (UTC) Received: from bobolink.gentoo.org (localhost [127.0.0.1]) by bobolink.gentoo.org (Postfix) with ESMTP id 27FDB110561; Tue, 14 Oct 2025 12:59:35 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519) (No client certificate requested) by bobolink.gentoo.org (Postfix) with ESMTPS id 1FE01110561 for ; Tue, 14 Oct 2025 12:59:35 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id D178833BF08 for ; Tue, 14 Oct 2025 12:59:34 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 4AE973AE6 for ; Tue, 14 Oct 2025 12:59:33 +0000 (UTC) From: "Sam James" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Sam James" Message-ID: <1760446749.ed3a22f2748aea9f7139aaef5a7b009973618310.sam@gentoo> Subject: [gentoo-commits] proj/gentoo-functions:master commit in: / X-VCS-Repository: proj/gentoo-functions X-VCS-Files: functions.sh X-VCS-Directories: / X-VCS-Committer: sam X-VCS-Committer-Name: Sam James X-VCS-Revision: ed3a22f2748aea9f7139aaef5a7b009973618310 X-VCS-Branch: master Date: Tue, 14 Oct 2025 12:59:33 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 24952bcf-7ed1-41be-bfbe-de6bec757ff5 X-Archives-Hash: 4eb95a281c58b4f2798fa427050e40e1 commit: ed3a22f2748aea9f7139aaef5a7b009973618310 Author: Kerin Millar plushkava net> AuthorDate: Tue Oct 14 07:08:42 2025 +0000 Commit: Sam James gentoo org> CommitDate: Tue Oct 14 12:59:09 2025 +0000 URL: https://gitweb.gentoo.org/proj/gentoo-functions.git/commit/?id=ed3a22f2 Reorganise and trim the _update_columns() commentary Signed-off-by: Kerin Millar plushkava.net> Signed-off-by: Sam James gentoo.org> functions.sh | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/functions.sh b/functions.sh index 0c98e84..ba895df 100644 --- a/functions.sh +++ b/functions.sh @@ -871,14 +871,13 @@ _update_columns() # updates can be performed is throttled to intervals of half a # second. Secondly, if running on bash then the COLUMNS variable # may be gauged, albeit only in situations where doing so can be - # expected to work reliably; it is an unreliable method where - # operating from a subshell. Note that executing true(1) is - # faster than executing stty(1) within a comsub. + # expected to work reliably. # shellcheck disable=3028 if _should_throttle 50; then test "${genfun_cols}" return elif [ "${genfun_bin_true}" ] && [ "$$" = "${BASHPID}" ]; then + # To execute the true binary is faster than stty(1). "${genfun_bin_true}" set -- 0 "${COLUMNS}" else