From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 9BC45158200 for ; Sun, 14 Sep 2025 09:35:04 +0000 (UTC) Received: from lists.gentoo.org (bobolink.gentoo.org [140.211.166.189]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519) (No client certificate requested) (Authenticated sender: relay-lists.gentoo.org@gentoo.org) by smtp.gentoo.org (Postfix) with ESMTPSA id 7BF15340824 for ; Sun, 14 Sep 2025 09:35:04 +0000 (UTC) Received: from bobolink.gentoo.org (localhost [127.0.0.1]) by bobolink.gentoo.org (Postfix) with ESMTP id 69A52110571; Sun, 14 Sep 2025 09:35:03 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519) (No client certificate requested) by bobolink.gentoo.org (Postfix) with ESMTPS id 601FF110571 for ; Sun, 14 Sep 2025 09:35:03 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 069773406A2 for ; Sun, 14 Sep 2025 09:35:03 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 8C4FD3995 for ; Sun, 14 Sep 2025 09:35:01 +0000 (UTC) From: "Sam James" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Sam James" Message-ID: <1757842496.1d0056fafb4bb4eca9cbbdb563473347382acc14.sam@gentoo> Subject: [gentoo-commits] proj/portage:master commit in: lib/portage/package/ebuild/ X-VCS-Repository: proj/portage X-VCS-Files: lib/portage/package/ebuild/config.py X-VCS-Directories: lib/portage/package/ebuild/ X-VCS-Committer: sam X-VCS-Committer-Name: Sam James X-VCS-Revision: 1d0056fafb4bb4eca9cbbdb563473347382acc14 X-VCS-Branch: master Date: Sun, 14 Sep 2025 09:35:01 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 86b07dc7-b478-4596-9c76-5c0b0511e09a X-Archives-Hash: 229345b5c2b0847ff3d4b0fdafc466a2 commit: 1d0056fafb4bb4eca9cbbdb563473347382acc14 Author: Mike Gilbert gentoo org> AuthorDate: Wed Oct 4 14:28:51 2023 +0000 Commit: Sam James gentoo org> CommitDate: Sun Sep 14 09:34:56 2025 +0000 URL: https://gitweb.gentoo.org/proj/portage.git/commit/?id=1d0056fa ebuild: do not drop FEATURES=test when USE=-test By convention the "test" USE flag is used to control dependencies required for execution of the src_test function. The "test" USE flag has no special meaning in PMS. The Gentoo Policy Guide [1] advises that ebuilds must make use of RESTRICT to disable tests based on USE flags. Current versions of Portage will not run tests when RESTRICT=test is set, regardless of the FEATURES setting. This code in Portage predates the Gentoo policy. It is unneeded since the policy was created and ebuilds have been updated with the necessary RESTRICT values. [1] https://projects.gentoo.org/qa/policy-guide/other-metadata.html#pg0703 Signed-off-by: Mike Gilbert gentoo.org> Part-of: https://github.com/gentoo/portage/pull/1116 Closes: https://github.com/gentoo/portage/pull/1116 Signed-off-by: Sam James gentoo.org> lib/portage/package/ebuild/config.py | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/lib/portage/package/ebuild/config.py b/lib/portage/package/ebuild/config.py index 272fcdb5d1..e93655e58b 100644 --- a/lib/portage/package/ebuild/config.py +++ b/lib/portage/package/ebuild/config.py @@ -2187,20 +2187,6 @@ class config: "BASH_FUNC____in_portage_iuse%%" ] = "() { [[ $1 =~ ${PORTAGE_IUSE} ]]; }" - ebuild_force_test = not restrict_test and self.get("EBUILD_FORCE_TEST") == "1" - - if "test" in explicit_iuse or iuse_implicit_match("test"): - if "test" in self.features: - if ebuild_force_test and "test" in self.usemask: - self.usemask = frozenset(x for x in self.usemask if x != "test") - if restrict_test or ("test" in self.usemask and not ebuild_force_test): - # "test" is in IUSE and USE=test is masked, so execution - # of src_test() probably is not reliable. Therefore, - # temporarily disable FEATURES=test just for this package. - self["FEATURES"] = " ".join( - x for x in sorted(self.features) if x != "test" - ) - # Allow _* flags from USE_EXPAND wildcards to pass through here. use.difference_update( [