From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 1407315808A for ; Sat, 02 Aug 2025 16:31:45 +0000 (UTC) Received: from lists.gentoo.org (bobolink.gentoo.org [140.211.166.189]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519) (No client certificate requested) (Authenticated sender: relay-lists.gentoo.org@gentoo.org) by smtp.gentoo.org (Postfix) with ESMTPSA id 0030B340D32 for ; Sat, 02 Aug 2025 16:31:45 +0000 (UTC) Received: from bobolink.gentoo.org (localhost [127.0.0.1]) by bobolink.gentoo.org (Postfix) with ESMTP id 0227C1104DB; Sat, 02 Aug 2025 16:31:44 +0000 (UTC) Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519) (No client certificate requested) by bobolink.gentoo.org (Postfix) with ESMTPS id F0E711104DB for ; Sat, 02 Aug 2025 16:31:43 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id AE3A13406D6 for ; Sat, 02 Aug 2025 16:31:43 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 5008C317E for ; Sat, 02 Aug 2025 16:31:42 +0000 (UTC) From: "Sam James" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Sam James" Message-ID: <1754152288.a9f83f17feb24cb1ba9ab364aee16be7ef4dd834.sam@gentoo> Subject: [gentoo-commits] proj/portage:master commit in: bin/ X-VCS-Repository: proj/portage X-VCS-Files: bin/isolated-functions.sh X-VCS-Directories: bin/ X-VCS-Committer: sam X-VCS-Committer-Name: Sam James X-VCS-Revision: a9f83f17feb24cb1ba9ab364aee16be7ef4dd834 X-VCS-Branch: master Date: Sat, 02 Aug 2025 16:31:42 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 42281a56-8e0f-4d7a-99e9-ff7db51159f8 X-Archives-Hash: 65c9cb56cabc15be88eeaa9064c59924 commit: a9f83f17feb24cb1ba9ab364aee16be7ef4dd834 Author: Kerin Millar plushkava net> AuthorDate: Thu Jul 24 21:18:33 2025 +0000 Commit: Sam James gentoo org> CommitDate: Sat Aug 2 16:31:28 2025 +0000 URL: https://gitweb.gentoo.org/proj/portage.git/commit/?id=a9f83f17 isolated-functions.sh: suppress the SC2219 notice throughout As a matter of style, shellcheck recommends that the (( … )) compound command be preferred over the let builtin for arithmetic. Presently, this recommendation is being suppressed for the body of the assert() function. Instead, suppress it for the "isolated-functions.sh" unit in its entirety. The reason for this change is that a forthcoming commit will introduce an additional function that uses the let builtin. See-also: 91283cf5b59a482061bf4cf440e774a0826c664b Signed-off-by: Kerin Millar plushkava.net> Signed-off-by: Sam James gentoo.org> bin/isolated-functions.sh | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/bin/isolated-functions.sh b/bin/isolated-functions.sh index b2f4b93628..546efa0190 100644 --- a/bin/isolated-functions.sh +++ b/bin/isolated-functions.sh @@ -1,7 +1,7 @@ #!/usr/bin/env bash # Copyright 1999-2024 Gentoo Authors # Distributed under the terms of the GNU General Public License v2 -# shellcheck disable=2128,2185 +# shellcheck disable=2128,2185,2219 source "${PORTAGE_BIN_PATH:?}/eapi.sh" || exit @@ -23,7 +23,6 @@ fi shopt -s expand_aliases assert() { - # shellcheck disable=2219 IFS='|' expression=${PIPESTATUS[*]} let '! expression' || die "$@" }