public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Sam James" <sam@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: media-radio/unixcw/
Date: Sat, 28 Jun 2025 03:28:52 +0000 (UTC)	[thread overview]
Message-ID: <1751081211.d92f25030a8fad58d6472bb5a7a1661d07abfdc7.sam@gentoo> (raw)

commit:     d92f25030a8fad58d6472bb5a7a1661d07abfdc7
Author:     Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Sat Jun 28 03:26:51 2025 +0000
Commit:     Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Sat Jun 28 03:26:51 2025 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d92f2503

media-radio/unixcw: fix build w/ qt-6.9 + LTO

Workaround for bug #957446#c16). Building via autotools requires a macro
like bitcoin or gpgme used in the past to ensure that -mno-direct-extern-access
is used if Qt itself was built with it.

The flag isn't in Qt's .pc files. It's easiest to just workaround this
with -fPIC, but in future, we might either have an eclass helper for this,
or just encourage people to use the m4 macro.

This refines the workaround from cebf7ed59e24ea1b6aa9b1d9bd7dee3d72ee56fb
as filtering LTO is a heavy hammer that we can avoid here. I hope to
come back to the ideas I mention above, though the priority of that depends
on how many others of these show up.

Closes: https://bugs.gentoo.org/957446
Signed-off-by: Sam James <sam <AT> gentoo.org>

 media-radio/unixcw/unixcw-3.6.1-r2.ebuild | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/media-radio/unixcw/unixcw-3.6.1-r2.ebuild b/media-radio/unixcw/unixcw-3.6.1-r2.ebuild
index 6024e2349eec..935375544d24 100644
--- a/media-radio/unixcw/unixcw-3.6.1-r2.ebuild
+++ b/media-radio/unixcw/unixcw-3.6.1-r2.ebuild
@@ -37,8 +37,15 @@ src_prepare() {
 }
 
 src_configure() {
-	# fails with -flto (see bug #957446)
-	filter-lto
+	# Workaround for bug #957446#c16. Building via autotools requires a
+	# macro like bitcoin or gpgme used in the past to ensure that
+	# -mno-direct-extern-access is used if Qt itself was built with it.
+	# The flag isn't in Qt's .pc files. It's easiest to just workaround
+	# this with -fPIC, but in future, we might either have an eclass helper
+	# for this, or just encourage people to use the m4 macro.
+	append-flags -fPIC
+	append-ldflags -fPIC
+
 	econf --libdir="${EPREFIX}/usr/$(get_libdir)" \
 		$(use_enable pulseaudio ) \
 		$(use_enable alsa ) \


             reply	other threads:[~2025-06-28  3:29 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-28  3:28 Sam James [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-06-15 13:29 [gentoo-commits] repo/gentoo:master commit in: media-radio/unixcw/ Thomas Beierlein
2025-03-20 15:41 Thomas Beierlein
2025-03-20  8:35 Arthur Zamarin
2025-03-15 15:08 Sam James
2025-03-15 15:08 Sam James
2024-02-15 15:17 Thomas Beierlein
2024-01-15 18:18 Sam James
2024-01-15 18:18 Sam James
2023-11-25 16:47 Thomas Beierlein
2023-07-03 22:02 Conrad Kostecki
2023-07-03 22:02 Conrad Kostecki
2023-06-18 13:03 Thomas Beierlein
2022-08-24  5:29 Agostino Sarubbo
2022-08-24  5:27 Agostino Sarubbo
2022-08-23 20:26 Agostino Sarubbo
2022-07-16  8:12 Thomas Beierlein
2022-04-15  8:15 Thomas Beierlein
2021-10-14 16:42 Thomas Beierlein
2020-07-20  5:31 Thomas Beierlein
2020-07-19 12:18 Agostino Sarubbo
2020-07-17 15:17 Agostino Sarubbo
2020-07-17 15:09 Agostino Sarubbo
2020-05-24 16:12 Thomas Beierlein
2017-12-31 10:37 Thomas Beierlein
2017-06-24 10:58 Thomas Beierlein
2017-06-04 19:20 Tobias Klausmann
2017-06-04 10:42 Agostino Sarubbo
2017-06-02 20:02 Agostino Sarubbo
2016-10-11 16:45 Thomas Beierlein
2016-02-03 16:05 Tobias Klausmann
2016-01-23 17:34 Agostino Sarubbo
2015-12-21 17:54 Thomas Beierlein
2015-12-21 17:51 Thomas Beierlein
2015-12-21 17:22 Thomas Beierlein
2015-09-22  8:57 Agostino Sarubbo
2015-09-19 13:30 Agostino Sarubbo
2015-09-14 13:32 Tobias Klausmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1751081211.d92f25030a8fad58d6472bb5a7a1661d07abfdc7.sam@gentoo \
    --to=sam@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox