From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 238F3158074 for ; Tue, 24 Jun 2025 08:38:51 +0000 (UTC) Received: from lists.gentoo.org (bobolink.gentoo.org [140.211.166.189]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519) (No client certificate requested) (Authenticated sender: relay-lists.gentoo.org@gentoo.org) by smtp.gentoo.org (Postfix) with ESMTPSA id 11051340E98 for ; Tue, 24 Jun 2025 08:38:51 +0000 (UTC) Received: from bobolink.gentoo.org (localhost [127.0.0.1]) by bobolink.gentoo.org (Postfix) with ESMTP id 0AEA4110362; Tue, 24 Jun 2025 08:38:50 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by bobolink.gentoo.org (Postfix) with ESMTPS id 0072A110362 for ; Tue, 24 Jun 2025 08:38:49 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id A0A96340E98 for ; Tue, 24 Jun 2025 08:38:49 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 45B102A71 for ; Tue, 24 Jun 2025 08:38:48 +0000 (UTC) From: "Alfredo Tupone" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Alfredo Tupone" Message-ID: <1750752772.9d786a54cda2496f5e018e7b0ef452801e7dd8a9.tupone@gentoo> Subject: [gentoo-commits] repo/gentoo:master commit in: dev-util/hip/files/, dev-util/hip/ X-VCS-Repository: repo/gentoo X-VCS-Files: dev-util/hip/files/hip-6.4.1-bad-assert.patch dev-util/hip/hip-6.4.1-r1.ebuild dev-util/hip/hip-6.4.1.ebuild X-VCS-Directories: dev-util/hip/files/ dev-util/hip/ X-VCS-Committer: tupone X-VCS-Committer-Name: Alfredo Tupone X-VCS-Revision: 9d786a54cda2496f5e018e7b0ef452801e7dd8a9 X-VCS-Branch: master Date: Tue, 24 Jun 2025 08:38:48 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: e4f49f48-ec9a-40d7-9a81-7e3f4cb3f85f X-Archives-Hash: 846219bfc672bfd9410dbc41a9aad684 commit: 9d786a54cda2496f5e018e7b0ef452801e7dd8a9 Author: Sv. Lockal gmail com> AuthorDate: Mon Jun 23 21:08:55 2025 +0000 Commit: Alfredo Tupone gentoo org> CommitDate: Tue Jun 24 08:12:52 2025 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9d786a54 dev-util/hip: Remove invalid assert (caused random unittest failures in hiprt) Signed-off-by: Sv. Lockal gmail.com> Part-of: https://github.com/gentoo/gentoo/pull/42717 Signed-off-by: Alfredo Tupone gentoo.org> dev-util/hip/files/hip-6.4.1-bad-assert.patch | 15 +++++++++++++++ dev-util/hip/{hip-6.4.1.ebuild => hip-6.4.1-r1.ebuild} | 1 + 2 files changed, 16 insertions(+) diff --git a/dev-util/hip/files/hip-6.4.1-bad-assert.patch b/dev-util/hip/files/hip-6.4.1-bad-assert.patch new file mode 100644 index 000000000000..481da014f67c --- /dev/null +++ b/dev-util/hip/files/hip-6.4.1-bad-assert.patch @@ -0,0 +1,15 @@ +Remove invalid assert (caused random unittest failures in hiprt) + +Upstream bug: https://github.com/ROCm/clr/issues/148 +Backports commit: https://github.com/ROCm/clr/commit/8fcaa1ca938bf6e57625d3fae3f80b00e86df266 +--- a/rocclr/platform/commandqueue.cpp ++++ b/rocclr/platform/commandqueue.cpp +@@ -156,8 +156,6 @@ void HostQueue::finish(bool cpu_wait) { + if (IS_HIP) { + command = getLastQueuedCommand(true); + if (command == nullptr) { +- assert(GetSubmissionBatch() == nullptr && +- "Can't claim the queue is finished with the active batch!"); + return; + } + // Force blocking wait if requested. That allows to avoid a build up of unreleased CPU commands diff --git a/dev-util/hip/hip-6.4.1.ebuild b/dev-util/hip/hip-6.4.1-r1.ebuild similarity index 99% rename from dev-util/hip/hip-6.4.1.ebuild rename to dev-util/hip/hip-6.4.1-r1.ebuild index b1a1a69d3995..e15f8c373794 100644 --- a/dev-util/hip/hip-6.4.1.ebuild +++ b/dev-util/hip/hip-6.4.1-r1.ebuild @@ -82,6 +82,7 @@ PATCHES=( "${FILESDIR}/${PN}-6.3.0-no-isystem-usr-include.patch" "${FILESDIR}/${PN}-6.3.0-clr-fix-libcxx.patch" "${FILESDIR}/${PN}-6.4.1-no-glibcxx-assert.patch" + "${FILESDIR}/${PN}-6.4.1-bad-assert.patch" ) hip_test_wrapper() {