From: "Sam James" <sam@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] proj/gcc-patches:master commit in: 16.0.0/gentoo/
Date: Wed, 11 Jun 2025 05:05:48 +0000 (UTC) [thread overview]
Message-ID: <1749618341.d986f43364eb7a59fcb4e16caafaba46f9f0fcb8.sam@gentoo> (raw)
commit: d986f43364eb7a59fcb4e16caafaba46f9f0fcb8
Author: Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Wed Jun 11 05:05:41 2025 +0000
Commit: Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Wed Jun 11 05:05:41 2025 +0000
URL: https://gitweb.gentoo.org/proj/gcc-patches.git/commit/?id=d986f433
16.0.0: drop now-upstream patch
Signed-off-by: Sam James <sam <AT> gentoo.org>
...ll_internal-fn-Fix-up-.POPCOUNT-expansion.patch | 61 ----------------------
1 file changed, 61 deletions(-)
diff --git a/16.0.0/gentoo/85_all_internal-fn-Fix-up-.POPCOUNT-expansion.patch b/16.0.0/gentoo/85_all_internal-fn-Fix-up-.POPCOUNT-expansion.patch
deleted file mode 100644
index 3a97e78..0000000
--- a/16.0.0/gentoo/85_all_internal-fn-Fix-up-.POPCOUNT-expansion.patch
+++ /dev/null
@@ -1,61 +0,0 @@
-https://inbox.sourceware.org/gcc-patches/aEikagD%2FQXo+jH5H@tucnak/
-
-From a345b00cf30f9a10dfdb6be93287b4885fea68fd Mon Sep 17 00:00:00 2001
-Message-ID: <a345b00cf30f9a10dfdb6be93287b4885fea68fd.1749611907.git.sam@gentoo.org>
-From: Jakub Jelinek <jakub@redhat.com>
-Date: Tue, 10 Jun 2025 23:32:26 +0200
-Subject: [PATCH] internal-fn: Fix up .POPCOUNT expansion
-
-Hi!
-
-Apparently my ranger during expansion patch broke bootstrap on
-aarch64-linux, while building libsupc++, there is endless recursion
-on __builtin_popcountl (x) == 1 expansion.
-The hack to temporarily replace SSA_NAME_VAR of the lhs which replaced
-the earlier hack to temporarily change the gimple_call_lhs relies on
-the lhs being expanded with EXPAND_WRITE when expanding that ifn call.
-Unfortunately, in two spots I was using expand_normal (lhs) instead
-of expand_expr (lhs, NULL_RTX, VOIDmode, EXPAND_WRITE) which was used
-everywhere else in internal-fn.cc. This happened to work fine in the
-past, but doesn't anymore. git blame shows it was my patch using
-these incorrect calls.
-
-Fixed thusly, bootstrap/regtests on x86_64-linux, i686-linux and
-aarch64-linux are running, ok for trunk if it passes?
-
-2025-06-10 Jakub Jelinek <jakub@redhat.com>
-
- * internal-fn.cc (expand_POPCOUNT): Use
- expand_expr (lhs, NULL_RTX, VOIDmode, EXPAND_WRITE) instead of
- expand_normal (lhs).
----
- gcc/internal-fn.cc | 4 ++--
- 1 file changed, 2 insertions(+), 2 deletions(-)
-
-diff --git a/gcc/internal-fn.cc b/gcc/internal-fn.cc
-index a0a73fefb906..3f4ac937367d 100644
---- a/gcc/internal-fn.cc
-+++ b/gcc/internal-fn.cc
-@@ -5561,7 +5561,7 @@ expand_POPCOUNT (internal_fn fn, gcall *stmt)
- expand_unary_optab_fn (fn, stmt, popcount_optab);
- rtx_insn *popcount_insns = end_sequence ();
- start_sequence ();
-- rtx plhs = expand_normal (lhs);
-+ rtx plhs = expand_expr (lhs, NULL_RTX, VOIDmode, EXPAND_WRITE);
- rtx pcmp = emit_store_flag (NULL_RTX, EQ, plhs, const1_rtx, lhsmode, 0, 0);
- if (pcmp == NULL_RTX)
- {
-@@ -5603,7 +5603,7 @@ expand_POPCOUNT (internal_fn fn, gcall *stmt)
- {
- start_sequence ();
- emit_insn (cmp_insns);
-- plhs = expand_normal (lhs);
-+ plhs = expand_expr (lhs, NULL_RTX, VOIDmode, EXPAND_WRITE);
- if (GET_MODE (cmp) != GET_MODE (plhs))
- cmp = convert_to_mode (GET_MODE (plhs), cmp, 1);
- /* For `<= 1`, we need to produce `2 - cmp` or `cmp ? 1 : 2` as that
-
-base-commit: 2c3ce07c568037a085bfcc438e2e823060980225
---
-2.49.0
-
next reply other threads:[~2025-06-11 5:05 UTC|newest]
Thread overview: 104+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-11 5:05 Sam James [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-10-21 0:33 [gentoo-commits] proj/gcc-patches:master commit in: 16.0.0/gentoo/ Sam James
2025-10-19 22:41 Sam James
2025-10-18 18:22 Sam James
2025-10-13 2:49 Sam James
2025-10-09 7:31 Sam James
2025-10-09 2:26 Sam James
2025-10-09 2:26 Sam James
2025-10-05 23:05 Sam James
2025-10-05 22:50 Sam James
2025-10-02 11:05 Sam James
2025-10-02 11:04 Sam James
2025-10-02 4:55 Sam James
2025-10-02 1:18 Sam James
2025-10-02 0:40 Sam James
2025-10-02 0:36 Sam James
2025-10-02 0:30 Sam James
2025-09-17 18:41 Sam James
2025-09-17 3:04 Sam James
2025-09-16 19:23 Sam James
2025-09-14 11:26 Sam James
2025-09-13 13:16 Sam James
2025-09-07 22:42 Sam James
2025-09-06 2:42 Sam James
2025-09-05 12:44 Sam James
2025-09-01 8:04 Sam James
2025-08-31 22:43 Sam James
2025-08-30 14:06 Sam James
2025-08-30 8:05 Sam James
2025-08-30 6:57 Sam James
2025-08-30 0:12 Sam James
2025-08-29 21:26 Sam James
2025-08-29 21:02 Sam James
2025-08-29 20:24 Sam James
2025-08-29 20:18 Sam James
2025-08-29 18:38 Sam James
2025-08-29 12:15 Sam James
2025-08-28 17:57 Sam James
2025-08-28 5:27 Sam James
2025-08-27 4:19 Sam James
2025-08-26 23:42 Sam James
2025-08-26 4:48 Sam James
2025-08-26 0:56 Sam James
2025-08-25 3:55 Sam James
2025-08-24 23:42 Sam James
2025-08-21 16:11 Sam James
2025-08-20 20:45 Sam James
2025-08-20 14:10 Sam James
2025-08-20 1:16 Sam James
2025-08-20 1:10 Sam James
2025-08-19 16:30 Sam James
2025-08-18 23:52 Sam James
2025-08-18 23:08 Sam James
2025-08-17 22:45 Sam James
2025-08-17 21:01 Sam James
2025-08-17 16:30 Sam James
2025-08-17 15:44 Sam James
2025-08-17 15:10 Sam James
2025-08-16 23:06 Sam James
2025-08-05 0:23 Sam James
2025-07-30 22:35 Sam James
2025-07-30 0:44 Sam James
2025-07-30 0:44 Sam James
2025-07-25 18:49 Sam James
2025-07-23 11:22 Sam James
2025-07-22 23:56 Sam James
2025-07-21 14:02 Sam James
2025-07-21 1:12 Sam James
2025-07-14 16:03 Sam James
2025-07-14 4:09 Sam James
2025-07-14 2:55 Sam James
2025-07-14 2:55 Sam James
2025-07-14 2:40 Sam James
2025-07-13 23:11 Sam James
2025-07-13 1:09 Sam James
2025-07-12 15:24 Sam James
2025-07-12 15:23 Sam James
2025-07-10 12:34 Sam James
2025-07-10 1:22 Sam James
2025-07-10 0:50 Sam James
2025-07-07 20:49 Sam James
2025-07-06 22:41 Sam James
2025-07-03 1:29 Sam James
2025-06-30 6:26 Sam James
2025-06-29 0:29 Sam James
2025-06-19 16:59 Sam James
2025-06-19 0:58 Sam James
2025-06-19 0:58 Sam James
2025-06-18 21:17 Sam James
2025-06-18 9:53 Sam James
2025-06-18 9:06 Sam James
2025-06-13 12:03 Sam James
2025-06-12 20:34 Sam James
2025-06-12 14:05 Sam James
2025-06-12 7:27 Sam James
2025-06-12 5:46 Sam James
2025-06-11 3:19 Sam James
2025-06-01 22:39 Sam James
2025-05-31 18:48 Sam James
2025-05-11 22:52 Sam James
2025-05-10 15:28 Sam James
2025-05-09 23:29 Sam James
2025-05-05 14:39 Sam James
2025-05-05 13:05 Sam James
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1749618341.d986f43364eb7a59fcb4e16caafaba46f9f0fcb8.sam@gentoo \
--to=sam@gentoo.org \
--cc=gentoo-commits@lists.gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox