From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 436FA15807A for ; Sun, 08 Jun 2025 13:36:28 +0000 (UTC) Received: from lists.gentoo.org (bobolink.gentoo.org [140.211.166.189]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: relay-lists.gentoo.org@gentoo.org) by smtp.gentoo.org (Postfix) with ESMTPSA id 2FCB3343166 for ; Sun, 08 Jun 2025 13:36:28 +0000 (UTC) Received: from bobolink.gentoo.org (localhost [127.0.0.1]) by bobolink.gentoo.org (Postfix) with ESMTP id 050AF11047D; Sun, 08 Jun 2025 13:36:20 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by bobolink.gentoo.org (Postfix) with ESMTPS id F260611047D for ; Sun, 08 Jun 2025 13:36:19 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id AFE30341540 for ; Sun, 08 Jun 2025 13:36:19 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 4DE26297B for ; Sun, 08 Jun 2025 13:36:18 +0000 (UTC) From: "Sam James" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Sam James" Message-ID: <1749389772.e51781a883977c164bc344e071e1f99d1a1af17f.sam@gentoo> Subject: [gentoo-commits] proj/portage:master commit in: bin/ X-VCS-Repository: proj/portage X-VCS-Files: bin/helper-functions.sh X-VCS-Directories: bin/ X-VCS-Committer: sam X-VCS-Committer-Name: Sam James X-VCS-Revision: e51781a883977c164bc344e071e1f99d1a1af17f X-VCS-Branch: master Date: Sun, 08 Jun 2025 13:36:18 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: f0664db0-2b3f-4720-873f-d93deef0aba7 X-Archives-Hash: 4208f3ca315c24c01163d5af70096002 commit: e51781a883977c164bc344e071e1f99d1a1af17f Author: Kerin Millar plushkava net> AuthorDate: Sun Jun 8 13:32:43 2025 +0000 Commit: Sam James gentoo org> CommitDate: Sun Jun 8 13:36:12 2025 +0000 URL: https://gitweb.gentoo.org/proj/portage.git/commit/?id=e51781a8 helper-functions.sh: ensure __multijob_finish() returns numerically In the course of making a minor change to the __multijob_finish() function - intended to idiomatically employ the (( … )) command - the initial assignment of 0 to the 'ret' variable was inadvertently removed. Since it may not otherwise be assigned, the following error may arise. helper-functions.sh: line 64: return: : numeric argument Restore the assignment. Fixes: 0581fbc0421e88d3ef01b55ab864803070be3d96 Signed-off-by: Kerin Millar plushkava.net> Signed-off-by: Sam James gentoo.org> bin/helper-functions.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/helper-functions.sh b/bin/helper-functions.sh index 1ba3630a56..cc18d9053d 100644 --- a/bin/helper-functions.sh +++ b/bin/helper-functions.sh @@ -53,7 +53,7 @@ __multijob_finish_one() { } __multijob_finish() { - local ret + local ret=0 while (( mj_num_jobs > 0 )); do __multijob_finish_one