From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 7AEA615807A for ; Sat, 07 Jun 2025 22:55:02 +0000 (UTC) Received: from lists.gentoo.org (bobolink.gentoo.org [140.211.166.189]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: relay-lists.gentoo.org@gentoo.org) by smtp.gentoo.org (Postfix) with ESMTPSA id 1BF2D335DE9 for ; Sat, 07 Jun 2025 22:55:02 +0000 (UTC) Received: from bobolink.gentoo.org (localhost [127.0.0.1]) by bobolink.gentoo.org (Postfix) with ESMTP id 8CC9B11049F; Sat, 07 Jun 2025 22:54:48 +0000 (UTC) Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by bobolink.gentoo.org (Postfix) with ESMTPS id 806F311049F for ; Sat, 07 Jun 2025 22:54:48 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 38D143430CF for ; Sat, 07 Jun 2025 22:54:48 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id AF4DA2931 for ; Sat, 07 Jun 2025 22:54:45 +0000 (UTC) From: "Sam James" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Sam James" Message-ID: <1749336850.0d2696173a25dde2e3f61a8ea72aeb92f8a29615.sam@gentoo> Subject: [gentoo-commits] proj/portage:master commit in: bin/ X-VCS-Repository: proj/portage X-VCS-Files: bin/ecompress X-VCS-Directories: bin/ X-VCS-Committer: sam X-VCS-Committer-Name: Sam James X-VCS-Revision: 0d2696173a25dde2e3f61a8ea72aeb92f8a29615 X-VCS-Branch: master Date: Sat, 07 Jun 2025 22:54:45 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 159a8ed4-9d57-446e-8d74-d0b156046352 X-Archives-Hash: c70fd69511fd2d208325cf0dde7d8fe2 commit: 0d2696173a25dde2e3f61a8ea72aeb92f8a29615 Author: Kerin Millar plushkava net> AuthorDate: Thu Jun 5 19:00:27 2025 +0000 Commit: Sam James gentoo org> CommitDate: Sat Jun 7 22:54:10 2025 +0000 URL: https://gitweb.gentoo.org/proj/portage.git/commit/?id=0d269617 ecompress: refrain from using the integer attribute The only discernible purpose of the integer attribute is to entice inexperienced bash programmers into improving their bug yield. Signed-off-by: Kerin Millar plushkava.net> Signed-off-by: Sam James gentoo.org> bin/ecompress | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/bin/ecompress b/bin/ecompress index ec74bdfc25..a1f7ea9216 100755 --- a/bin/ecompress +++ b/bin/ecompress @@ -123,8 +123,7 @@ guess_suffix() { } fix_symlinks() { - local something_changed brokenlink newdest olddest ret - local -i indirection=0 + local something_changed brokenlink newdest olddest ret i # Repeat until nothing changes, in order to handle multiple # levels of indirection (see bug #470916). @@ -149,7 +148,7 @@ fix_symlinks() { if (( ! something_changed )); then break - elif (( ++indirection >= 100 )); then + elif (( ++i >= 100 )); then # Protect against possibility of a bug triggering an endless loop. eerror "ecompress: too many levels of indirection for" \ "'${something_changed#${ED%/}}'"