From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id F079E1580EB for ; Fri, 30 May 2025 07:37:47 +0000 (UTC) Received: from lists.gentoo.org (bobolink.gentoo.org [140.211.166.189]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: relay-lists.gentoo.org@gentoo.org) by smtp.gentoo.org (Postfix) with ESMTPSA id DD2B4343111 for ; Fri, 30 May 2025 07:37:47 +0000 (UTC) Received: from bobolink.gentoo.org (localhost [127.0.0.1]) by bobolink.gentoo.org (Postfix) with ESMTP id E1F2911049F; Fri, 30 May 2025 07:37:39 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by bobolink.gentoo.org (Postfix) with ESMTPS id D87A411049F for ; Fri, 30 May 2025 07:37:39 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 91B33343075 for ; Fri, 30 May 2025 07:37:39 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 0D78F28EE for ; Fri, 30 May 2025 07:37:38 +0000 (UTC) From: "Sam James" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Sam James" Message-ID: <1748590650.6dff026cea1c75726d249c02306905c42d30e5bf.sam@gentoo> Subject: [gentoo-commits] proj/portage:master commit in: bin/install-qa-check.d/ X-VCS-Repository: proj/portage X-VCS-Files: bin/install-qa-check.d/90gcc-warnings X-VCS-Directories: bin/install-qa-check.d/ X-VCS-Committer: sam X-VCS-Committer-Name: Sam James X-VCS-Revision: 6dff026cea1c75726d249c02306905c42d30e5bf X-VCS-Branch: master Date: Fri, 30 May 2025 07:37:38 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 0f0d9138-8f2e-49eb-9837-8717f21260e8 X-Archives-Hash: abd5c5d4cf8dd75e5f1bff8a4be9f238 commit: 6dff026cea1c75726d249c02306905c42d30e5bf Author: Kerin Millar plushkava net> AuthorDate: Thu May 22 18:34:53 2025 +0000 Commit: Sam James gentoo org> CommitDate: Fri May 30 07:37:30 2025 +0000 URL: https://gitweb.gentoo.org/proj/portage.git/commit/?id=6dff026c 90gcc-warnings: test the abort variable arithmetically That way, it acts as a quasi-boolean. Signed-off-by: Kerin Millar plushkava.net> Signed-off-by: Sam James gentoo.org> bin/install-qa-check.d/90gcc-warnings | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/bin/install-qa-check.d/90gcc-warnings b/bin/install-qa-check.d/90gcc-warnings index 4da17b154b..ead1243bb5 100644 --- a/bin/install-qa-check.d/90gcc-warnings +++ b/bin/install-qa-check.d/90gcc-warnings @@ -151,7 +151,6 @@ gcc_warn_check() { printf -v joined_msgs '%s|' "${msgs[@]}" joined_msgs=${joined_msgs%|} - abort="no" grep_cmd=grep [[ ${PORTAGE_LOG_FILE} = *.gz ]] && grep_cmd=zgrep @@ -160,7 +159,7 @@ gcc_warn_check() { # binary when we run in the C locale. f=$(LC_ALL='C' sed -E -e $'s/\033\[[0-9;]*[A-Za-z]//g' < "${PORTAGE_LOG_FILE}" | LC_CTYPE=C LC_COLLATE=C "${grep_cmd}" -E -a "${joined_msgs}" | uniq) if [[ -n ${f} ]] ; then - abort="yes" + abort=1 __vecho -ne '\n' eqawarn "QA Notice: Package triggers severe warnings which indicate that it" @@ -171,7 +170,7 @@ gcc_warn_check() { eval "${reset_xtrace}" - if [[ ${abort} == "yes" ]] ; then + if (( abort )) ; then echo "Please do not file a Gentoo bug and instead" \ "report the above QA issues directly to the upstream" \ "developers of this software." | fmt -w 70 | \