From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 0863B1584AD for ; Wed, 23 Apr 2025 18:12:09 +0000 (UTC) Received: from lists.gentoo.org (bobolink.gentoo.org [140.211.166.189]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: relay-lists.gentoo.org@gentoo.org) by smtp.gentoo.org (Postfix) with ESMTPSA id E155D3430C7 for ; Wed, 23 Apr 2025 18:12:08 +0000 (UTC) Received: from bobolink.gentoo.org (localhost [127.0.0.1]) by bobolink.gentoo.org (Postfix) with ESMTP id 6FC171104A9; Wed, 23 Apr 2025 18:12:04 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by bobolink.gentoo.org (Postfix) with ESMTPS id 62FD81104A9 for ; Wed, 23 Apr 2025 18:12:04 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 024853430AC for ; Wed, 23 Apr 2025 18:12:04 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 5EFB3254A for ; Wed, 23 Apr 2025 18:12:02 +0000 (UTC) From: "Eli Schwartz" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Eli Schwartz" Message-ID: <1745431868.82d1929a4c37d7ba10c121ce9d19759d6a436834.eschwartz@gentoo> Subject: [gentoo-commits] repo/gentoo:master commit in: net-misc/rsync/ X-VCS-Repository: repo/gentoo X-VCS-Files: net-misc/rsync/rsync-3.3.0-r2.ebuild net-misc/rsync/rsync-3.4.1.ebuild net-misc/rsync/rsync-9999.ebuild X-VCS-Directories: net-misc/rsync/ X-VCS-Committer: eschwartz X-VCS-Committer-Name: Eli Schwartz X-VCS-Revision: 82d1929a4c37d7ba10c121ce9d19759d6a436834 X-VCS-Branch: master Date: Wed, 23 Apr 2025 18:12:02 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 9141be86-f703-4dc2-925f-fe42f522fbf5 X-Archives-Hash: 8b0fe697c250eac7d3d5a506430c6415 commit: 82d1929a4c37d7ba10c121ce9d19759d6a436834 Author: Eli Schwartz gentoo org> AuthorDate: Thu Jan 16 05:47:05 2025 +0000 Commit: Eli Schwartz gentoo org> CommitDate: Wed Apr 23 18:11:08 2025 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=82d1929a net-misc/rsync: drop useless dependency on sys-apps/attr When USE=xattr is enabled, the configure script checks for -lattr and attempts to link to it for good luck. It also checks for attr/xattr.h, but only includes it in an if/elif when sys/xattr.h doesn't exist -- this makes sense, since the former simply #includes the latter and then emits a #warning telling you to migrate to libc. Presumably, this is meant as a sort of infinite compatibility thing and "it's fine if you use --as-needed" in practice. rsync doesn't actually include any of libattr's non-deprecated headers, just xattr.h and at runtime libattr.so is not needed despite automagically detecting it during configure. Upstream fix for false detection: https://github.com/RsyncProject/rsync/pull/753 Fixes: ``` * VDB: detected possibly incorrect RDEPEND (net-misc/rsync-3.3.0-r2) * sys-apps/attr < ``` No revbump, this package won't be depcleaned anyway so forcing a rebuild feels pointless. Signed-off-by: Eli Schwartz gentoo.org> net-misc/rsync/rsync-3.3.0-r2.ebuild | 3 ++- net-misc/rsync/rsync-3.4.1.ebuild | 3 ++- net-misc/rsync/rsync-9999.ebuild | 3 ++- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/net-misc/rsync/rsync-3.3.0-r2.ebuild b/net-misc/rsync/rsync-3.3.0-r2.ebuild index 7fbdb2af33fe..15d984eea4a6 100644 --- a/net-misc/rsync/rsync-3.3.0-r2.ebuild +++ b/net-misc/rsync/rsync-3.3.0-r2.ebuild @@ -41,6 +41,8 @@ IUSE="acl examples iconv lz4 rrsync ssl stunnel system-zlib xattr xxhash zstd" REQUIRED_USE+=" examples? ( ${PYTHON_REQUIRED_USE} )" REQUIRED_USE+=" rrsync? ( ${PYTHON_REQUIRED_USE} )" +# attr is autodetected and then dropped by -Wl,--as-needed: +# https://github.com/RsyncProject/rsync/pull/753 RDEPEND=" >=dev-libs/popt-1.5 acl? ( virtual/acl ) @@ -57,7 +59,6 @@ RDEPEND=" ) ssl? ( dev-libs/openssl:= ) system-zlib? ( sys-libs/zlib ) - xattr? ( kernel_linux? ( sys-apps/attr ) ) xxhash? ( >=dev-libs/xxhash-0.8 ) zstd? ( >=app-arch/zstd-1.4:= ) iconv? ( virtual/libiconv )" diff --git a/net-misc/rsync/rsync-3.4.1.ebuild b/net-misc/rsync/rsync-3.4.1.ebuild index 759c2d0bd78d..0267e4ccbf0c 100644 --- a/net-misc/rsync/rsync-3.4.1.ebuild +++ b/net-misc/rsync/rsync-3.4.1.ebuild @@ -41,6 +41,8 @@ IUSE="acl examples iconv lz4 rrsync ssl stunnel system-zlib xattr xxhash zstd" REQUIRED_USE+=" examples? ( ${PYTHON_REQUIRED_USE} )" REQUIRED_USE+=" rrsync? ( ${PYTHON_REQUIRED_USE} )" +# attr is autodetected and then dropped by -Wl,--as-needed: +# https://github.com/RsyncProject/rsync/pull/753 RDEPEND=" >=dev-libs/popt-1.19 acl? ( virtual/acl ) @@ -57,7 +59,6 @@ RDEPEND=" ) ssl? ( dev-libs/openssl:= ) system-zlib? ( sys-libs/zlib ) - xattr? ( kernel_linux? ( sys-apps/attr ) ) xxhash? ( >=dev-libs/xxhash-0.8 ) zstd? ( >=app-arch/zstd-1.4:= ) iconv? ( virtual/libiconv )" diff --git a/net-misc/rsync/rsync-9999.ebuild b/net-misc/rsync/rsync-9999.ebuild index 759c2d0bd78d..0267e4ccbf0c 100644 --- a/net-misc/rsync/rsync-9999.ebuild +++ b/net-misc/rsync/rsync-9999.ebuild @@ -41,6 +41,8 @@ IUSE="acl examples iconv lz4 rrsync ssl stunnel system-zlib xattr xxhash zstd" REQUIRED_USE+=" examples? ( ${PYTHON_REQUIRED_USE} )" REQUIRED_USE+=" rrsync? ( ${PYTHON_REQUIRED_USE} )" +# attr is autodetected and then dropped by -Wl,--as-needed: +# https://github.com/RsyncProject/rsync/pull/753 RDEPEND=" >=dev-libs/popt-1.19 acl? ( virtual/acl ) @@ -57,7 +59,6 @@ RDEPEND=" ) ssl? ( dev-libs/openssl:= ) system-zlib? ( sys-libs/zlib ) - xattr? ( kernel_linux? ( sys-apps/attr ) ) xxhash? ( >=dev-libs/xxhash-0.8 ) zstd? ( >=app-arch/zstd-1.4:= ) iconv? ( virtual/libiconv )"