public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Sam James" <sam@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: app-emulation/xen-tools/, app-emulation/xen-tools/files/
Date: Thu, 10 Apr 2025 09:56:44 +0000 (UTC)	[thread overview]
Message-ID: <1744278849.085af7dfb91c441435b7d5f2b0b387b6369baf68.sam@gentoo> (raw)

commit:     085af7dfb91c441435b7d5f2b0b387b6369baf68
Author:     Z. Liu <zhixu.liu <AT> gmail <DOT> com>
AuthorDate: Sat Apr  5 04:34:56 2025 +0000
Commit:     Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Thu Apr 10 09:54:09 2025 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=085af7df

app-emulation/xen-tools: force gcc for seabios & ipxe

* seabios: see commit log of sys-firmware/seabios
* ipxe: upstream support gcc only (at least for now), there are many
        issues on 'variable length array in structure' which is an
        extension will never be supported by clang

CC is passed by "make CC=...", so "override" is added in Makefile to
force ignore the assignment from command line.

Signed-off-by: Z. Liu <zhixu.liu <AT> gmail.com>
Closes: https://github.com/gentoo/gentoo/pull/41485
Signed-off-by: Sam James <sam <AT> gentoo.org>

 app-emulation/xen-tools/files/ipxe-force-gcc.patch | 14 ++++++++++++++
 app-emulation/xen-tools/xen-tools-4.19.1.ebuild    | 10 +++++++++-
 2 files changed, 23 insertions(+), 1 deletion(-)

diff --git a/app-emulation/xen-tools/files/ipxe-force-gcc.patch b/app-emulation/xen-tools/files/ipxe-force-gcc.patch
new file mode 100644
index 000000000000..781de6591356
--- /dev/null
+++ b/app-emulation/xen-tools/files/ipxe-force-gcc.patch
@@ -0,0 +1,14 @@
+diff --git a/src/Makefile b/src/Makefile
+index 548a4e3f..de5ee7ac 100644
+--- a/src/Makefile
++++ b/src/Makefile
+@@ -16,7 +16,8 @@ SYMBOL_PREFIX	:=
+ #
+ # Locations of tools
+ #
+-HOST_CC		:= gcc
++override CC		:= gcc
++HOST_CC		:= ${CC}
+ RM		:= rm -f
+ TOUCH		:= touch
+ MKDIR		:= mkdir

diff --git a/app-emulation/xen-tools/xen-tools-4.19.1.ebuild b/app-emulation/xen-tools/xen-tools-4.19.1.ebuild
index 849888b3e33e..8277a930a505 100644
--- a/app-emulation/xen-tools/xen-tools-4.19.1.ebuild
+++ b/app-emulation/xen-tools/xen-tools-4.19.1.ebuild
@@ -163,7 +163,9 @@ DEPEND="${COMMON_DEPEND}
 
 BDEPEND="dev-lang/perl
 	app-alternatives/yacc
-	sys-devel/gettext"
+	sys-devel/gettext
+	ipxe? ( sys-devel/gcc:* )
+	!system-seabios? ( sys-devel/gcc:* )"
 
 # hvmloader is used to bootstrap a fully virtualized kernel
 # Approved by QA team in bug #144032
@@ -280,7 +282,9 @@ src_prepare() {
 
 		# gcc 11
 		cp "${XEN_GENTOO_PATCHES_DIR}/ipxe/${PN}-4.15.0-ipxe-gcc11.patch" tools/firmware/etherboot/patches/ipxe-gcc11.patch || die
+		cp "${FILESDIR}/ipxe-force-gcc.patch" tools/firmware/etherboot/patches/ || die
 		echo ipxe-gcc11.patch >> tools/firmware/etherboot/patches/series || die
+		echo ipxe-force-gcc.patch >> tools/firmware/etherboot/patches/series || die
 	fi
 
 	# Fix texi2html build error with new texi2html, qemu.doc.html
@@ -405,6 +409,10 @@ src_prepare() {
 			tools/firmware/ovmf-dir-remote/BaseTools/Source/C/VfrCompile/Pccts/*/makefile || die
 	fi
 
+	if ! use system-seabios ; then
+		sed -i "/^export HOSTCC/i override CC:=gcc" tools/firmware/seabios-dir/Makefile
+	fi
+
 	default
 }
 


             reply	other threads:[~2025-04-10  9:56 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-10  9:56 Sam James [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-02-08  0:55 [gentoo-commits] repo/gentoo:master commit in: app-emulation/xen-tools/, app-emulation/xen-tools/files/ Sam James
2023-05-16  9:29 Florian Schmaus
2022-07-13 18:49 Florian Schmaus
2022-02-20  0:31 Sam James
2021-12-21  1:37 Sam James
2021-10-20  9:59 Sam James
2021-09-18  9:50 Joonas Niilola
2021-05-11 15:47 Thomas Deutschmann
2021-02-01 19:24 Thomas Deutschmann
2020-11-11 22:37 Thomas Deutschmann
2020-11-10 15:29 Thomas Deutschmann
2020-07-26 16:22 Thomas Deutschmann
2020-07-09 13:47 Yixun Lan
2020-06-17 15:25 Thomas Deutschmann
2020-05-25 14:21 Yixun Lan
2020-05-25 14:21 Yixun Lan
2020-03-02 10:40 Yixun Lan
2020-03-01 23:59 Yixun Lan
2019-12-10  9:43 Yixun Lan
2019-12-10  9:43 Yixun Lan
2019-11-29 14:51 Yixun Lan
2019-11-13 14:11 Yixun Lan
2019-04-03  4:55 Yixun Lan
2019-03-07 13:35 Yixun Lan
2019-02-16 13:59 Yixun Lan
2018-10-02 11:03 Thomas Deutschmann
2018-08-14  1:20 Yixun Lan
2017-11-22  1:45 Yixun Lan
2017-10-17  7:24 Yixun Lan
2017-10-13  8:05 Yixun Lan
2017-09-07  7:12 Yixun Lan
2017-04-09  0:10 Yixun Lan
2016-12-26  6:09 Yixun Lan
2016-11-22 12:41 Yixun Lan
2016-11-15 10:12 Yixun Lan
2016-11-11  7:23 Yixun Lan
2016-06-27  7:38 Yixun Lan
2015-11-05  7:54 Yixun Lan
2015-10-09  3:37 Yixun Lan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1744278849.085af7dfb91c441435b7d5f2b0b387b6369baf68.sam@gentoo \
    --to=sam@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox