public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Sam James" <sam@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: media-sound/audacity/files/, media-sound/audacity/
Date: Mon, 24 Mar 2025 07:34:42 +0000 (UTC)	[thread overview]
Message-ID: <1742801652.8dc4c36d3c72ea61db29ba394a555be801893603.sam@gentoo> (raw)

commit:     8dc4c36d3c72ea61db29ba394a555be801893603
Author:     Z. Liu <zhixu.liu <AT> gmail <DOT> com>
AuthorDate: Tue Jan 21 06:13:09 2025 +0000
Commit:     Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Mon Mar 24 07:34:12 2025 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8dc4c36d

media-sound/audacity: fixed build w/ clang

Closes: https://bugs.gentoo.org/915041
Signed-off-by: Z. Liu <zhixu.liu <AT> gmail.com>
Closes: https://github.com/gentoo/gentoo/pull/40244
Signed-off-by: Sam James <sam <AT> gentoo.org>

 media-sound/audacity/audacity-3.4.2-r1.ebuild      |  5 ++++-
 ...o-not-include-template-for-clang-compiler.patch | 24 ++++++++++++++++++++++
 2 files changed, 28 insertions(+), 1 deletion(-)

diff --git a/media-sound/audacity/audacity-3.4.2-r1.ebuild b/media-sound/audacity/audacity-3.4.2-r1.ebuild
index 5e345770b011..2d182f4586b8 100644
--- a/media-sound/audacity/audacity-3.4.2-r1.ebuild
+++ b/media-sound/audacity/audacity-3.4.2-r1.ebuild
@@ -1,4 +1,4 @@
-# Copyright 1999-2024 Gentoo Authors
+# Copyright 1999-2025 Gentoo Authors
 # Distributed under the terms of the GNU General Public License v2
 
 EAPI=8
@@ -138,6 +138,9 @@ PATCHES=(
 
 	# Fix build with USE="-lv2"
 	"${FILESDIR}/audacity-3.4.2-fix-build-with-use-lv2-off.patch"
+
+	# Fix build with clang, undefined reference to `typeinfo for wxNavigationEnabled<wxWindow>'
+	"${FILESDIR}/audacity-3.4.2-do-not-include-template-for-clang-compiler.patch"
 )
 
 src_prepare() {

diff --git a/media-sound/audacity/files/audacity-3.4.2-do-not-include-template-for-clang-compiler.patch b/media-sound/audacity/files/audacity-3.4.2-do-not-include-template-for-clang-compiler.patch
new file mode 100644
index 000000000000..c0dc7ecf3a8d
--- /dev/null
+++ b/media-sound/audacity/files/audacity-3.4.2-do-not-include-template-for-clang-compiler.patch
@@ -0,0 +1,24 @@
+https://github.com/audacity/audacity/issues/4614
+
+When compile w/ clang, link failed with:
+
+  ld.lld: error: undefined symbol: typeinfo for wxNavigationEnabled<wxWindow>
+
+so disable "extern ..." if compiler is clang
+
+see also gentoo bug: https://bugs.gentoo.org/915041
+
+diff --git a/src/ListNavigationPanel.h b/src/ListNavigationPanel.h
+index 1618d78..e04cc23 100644
+--- a/src/ListNavigationPanel.h
++++ b/src/ListNavigationPanel.h
+@@ -13,7 +13,9 @@
+ #include <wx/window.h>
+ #include <wx/containr.h>
+ 
++#if !defined(__clang__)
+ extern template class WXDLLIMPEXP_CORE wxNavigationEnabled<wxWindow>;
++#endif
+ 
+ #include "ListNavigationEnabled.h"
+ 


             reply	other threads:[~2025-03-24  7:34 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-24  7:34 Sam James [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-11-01  6:29 [gentoo-commits] repo/gentoo:master commit in: media-sound/audacity/files/, media-sound/audacity/ Miroslav Šulc
2024-10-25 20:30 Andreas K. Hüttel
2024-04-02 10:28 Sam James
2024-03-23  8:29 Sam James
2024-01-16  3:36 Sam James
2023-06-30 12:31 David Seifert
2023-04-15  0:47 Sam James
2023-01-20 22:18 Arsen Arsenović
2020-09-02  8:33 Miroslav Šulc
2020-08-06  4:57 Miroslav Šulc
2018-02-21 11:08 Lars Wendler
2018-02-21 11:08 Lars Wendler
2018-02-18 11:13 Lars Wendler
2017-06-05  9:45 Pacho Ramos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1742801652.8dc4c36d3c72ea61db29ba394a555be801893603.sam@gentoo \
    --to=sam@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox