From: "Sam James" <sam@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: app-office/libreoffice/, app-office/libreoffice/files/
Date: Sat, 22 Feb 2025 23:24:16 +0000 (UTC) [thread overview]
Message-ID: <1740266597.60e32e133500d456ec9752a4926633350ae77641.sam@gentoo> (raw)
commit: 60e32e133500d456ec9752a4926633350ae77641
Author: Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Sat Feb 22 23:21:20 2025 +0000
Commit: Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Sat Feb 22 23:23:17 2025 +0000
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=60e32e13
app-office/libreoffice: respect CFLAGS more
I noticed that chunks of the build were using -O2 -mtune=generic, so
fix that. There's some precedence for other distros overriding this anyway
per commit messages.
Signed-off-by: Sam James <sam <AT> gentoo.org>
.../files/libreoffice-25.2-cflags.patch | 211 +++++++++++++++++++++
app-office/libreoffice/libreoffice-25.2.1.1.ebuild | 1 +
app-office/libreoffice/libreoffice-9999.ebuild | 1 +
3 files changed, 213 insertions(+)
diff --git a/app-office/libreoffice/files/libreoffice-25.2-cflags.patch b/app-office/libreoffice/files/libreoffice-25.2-cflags.patch
new file mode 100644
index 000000000000..1f81775e2f2f
--- /dev/null
+++ b/app-office/libreoffice/files/libreoffice-25.2-cflags.patch
@@ -0,0 +1,211 @@
+Some parts of the build will use e.g. -O2 -mtune=generic otherwise.
+--- a/solenv/gbuild/platform/ANDROID_AARCH64_GCC.mk
++++ b/solenv/gbuild/platform/ANDROID_AARCH64_GCC.mk
+@@ -9,7 +9,7 @@
+
+ # please make generic modifications to unxgcc.mk or android.mk
+ gb_CPUDEFS += -DARM32
+-gb_COMPILEROPTFLAGS := -Os
++gb_COMPILEROPTFLAGS :=
+
+ include $(GBUILDDIR)/platform/unxgcc.mk
+ include $(GBUILDDIR)/platform/android.mk
+--- a/solenv/gbuild/platform/ANDROID_ARM_GCC.mk
++++ b/solenv/gbuild/platform/ANDROID_ARM_GCC.mk
+@@ -9,7 +9,7 @@
+
+ # please make generic modifications to unxgcc.mk or android.mk
+ gb_CPUDEFS += -DARM32
+-gb_COMPILEROPTFLAGS := -Os
++gb_COMPILEROPTFLAGS :=
+
+ include $(GBUILDDIR)/platform/unxgcc.mk
+ include $(GBUILDDIR)/platform/android.mk
+--- a/solenv/gbuild/platform/ANDROID_INTEL_GCC.mk
++++ b/solenv/gbuild/platform/ANDROID_INTEL_GCC.mk
+@@ -9,7 +9,7 @@
+
+ # please make generic modifications to unxgcc.mk or android.mk
+ gb_CPUDEFS += -DX86
+-gb_COMPILEROPTFLAGS := -Os
++gb_COMPILEROPTFLAGS :=
+
+ include $(GBUILDDIR)/platform/unxgcc.mk
+ include $(GBUILDDIR)/platform/android.mk
+--- a/solenv/gbuild/platform/EMSCRIPTEN_INTEL_GCC.mk
++++ b/solenv/gbuild/platform/EMSCRIPTEN_INTEL_GCC.mk
+@@ -73,7 +73,7 @@ ifeq ($(HAVE_EXTERNAL_DWARF),TRUE)
+ gb_DEBUGINFO_FLAGS += -gsplit-dwarf -gpubnames
+ endif
+
+-gb_COMPILEROPTFLAGS := -O3
++gb_COMPILEROPTFLAGS :=
+
+ # We need at least code elimination, otherwise linking OOMs even with 64GB.
+ # So we "fake" -Og support to mean -O1 for Emscripten and always enable it for debug in configure.
+--- a/solenv/gbuild/platform/LINUX_ARM_GCC.mk
++++ b/solenv/gbuild/platform/LINUX_ARM_GCC.mk
+@@ -9,7 +9,7 @@
+
+ #please make generic modifications to unxgcc.mk or linux.mk
+ gb_CPUDEFS += -DARM32
+-gb_COMPILEROPTFLAGS := -Os
++gb_COMPILEROPTFLAGS :=
+
+ include $(GBUILDDIR)/platform/linux.mk
+
+--- a/solenv/gbuild/platform/LINUX_AXP_GCC.mk
++++ b/solenv/gbuild/platform/LINUX_AXP_GCC.mk
+@@ -8,7 +8,7 @@
+ #
+
+ #please make generic modifications to unxgcc.mk or linux.mk
+-gb_COMPILEROPTFLAGS := -Os
++gb_COMPILEROPTFLAGS :=
+ gb_LinkTarget_LDFLAGS += -Wl,--no-relax
+
+ include $(GBUILDDIR)/platform/linux.mk
+--- a/solenv/gbuild/platform/LINUX_INTEL_GCC.mk
++++ b/solenv/gbuild/platform/LINUX_INTEL_GCC.mk
+@@ -9,7 +9,7 @@
+
+ #please make generic modifications to unxgcc.mk or linux.mk
+ gb_CPUDEFS := -DX86
+-gb_COMPILEROPTFLAGS := -Os
++gb_COMPILEROPTFLAGS :=
+
+ include $(GBUILDDIR)/platform/linux.mk
+
+--- a/solenv/gbuild/platform/LINUX_M68K_GCC.mk
++++ b/solenv/gbuild/platform/LINUX_M68K_GCC.mk
+@@ -8,7 +8,7 @@
+ #
+
+ #please make generic modifications to unxgcc.mk or linux.mk
+-gb_COMPILEROPTFLAGS := -Os
++gb_COMPILEROPTFLAGS :=
+
+ include $(GBUILDDIR)/platform/linux.mk
+
+--- a/solenv/gbuild/platform/LINUX_MIPS64_GCC.mk
++++ b/solenv/gbuild/platform/LINUX_MIPS64_GCC.mk
+@@ -9,7 +9,7 @@
+
+ #please make generic modifications to unxgcc.mk or linux.mk
+ gb_CPUDEFS += -DMIPS64
+-gb_COMPILEROPTFLAGS := -Os
++gb_COMPILEROPTFLAGS :=
+
+ include $(GBUILDDIR)/platform/linux.mk
+
+--- a/solenv/gbuild/platform/LINUX_MIPS_GCC.mk
++++ b/solenv/gbuild/platform/LINUX_MIPS_GCC.mk
+@@ -9,7 +9,7 @@
+
+ #please make generic modifications to unxgcc.mk or linux.mk
+ gb_CPUDEFS += -DMIPS
+-gb_COMPILEROPTFLAGS := -Os
++gb_COMPILEROPTFLAGS :=
+
+ include $(GBUILDDIR)/platform/linux.mk
+
+--- a/solenv/gbuild/platform/LINUX_POWERPC64_GCC.mk
++++ b/solenv/gbuild/platform/LINUX_POWERPC64_GCC.mk
+@@ -10,8 +10,7 @@
+ #please make generic modifications to unxgcc.mk or linux.mk
+ gb_CPUDEFS += -DPPC
+
+-gb_COMPILEROPTFLAGS := -O2 \
+- $(if $(filter powerpc64le-unknown-linux-gnu,$(HOST_PLATFORM)),-mtune=powerpc64le)
++gb_COMPILEROPTFLAGS :=
+
+ include $(GBUILDDIR)/platform/linux.mk
+
+--- a/solenv/gbuild/platform/LINUX_RISCV64_GCC.mk
++++ b/solenv/gbuild/platform/LINUX_RISCV64_GCC.mk
+@@ -8,7 +8,7 @@
+ #
+
+ #please make generic modifications to unxgcc.mk or linux.mk
+-gb_COMPILEROPTFLAGS := -Os
++gb_COMPILEROPTFLAGS :=
+
+ include $(GBUILDDIR)/platform/linux.mk
+
+--- a/solenv/gbuild/platform/LINUX_SPARC64_GCC.mk
++++ b/solenv/gbuild/platform/LINUX_SPARC64_GCC.mk
+@@ -8,7 +8,7 @@
+ #
+
+ #please make generic modifications to unxgcc.mk or linux.mk
+-gb_COMPILEROPTFLAGS := -Os
++gb_COMPILEROPTFLAGS :=
+
+ include $(GBUILDDIR)/platform/linux.mk
+
+--- a/solenv/gbuild/platform/LINUX_SPARC_GCC.mk
++++ b/solenv/gbuild/platform/LINUX_SPARC_GCC.mk
+@@ -8,7 +8,7 @@
+ #
+
+ #please make generic modifications to unxgcc.mk or linux.mk
+-gb_COMPILEROPTFLAGS := -Os
++gb_COMPILEROPTFLAGS :=
+
+ include $(GBUILDDIR)/platform/linux.mk
+
+--- a/solenv/gbuild/platform/LINUX_X86_64_GCC.mk
++++ b/solenv/gbuild/platform/LINUX_X86_64_GCC.mk
+@@ -9,7 +9,7 @@
+
+ #please make generic modifications to unxgcc.mk or linux.mk
+
+-gb_COMPILEROPTFLAGS := -O2 -mtune=generic
++gb_COMPILEROPTFLAGS :=
+
+ include $(GBUILDDIR)/platform/linux.mk
+
+--- a/solenv/gbuild/platform/NETBSD_INTEL_GCC.mk
++++ b/solenv/gbuild/platform/NETBSD_INTEL_GCC.mk
+@@ -10,7 +10,7 @@
+ #please make generic modifications to unxgcc.mk
+
+ gb_CPUDEFS := -DX86
+-gb_COMPILEROPTFLAGS := -O -g
++gb_COMPILEROPTFLAGS :=
+
+ include $(GBUILDDIR)/platform/unxgcc.mk
+
+--- a/solenv/gbuild/platform/NETBSD_X86_64_GCC.mk
++++ b/solenv/gbuild/platform/NETBSD_X86_64_GCC.mk
+@@ -9,7 +9,7 @@
+
+ #please make generic modifications to unxgcc.mk
+
+-gb_COMPILEROPTFLAGS := -O -g
++gb_COMPILEROPTFLAGS :=
+
+ include $(GBUILDDIR)/platform/unxgcc.mk
+
+--- a/solenv/gbuild/platform/com_GCC_defs.mk
++++ b/solenv/gbuild/platform/com_GCC_defs.mk
+@@ -38,7 +38,7 @@ endif
+ gb_COMPILER_SETUP :=
+
+ ifeq ($(strip $(gb_COMPILEROPTFLAGS)),)
+-gb_COMPILEROPTFLAGS := -O2
++gb_COMPILEROPTFLAGS :=
+ endif
+
+ gb_COMPILEROPTFLAGS += $(if $(ENABLE_HARDENING_FLAGS),$(HARDENING_OPT_CFLAGS))
+--- a/solenv/gbuild/platform/iOS.mk
++++ b/solenv/gbuild/platform/iOS.mk
+@@ -24,7 +24,7 @@ ifeq ($(CXX),)
+ $(error You must set CXX in the environment. See README.cross for example.)
+ endif
+
+-gb_COMPILEROPTFLAGS := -O2
++gb_COMPILEROPTFLAGS :=
+
+ include $(GBUILDDIR)/platform/com_GCC_defs.mk
+
diff --git a/app-office/libreoffice/libreoffice-25.2.1.1.ebuild b/app-office/libreoffice/libreoffice-25.2.1.1.ebuild
index 93fdf81500f1..51e15b633a78 100644
--- a/app-office/libreoffice/libreoffice-25.2.1.1.ebuild
+++ b/app-office/libreoffice/libreoffice-25.2.1.1.ebuild
@@ -294,6 +294,7 @@ PATCHES=(
# not upstreamable stuff
"${FILESDIR}/${PN}-6.1-nomancompress.patch"
"${FILESDIR}/${PN}-24.2-qtdetect.patch"
+ "${FILESDIR}/${PN}-25.2-cflags.patch"
# TODO: upstream
"${FILESDIR}/${PN}-25.2-unused-qt6network.patch"
diff --git a/app-office/libreoffice/libreoffice-9999.ebuild b/app-office/libreoffice/libreoffice-9999.ebuild
index 881254aa0372..f99706c20250 100644
--- a/app-office/libreoffice/libreoffice-9999.ebuild
+++ b/app-office/libreoffice/libreoffice-9999.ebuild
@@ -294,6 +294,7 @@ PATCHES=(
# not upstreamable stuff
"${FILESDIR}/${PN}-6.1-nomancompress.patch"
"${FILESDIR}/${PN}-24.2-qtdetect.patch"
+ "${FILESDIR}/${PN}-25.2-cflags.patch"
# TODO: upstream
"${FILESDIR}/${PN}-25.2-unused-qt6network.patch"
next reply other threads:[~2025-02-22 23:24 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-22 23:24 Sam James [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-03-04 22:04 [gentoo-commits] repo/gentoo:master commit in: app-office/libreoffice/, app-office/libreoffice/files/ Sam James
2024-12-17 21:44 Andreas Sturmlechner
2024-10-05 13:54 Andreas Sturmlechner
2024-09-21 8:29 Andreas Sturmlechner
2024-05-21 15:14 Andreas Sturmlechner
2024-03-28 18:48 Andreas Sturmlechner
2024-03-12 11:50 Andreas Sturmlechner
2024-03-10 16:30 Andreas Sturmlechner
2024-03-04 4:22 Sam James
2024-01-28 16:28 Andreas Sturmlechner
2023-11-21 22:36 Andreas Sturmlechner
2023-11-20 13:35 Sam James
2023-11-03 23:58 Sam James
2023-02-01 18:22 Andreas Sturmlechner
2023-01-30 4:01 Sam James
2023-01-13 19:08 Sam James
2023-01-10 0:04 Andreas Sturmlechner
2022-12-17 19:53 David Seifert
2022-11-03 8:40 Andreas Sturmlechner
2022-08-31 21:47 Sam James
2022-06-14 15:20 Andreas Sturmlechner
2022-05-09 19:12 Sam James
2022-05-08 13:35 Andreas Sturmlechner
2022-03-12 15:53 Andreas Sturmlechner
2022-02-05 20:46 Andreas Sturmlechner
2021-12-03 11:11 Andreas Sturmlechner
2021-11-05 5:39 Sam James
2021-09-07 18:28 Andreas Sturmlechner
2021-06-10 15:34 Andreas Sturmlechner
2021-01-24 13:02 Andreas Sturmlechner
2020-12-12 21:59 Andreas Sturmlechner
2020-11-21 22:18 Andreas Sturmlechner
2020-11-21 21:00 Andreas K. Hüttel
2020-11-06 2:22 Andreas Sturmlechner
2020-11-05 22:51 Andreas Sturmlechner
2020-10-29 10:40 Andreas Sturmlechner
2020-10-22 22:04 Andreas Sturmlechner
2020-09-08 18:08 Andreas Sturmlechner
2020-05-31 21:09 Andreas Sturmlechner
2020-04-05 17:05 Andreas Sturmlechner
2020-01-17 2:50 Andreas Sturmlechner
2019-11-01 18:39 Andreas Sturmlechner
2019-10-18 23:59 Andreas Sturmlechner
2019-08-13 15:56 Andreas Sturmlechner
2019-04-21 11:31 Andreas Sturmlechner
2019-04-21 11:31 Andreas Sturmlechner
2019-04-11 9:03 Andreas Sturmlechner
2019-03-30 9:59 Andreas Sturmlechner
2019-02-01 20:14 Andreas Sturmlechner
2019-01-30 22:31 Andreas Sturmlechner
2019-01-23 22:53 Andreas Sturmlechner
2019-01-08 0:17 Andreas Sturmlechner
2018-12-13 11:01 Andreas Sturmlechner
2018-12-13 9:57 Andreas Sturmlechner
2018-10-01 18:13 Andreas Sturmlechner
2018-08-13 21:48 Andreas Sturmlechner
2018-06-10 14:43 Andreas Sturmlechner
2018-05-27 22:59 Andreas Sturmlechner
2018-05-27 19:54 Andreas Sturmlechner
2018-05-27 6:29 Andreas Sturmlechner
2018-04-25 16:15 Andreas Sturmlechner
2017-12-21 13:27 Andreas Sturmlechner
2017-10-08 11:22 Andreas Sturmlechner
2017-02-26 18:37 Andreas Sturmlechner
2016-11-06 18:42 Andreas Hüttel
2016-07-03 20:10 Andreas Hüttel
2016-02-25 16:50 Andreas Hüttel
2016-02-22 17:07 Andreas Hüttel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1740266597.60e32e133500d456ec9752a4926633350ae77641.sam@gentoo \
--to=sam@gentoo.org \
--cc=gentoo-commits@lists.gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox