public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Pacho Ramos" <pacho@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: dev-util/sysprof/
Date: Sun, 26 Jan 2025 15:01:43 +0000 (UTC)	[thread overview]
Message-ID: <1737903639.fa1d9bf233a759bf39f7514f996a5f8cca6948ef.pacho@gentoo> (raw)

commit:     fa1d9bf233a759bf39f7514f996a5f8cca6948ef
Author:     Pacho Ramos <pacho <AT> gentoo <DOT> org>
AuthorDate: Sun Jan 26 13:06:11 2025 +0000
Commit:     Pacho Ramos <pacho <AT> gentoo <DOT> org>
CommitDate: Sun Jan 26 15:00:39 2025 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fa1d9bf2

dev-util/sysprof: Migrate to greadme.eclass

Instead of elogging the messages every time the package is rebuilt.
Also add forgotten gnome2_schemas_savelist call.

Signed-off-by: Pacho Ramos <pacho <AT> gentoo.org>

 dev-util/sysprof/sysprof-47.2.ebuild | 31 ++++++++++++++++++++-----------
 1 file changed, 20 insertions(+), 11 deletions(-)

diff --git a/dev-util/sysprof/sysprof-47.2.ebuild b/dev-util/sysprof/sysprof-47.2.ebuild
index 963523b27b02..5b6fd9b96100 100644
--- a/dev-util/sysprof/sysprof-47.2.ebuild
+++ b/dev-util/sysprof/sysprof-47.2.ebuild
@@ -3,7 +3,7 @@
 
 EAPI=8
 
-inherit gnome.org gnome2-utils meson systemd xdg
+inherit gnome.org gnome2-utils greadme meson systemd xdg
 
 DESCRIPTION="System-wide Linux Profiler"
 HOMEPAGE="http://sysprof.com/"
@@ -79,21 +79,30 @@ src_install() {
 
 	# We want to ship org.gnome.Sysprof3.Profiler.xml in sysprof-common for the benefit of x11-wm/mutter
 	rm "${ED}"/usr/share/dbus-1/interfaces/org.gnome.Sysprof3.Profiler.xml || die
+
+	greadme_stdin <<-EOF
+	On many systems, especially amd64, it is typical that with a modern
+	toolchain -fomit-frame-pointer for gcc is the default, because
+	debugging is still possible thanks to gcc/gdb location list feature.
+	However sysprof is not able to construct call trees if frame pointers
+	are not present. Therefore -fno-omit-frame-pointer CFLAGS is suggested
+	for the libraries and applications involved in the profiling. That
+	means a CPU register is used for the frame pointer instead of other
+	purposes, which means a very minimal performance loss when there is
+	register pressure.
+EOF
+}
+
+pkg_preinst() {
+	xdg_pkg_preinst
+	gnome2_schemas_savelist
+	greadme_pkg_preinst
 }
 
 pkg_postinst() {
 	xdg_pkg_postinst
 	gnome2_schemas_update
-
-	elog "On many systems, especially amd64, it is typical that with a modern"
-	elog "toolchain -fomit-frame-pointer for gcc is the default, because"
-	elog "debugging is still possible thanks to gcc4/gdb location list feature."
-	elog "However sysprof is not able to construct call trees if frame pointers"
-	elog "are not present. Therefore -fno-omit-frame-pointer CFLAGS is suggested"
-	elog "for the libraries and applications involved in the profiling. That"
-	elog "means a CPU register is used for the frame pointer instead of other"
-	elog "purposes, which means a very minimal performance loss when there is"
-	elog "register pressure."
+	greadme_pkg_postinst
 }
 
 pkg_postrm() {


             reply	other threads:[~2025-01-26 15:01 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-26 15:01 Pacho Ramos [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-01-26 15:01 [gentoo-commits] repo/gentoo:master commit in: dev-util/sysprof/ Pacho Ramos
2025-01-24 10:49 WANG Xuerui
2024-12-31  5:59 Eli Schwartz
2024-12-31  5:59 Eli Schwartz
2024-11-10  0:42 Jakov Smolić
2024-11-09 10:40 Pacho Ramos
2023-05-03  6:33 Arthur Zamarin
2023-05-03  6:33 Arthur Zamarin
2023-03-18  2:28 Matt Turner
2022-10-30 15:42 Matt Turner
2022-09-24 20:05 Matt Turner
2022-03-25 18:25 Matt Turner
2021-12-19 16:59 Matt Turner
2021-07-17 23:14 Sam James
2021-06-13 20:25 Sam James
2021-06-07  1:06 Matt Turner
2021-02-17 18:42 Sam James
2021-02-17 14:21 Sam James
2020-12-04  1:32 Matt Turner
2020-12-04  1:32 Matt Turner
2020-07-04 12:00 Mart Raudsepp
2020-03-02 19:23 Mart Raudsepp
2020-03-01 16:18 Mart Raudsepp
2019-12-23 21:26 Mart Raudsepp
2019-07-27  8:36 Mart Raudsepp
2019-05-18 19:59 Mart Raudsepp
2018-12-17 15:08 Mart Raudsepp
2018-08-02 20:58 Mart Raudsepp
2018-02-19 20:03 Mart Raudsepp
2018-02-19 20:03 Mart Raudsepp
2018-02-06 18:36 Thomas Deutschmann
2018-01-26 15:03 Mikle Kolyada
2017-06-05  0:13 Mart Raudsepp
2017-06-05  0:13 Mart Raudsepp
2017-06-05  0:13 Mart Raudsepp
2017-04-18 11:14 Mart Raudsepp
2016-11-12 12:23 Gilles Dartiguelongue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1737903639.fa1d9bf233a759bf39f7514f996a5f8cca6948ef.pacho@gentoo \
    --to=pacho@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox