From: "Conrad Kostecki" <conikost@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: dev-scheme/guile/files/
Date: Sat, 04 Jan 2025 22:47:52 +0000 (UTC) [thread overview]
Message-ID: <1736030827.d8e4a953c816a6f23149b1cc80c797dfb7ceff4f.conikost@gentoo> (raw)
commit: d8e4a953c816a6f23149b1cc80c797dfb7ceff4f
Author: Michael Mair-Keimberger <mmk <AT> levelnine <DOT> at>
AuthorDate: Fri Jan 3 15:33:10 2025 +0000
Commit: Conrad Kostecki <conikost <AT> gentoo <DOT> org>
CommitDate: Sat Jan 4 22:47:07 2025 +0000
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d8e4a953
dev-scheme/guile: remove unused patch
Signed-off-by: Michael Mair-Keimberger <mmk <AT> levelnine.at>
Signed-off-by: Conrad Kostecki <conikost <AT> gentoo.org>
.../guile/files/guile-2.2.7-fix-buggy-gnulib.patch | 85 ----------------------
1 file changed, 85 deletions(-)
diff --git a/dev-scheme/guile/files/guile-2.2.7-fix-buggy-gnulib.patch b/dev-scheme/guile/files/guile-2.2.7-fix-buggy-gnulib.patch
deleted file mode 100644
index 20f04c3b095c..000000000000
--- a/dev-scheme/guile/files/guile-2.2.7-fix-buggy-gnulib.patch
+++ /dev/null
@@ -1,85 +0,0 @@
-From 76d84a62e84d4206d41ffed16b8baa5af2d1e62f Mon Sep 17 00:00:00 2001
-From: Eli Schwartz <eschwartz93@gmail.com>
-Date: Sun, 26 May 2024 13:02:54 -0400
-Subject: [PATCH 1/2] fix invalid bash code causing the wrong type of failure
-
-test $var = no
-
-fails if $var is only ever defined after this line. gnulib is brilliant
-software and naturally does exactly this, because it is highly logical
-to only define code after you try to use it.
-
-Probably. It's hard to tell because the actual code that gets run is:
-
-func_gl_gnulib_m4code_5264294aa0a5557541b53c8c741f7f31
-
-since the other sparkling aspect of gnulib's innovative brilliance is
-the realization that *of course* the most robust way to design software
-is to use checksums as *replacements* for function names.
-
-Or, "that time Eli got jiatanned by gnulib".
-
-The quoting was silently "fixed" upstream in:
-https://github.com/coreutils/gnulib/commit/db1ee11e2168af7137db53289a92e306d2277b0b
-
-It is the same "fix" we do here, thus restoring dash <--> bash
-compatibility and preventing:
-
-```
- * QA Notice: Abnormal configure code
- *
- * ./configure: 38012: test: =: unexpected operator
-```
-
-although it seems to me gnulib is just more generally broken.
----
- m4/timegm.m4 | 2 +-
- 1 file changed, 1 insertion(+), 1 deletion(-)
-
-diff --git a/m4/timegm.m4 b/m4/timegm.m4
-index 510e25a..34e5347 100644
---- a/m4/timegm.m4
-+++ b/m4/timegm.m4
-@@ -11,7 +11,7 @@ AC_DEFUN([gl_FUNC_TIMEGM],
- REPLACE_TIMEGM=0
- AC_CHECK_FUNCS_ONCE([timegm])
- if test $ac_cv_func_timegm = yes; then
-- if test $gl_cv_func_working_mktime = no; then
-+ if test "$gl_cv_func_working_mktime" = no; then
- # Assume that timegm is buggy if mktime is.
- REPLACE_TIMEGM=1
- fi
---
-2.44.1
-
-
-From fa98775e2a0bc6e33de851a8bd399635b977d0e6 Mon Sep 17 00:00:00 2001
-From: Eli Schwartz <eschwartz93@gmail.com>
-Date: Sun, 26 May 2024 13:07:25 -0400
-Subject: [PATCH 2/2] gnulib: backport fix for Modern C in round.m4
-
-https://github.com/coreutils/gnulib/commit/f12a7bbb4acaaa72f48e452e04da2a4dd749a664
-
-Fixes undefined exit() by switching it to merely return. That's the
-upstream fix, so use it although arguably one could simply #include the
-headers for functions that are used...
----
- m4/round.m4 | 2 +-
- 1 file changed, 1 insertion(+), 1 deletion(-)
-
-diff --git a/m4/round.m4 b/m4/round.m4
-index 45b7df4..d4ef7f2 100644
---- a/m4/round.m4
-+++ b/m4/round.m4
-@@ -57,7 +57,7 @@ int main()
- * (double) (1U << ((DBL_MANT_DIG + 3) / 5))
- * (double) (1U << ((DBL_MANT_DIG + 4) / 5));
- volatile double x = 0.5 - 0.5 / TWO_MANT_DIG;
-- exit (x < 0.5 && round (x) != 0.0);
-+ return (x < 0.5 && round (x) != 0.0);
- }]])], [gl_cv_func_round_works=yes], [gl_cv_func_round_works=no],
- [case "$host_os" in
- netbsd* | aix*) gl_cv_func_round_works="guessing no";;
---
-2.44.1
-
next reply other threads:[~2025-01-04 22:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-04 22:47 Conrad Kostecki [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-11-13 3:13 [gentoo-commits] repo/gentoo:master commit in: dev-scheme/guile/files/ Sam James
2023-02-08 17:17 Sam James
2016-12-20 10:41 Amy Winston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1736030827.d8e4a953c816a6f23149b1cc80c797dfb7ceff4f.conikost@gentoo \
--to=conikost@gentoo.org \
--cc=gentoo-commits@lists.gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox