From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gentoo-commits+bounces-1704412-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
	(No client certificate requested)
	by finch.gentoo.org (Postfix) with ESMTPS id 9B21415812D
	for <garchives@archives.gentoo.org>; Tue, 31 Dec 2024 06:00:01 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id B5234E077C;
	Tue, 31 Dec 2024 06:00:00 +0000 (UTC)
Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
	(No client certificate requested)
	by pigeon.gentoo.org (Postfix) with ESMTPS id 7C125E077D
	for <gentoo-commits@lists.gentoo.org>; Tue, 31 Dec 2024 05:59:58 +0000 (UTC)
Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
	(No client certificate requested)
	by smtp.gentoo.org (Postfix) with ESMTPS id 53975335D2B
	for <gentoo-commits@lists.gentoo.org>; Tue, 31 Dec 2024 05:59:57 +0000 (UTC)
Received: from localhost.localdomain (localhost [IPv6:::1])
	by oystercatcher.gentoo.org (Postfix) with ESMTP id 824DCD81
	for <gentoo-commits@lists.gentoo.org>; Tue, 31 Dec 2024 05:59:55 +0000 (UTC)
From: "Eli Schwartz" <eschwartz@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Content-Transfer-Encoding: 8bit
Content-type: text/plain; charset=UTF-8
Reply-To: gentoo-dev@lists.gentoo.org, "Eli Schwartz" <eschwartz@gentoo.org>
Message-ID: <1735624647.73a60ab1ebeea720bdbde5c4f5b3ba1a3ed7cf86.eschwartz@gentoo>
Subject: [gentoo-commits] repo/gentoo:master commit in: dev-util/sysprof/
X-VCS-Repository: repo/gentoo
X-VCS-Files: dev-util/sysprof/sysprof-46.0-r1.ebuild dev-util/sysprof/sysprof-46.0.ebuild
X-VCS-Directories: dev-util/sysprof/
X-VCS-Committer: eschwartz
X-VCS-Committer-Name: Eli Schwartz
X-VCS-Revision: 73a60ab1ebeea720bdbde5c4f5b3ba1a3ed7cf86
X-VCS-Branch: master
Date: Tue, 31 Dec 2024 05:59:55 +0000 (UTC)
Precedence: bulk
List-Post: <mailto:gentoo-commits@lists.gentoo.org>
List-Help: <mailto:gentoo-commits+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-commits+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-commits+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-commits.gentoo.org>
X-BeenThere: gentoo-commits@lists.gentoo.org
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
X-Archives-Salt: 5339bd59-48e3-4f66-8244-474be1ae49dd
X-Archives-Hash: d982237bcb540b7d037e627af9380c78

commit:     73a60ab1ebeea720bdbde5c4f5b3ba1a3ed7cf86
Author:     Eli Schwartz <eschwartz <AT> gentoo <DOT> org>
AuthorDate: Tue Dec 31 00:28:02 2024 +0000
Commit:     Eli Schwartz <eschwartz <AT> gentoo <DOT> org>
CommitDate: Tue Dec 31 05:57:27 2024 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=73a60ab1

dev-util/sysprof: fix nastily propagating automagic dep

sysprof 45.0 and on introduce a systemd feature (journald integration)
which is implemented by depending on libsystemd.so if it is installed at
the time of building.

https://github.com/GNOME/sysprof/commit/88d0589fea80307fe8d49a9c4f93ef99cb6a5e8b

This dependency was never added during the version bump in ::gentoo. It
breaks, among other things, binhost caching. Fix by introducing
USE=systemd support to this package. We use strong blockers to prevent
systemd from even being installed when src_compile'ing with -systemd,
since otherwise it genuinely miscompiles. This is probably fine, since
people using systemd profiles have USE=systemd by default unless they go
out of their way to unset it, and people with non-systemd profiles
shouldn't have this USE set at all.

(Note that it's fine to install a binpackage built without systemd
support, even on a systemd profile.)

Straight to stable, the package nastily breaks on openrc systems and the
changes are purely to dependency metadata.

Fixes: 29d274e3ecdde94273ddd9f247efa9c5e12dab73
Fixes: https://github.com/gentoo/gentoo/pull/34771
Closes: https://bugs.gentoo.org/947256
Signed-off-by: Eli Schwartz <eschwartz <AT> gentoo.org>

 dev-util/sysprof/{sysprof-46.0.ebuild => sysprof-46.0-r1.ebuild} | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/dev-util/sysprof/sysprof-46.0.ebuild b/dev-util/sysprof/sysprof-46.0-r1.ebuild
similarity index 95%
rename from dev-util/sysprof/sysprof-46.0.ebuild
rename to dev-util/sysprof/sysprof-46.0-r1.ebuild
index 709f8ac2dcfc..43b8f904cba8 100644
--- a/dev-util/sysprof/sysprof-46.0.ebuild
+++ b/dev-util/sysprof/sysprof-46.0-r1.ebuild
@@ -12,7 +12,7 @@ LICENSE="GPL-3+ GPL-2+"
 API_VERSION="4"
 SLOT="0/${API_VERSION}"
 KEYWORDS="amd64 ~arm64 x86"
-IUSE="gtk test"
+IUSE="gtk systemd test"
 RESTRICT="!test? ( test )"
 
 RDEPEND="
@@ -23,6 +23,7 @@ RDEPEND="
 		x11-libs/cairo
 		x11-libs/pango
 	)
+	systemd? ( sys-apps/systemd )
 	dev-libs/json-glib
 	>=dev-libs/libdex-0.3.1
 	>=gui-libs/libpanel-1.3.0
@@ -31,7 +32,10 @@ RDEPEND="
 	>=dev-util/sysprof-common-${PV}
 	>=dev-util/sysprof-capture-${PV}:${API_VERSION}
 "
-DEPEND="${RDEPEND}"
+DEPEND="
+	${RDEPEND}
+	!systemd? ( !!sys-apps/systemd )
+"
 BDEPEND="
 	dev-libs/appstream-glib
 	dev-util/gdbus-codegen