From: "Sam James" <sam@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: net-libs/webkit-gtk/, net-libs/webkit-gtk/files/
Date: Fri, 6 Dec 2024 11:18:59 +0000 (UTC) [thread overview]
Message-ID: <1733483903.b08c8e936b93d6a9e7f741d1e8396ad5e33e3639.sam@gentoo> (raw)
commit: b08c8e936b93d6a9e7f741d1e8396ad5e33e3639
Author: Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Fri Dec 6 11:17:39 2024 +0000
Commit: Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Fri Dec 6 11:18:23 2024 +0000
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b08c8e93
net-libs/webkit-gtk: fix 2.46.4 build
Closes: https://bugs.gentoo.org/945827
Signed-off-by: Sam James <sam <AT> gentoo.org>
net-libs/webkit-gtk/files/2.46.4-no-egl.patch | 115 ++++++++++++++++++++++
net-libs/webkit-gtk/webkit-gtk-2.46.4-r410.ebuild | 2 +
net-libs/webkit-gtk/webkit-gtk-2.46.4-r600.ebuild | 2 +
net-libs/webkit-gtk/webkit-gtk-2.46.4.ebuild | 2 +
4 files changed, 121 insertions(+)
diff --git a/net-libs/webkit-gtk/files/2.46.4-no-egl.patch b/net-libs/webkit-gtk/files/2.46.4-no-egl.patch
new file mode 100644
index 000000000000..cf66a8c3bf45
--- /dev/null
+++ b/net-libs/webkit-gtk/files/2.46.4-no-egl.patch
@@ -0,0 +1,115 @@
+https://bugs.gentoo.org/945827
+https://bugs.webkit.org/show_bug.cgi?id=283750
+https://github.com/WebKit/WebKit/commit/1cfbdd74e97ea29636ce442322b5399b43937401
+
+From 9cd50ae71cd463145529f86ca0306319cc9a4321 Mon Sep 17 00:00:00 2001
+From: Philippe Normand <philn@igalia.com>
+Date: Wed, 27 Nov 2024 07:20:41 -0800
+Subject: [PATCH] [WPE][GTK] Build fixes for gbm disabled and release logs
+ disabled https://bugs.webkit.org/show_bug.cgi?id=283750
+
+* Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp:
+(WebCore::PeerConnectionBackend::PeerConnectionBackend):
+* Source/WebCore/Modules/mediastream/PeerConnectionBackend.h:
+* Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp:
+(WebCore::GStreamerMediaEndpoint::startRTCLogs):
+* Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:
+* Source/WebCore/platform/graphics/gstreamer/mse/MediaSourcePrivateGStreamer.h:
+(WKWPE::ViewPlatform::ViewPlatform):
+
+Cherrypicked https://commits.webkit.org/287124@main to 2.46.4
+--- a/Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp
++++ b/Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp
+@@ -165,6 +165,10 @@ PeerConnectionBackend::PeerConnectionBackend(RTCPeerConnection& peerConnection)
+ m_shouldFilterICECandidates = page->webRTCProvider().isSupportingMDNS();
+ #endif
+
++#if RELEASE_LOG_DISABLED
++ m_logIdentifierString = makeString(hex(reinterpret_cast<uintptr_t>(this)));
++#endif
++
+ #if !RELEASE_LOG_DISABLED && (PLATFORM(WPE) || PLATFORM(GTK))
+ m_jsonFilePath = String::fromUTF8(getenv("WEBKIT_WEBRTC_JSON_EVENTS_FILE"));
+ if (!m_jsonFilePath.isEmpty())
+--- a/Source/WebCore/Modules/mediastream/PeerConnectionBackend.h
++++ b/Source/WebCore/Modules/mediastream/PeerConnectionBackend.h
+@@ -281,8 +281,8 @@ private:
+ #if !RELEASE_LOG_DISABLED
+ Ref<const Logger> m_logger;
+ const void* m_logIdentifier;
+- String m_logIdentifierString;
+ #endif
++ String m_logIdentifierString;
+ bool m_finishedGatheringCandidates { false };
+ bool m_isProcessingLocalDescriptionAnswer { false };
+
+--- a/Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp
++++ b/Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp
+@@ -2228,7 +2228,9 @@ std::optional<bool> GStreamerMediaEndpoint::canTrickleIceCandidates() const
+ void GStreamerMediaEndpoint::startRTCLogs()
+ {
+ m_isGatheringRTCLogs = true;
++#if !RELEASE_LOG_DISABLED
+ startLoggingStats();
++#endif
+ }
+
+ void GStreamerMediaEndpoint::stopRTCLogs()
+--- a/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp
++++ b/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp
+@@ -1726,7 +1726,7 @@ void gstStructureFilterAndMapInPlace(GstStructure* structure, Function<bool(GstI
+ #endif
+ }
+
+-#if !GST_CHECK_VERSION(1, 24, 0)
++#if USE(GBM) && !GST_CHECK_VERSION(1, 24, 0)
+ static GstVideoFormat drmFourccToGstVideoFormat(uint32_t fourcc)
+ {
+ switch (fourcc) {
+@@ -1761,7 +1761,7 @@ static GstVideoFormat drmFourccToGstVideoFormat(uint32_t fourcc)
+ RELEASE_ASSERT_NOT_REACHED();
+ return GST_VIDEO_FORMAT_UNKNOWN;
+ }
+-#endif // !GST_CHECK_VERSION(1, 24, 0)
++#endif // USE(GBM) && !GST_CHECK_VERSION(1, 24, 0)
+
+ #if USE(GBM)
+ GRefPtr<GstCaps> buildDMABufCaps()
+@@ -1805,7 +1805,7 @@ GRefPtr<GstCaps> buildDMABufCaps()
+ gst_value_list_append_and_take_value(&supportedFormats, &value);
+ }
+ }
+-#else
++#elif USE(GBM)
+ GValue value = G_VALUE_INIT;
+ g_value_init(&value, G_TYPE_STRING);
+ g_value_set_string(&value, gst_video_format_to_string(drmFourccToGstVideoFormat(format.fourcc)));
+@@ -1815,7 +1815,7 @@ GRefPtr<GstCaps> buildDMABufCaps()
+
+ #if GST_CHECK_VERSION(1, 24, 0)
+ gst_caps_set_value(caps.get(), "drm-format", &supportedFormats);
+-#else
++#elif USE(GBM)
+ gst_caps_set_value(caps.get(), "format", &supportedFormats);
+ #endif
+ g_value_unset(&supportedFormats);
+--- a/Source/WebCore/platform/graphics/gstreamer/mse/MediaSourcePrivateGStreamer.h
++++ b/Source/WebCore/platform/graphics/gstreamer/mse/MediaSourcePrivateGStreamer.h
+@@ -93,13 +93,14 @@ private:
+ #if !RELEASE_LOG_DISABLED
+ Ref<const Logger> m_logger;
+ const void* m_logIdentifier;
++#endif
++
+ uint64_t m_nextSourceBufferID { 0 };
+
+ // Stores known track IDs, so we can work around ID collisions between multiple source buffers.
+ // The registry is placed here to enforce ID uniqueness specifically by player, not by process,
+ // since its not an issue if multiple players use the same ID, and we want to preserve IDs as much as possible.
+ HashSet<TrackID, WTF::IntHash<TrackID>, WTF::UnsignedWithZeroKeyHashTraits<TrackID>> m_trackIdRegistry;
+-#endif
+ };
+
+ } // namespace WebCore
+--
+2.47.1
diff --git a/net-libs/webkit-gtk/webkit-gtk-2.46.4-r410.ebuild b/net-libs/webkit-gtk/webkit-gtk-2.46.4-r410.ebuild
index ae6d1d99d97d..8e3a28eb83da 100644
--- a/net-libs/webkit-gtk/webkit-gtk-2.46.4-r410.ebuild
+++ b/net-libs/webkit-gtk/webkit-gtk-2.46.4-r410.ebuild
@@ -148,6 +148,8 @@ src_prepare() {
# https://bugs.gentoo.org/943213
eapply "${FILESDIR}"/2.44.4-fix-icu76.1.patch
+ # https://bugs.gentoo.org/945827
+ eapply "${FILESDIR}"/2.46.4-no-egl.patch
}
src_configure() {
diff --git a/net-libs/webkit-gtk/webkit-gtk-2.46.4-r600.ebuild b/net-libs/webkit-gtk/webkit-gtk-2.46.4-r600.ebuild
index 753098b08520..67d0513a0a53 100644
--- a/net-libs/webkit-gtk/webkit-gtk-2.46.4-r600.ebuild
+++ b/net-libs/webkit-gtk/webkit-gtk-2.46.4-r600.ebuild
@@ -159,6 +159,8 @@ src_prepare() {
# https://bugs.gentoo.org/943213
eapply "${FILESDIR}"/2.44.4-fix-icu76.1.patch
+ # https://bugs.gentoo.org/945827
+ eapply "${FILESDIR}"/2.46.4-no-egl.patch
}
src_configure() {
diff --git a/net-libs/webkit-gtk/webkit-gtk-2.46.4.ebuild b/net-libs/webkit-gtk/webkit-gtk-2.46.4.ebuild
index 251e70b171d4..299d89ff4edc 100644
--- a/net-libs/webkit-gtk/webkit-gtk-2.46.4.ebuild
+++ b/net-libs/webkit-gtk/webkit-gtk-2.46.4.ebuild
@@ -148,6 +148,8 @@ src_prepare() {
# https://bugs.gentoo.org/943213
eapply "${FILESDIR}"/2.44.4-fix-icu76.1.patch
+ # https://bugs.gentoo.org/945827
+ eapply "${FILESDIR}"/2.46.4-no-egl.patch
}
src_configure() {
next reply other threads:[~2024-12-06 11:19 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-06 11:18 Sam James [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-10-09 15:09 [gentoo-commits] repo/gentoo:master commit in: net-libs/webkit-gtk/, net-libs/webkit-gtk/files/ Michael Orlitzky
2024-06-25 16:45 Jakov Smolić
2024-04-20 11:42 Mart Raudsepp
2024-02-23 19:07 Sam James
2023-08-09 18:07 Matt Turner
2023-07-16 14:38 Matt Turner
2023-04-25 21:38 Matt Turner
2023-04-22 3:08 Matt Turner
2023-01-30 4:01 Sam James
2022-08-02 20:17 Matt Turner
2022-05-13 12:27 Matt Turner
2022-01-18 21:39 Mart Raudsepp
2022-01-05 16:22 Mart Raudsepp
2022-01-02 22:46 Mart Raudsepp
2021-05-31 2:00 Matt Turner
2021-05-12 22:00 Matt Turner
2020-11-27 20:54 Mart Raudsepp
2020-07-29 14:09 Mart Raudsepp
2020-07-19 6:00 Mart Raudsepp
2020-07-11 13:34 Mart Raudsepp
2020-01-31 19:19 Mart Raudsepp
2020-01-19 18:49 Mart Raudsepp
2019-11-23 19:28 Matt Turner
2019-10-29 22:22 Andreas Sturmlechner
2018-07-25 16:47 Mart Raudsepp
2017-10-29 22:11 Mart Raudsepp
2017-04-17 8:10 Mart Raudsepp
2016-08-27 20:20 Sergei Trofimovich
2015-08-25 0:45 Alexandre Rostovtsev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1733483903.b08c8e936b93d6a9e7f741d1e8396ad5e33e3639.sam@gentoo \
--to=sam@gentoo.org \
--cc=gentoo-commits@lists.gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox