From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <gentoo-commits+bounces-1674688-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by finch.gentoo.org (Postfix) with ESMTPS id CBE5B15808B
for <garchives@archives.gentoo.org>; Sun, 29 Sep 2024 00:29:00 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
by pigeon.gentoo.org (Postfix) with SMTP id 2C4D3E2A70;
Sun, 29 Sep 2024 00:29:00 +0000 (UTC)
Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
(No client certificate requested)
by pigeon.gentoo.org (Postfix) with ESMTPS id 0CF7EE2A70
for <gentoo-commits@lists.gentoo.org>; Sun, 29 Sep 2024 00:29:00 +0000 (UTC)
Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (4096 bits))
(No client certificate requested)
by smtp.gentoo.org (Postfix) with ESMTPS id 20941342FAF
for <gentoo-commits@lists.gentoo.org>; Sun, 29 Sep 2024 00:28:59 +0000 (UTC)
Received: from localhost.localdomain (localhost [IPv6:::1])
by oystercatcher.gentoo.org (Postfix) with ESMTP id AEA37ACC
for <gentoo-commits@lists.gentoo.org>; Sun, 29 Sep 2024 00:28:57 +0000 (UTC)
From: "Sam James" <sam@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Content-Transfer-Encoding: 8bit
Content-type: text/plain; charset=UTF-8
Reply-To: gentoo-dev@lists.gentoo.org, "Sam James" <sam@gentoo.org>
Message-ID: <1727569705.ba522492a3f9e057867f4d7f1d2491cd3a7dbfc3.sam@OpenRC>
Subject: [gentoo-commits] proj/netifrc:master commit in: net/
X-VCS-Repository: proj/netifrc
X-VCS-Files: net/iproute2.sh
X-VCS-Directories: net/
X-VCS-Committer: sam
X-VCS-Committer-Name: Sam James
X-VCS-Revision: ba522492a3f9e057867f4d7f1d2491cd3a7dbfc3
X-VCS-Branch: master
Date: Sun, 29 Sep 2024 00:28:57 +0000 (UTC)
Precedence: bulk
List-Post: <mailto:gentoo-commits@lists.gentoo.org>
List-Help: <mailto:gentoo-commits+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-commits+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-commits+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-commits.gentoo.org>
X-BeenThere: gentoo-commits@lists.gentoo.org
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
X-Archives-Salt: 4f9e28c4-504c-463f-bced-247607178118
X-Archives-Hash: 613d65f2b567b3ed8a737fa908488fa0
commit: ba522492a3f9e057867f4d7f1d2491cd3a7dbfc3
Author: Alexander Zubkov <green <AT> qrator <DOT> net>
AuthorDate: Sat Sep 28 19:54:51 2024 +0000
Commit: Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Sun Sep 29 00:28:25 2024 +0000
URL: https://gitweb.gentoo.org/proj/netifrc.git/commit/?id=ba522492
net: iproute2: fix missing quotes in test
Missing quotes cause incorrect evaluation of an empty string, causing
the expression to be always true. Thus every route is considered "nodev"
route, causing problems in cases where specific dev is required.
Original "nodev" patch 7c6a8de0 contained bashism that forgave missing
quoutes. But later it was fixed by 97a79cfd, and the missing quotes
became critical.
Signed-off-by: Alexander Zubkov <green <AT> qrator.net>
Closes: https://bugs.gentoo.org/940443
X-Gentoo-Bug: 940443
X-Gentoo-Bug-URL: https://bugs.gentoo.org/940443
Closes: https://github.com/gentoo/netifrc/pull/58
Signed-off-by: Sam James <sam <AT> gentoo.org>
net/iproute2.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/iproute2.sh b/net/iproute2.sh
index ca43496..4abc47c 100644
--- a/net/iproute2.sh
+++ b/net/iproute2.sh
@@ -290,7 +290,7 @@ _add_route()
# Process dev vs nodev routes
# Positional parameters are used for correct array handling
- if [ -n ${rtype} ]; then
+ if [ -n "${rtype}" ]; then
local nodev_routes="$(service_get_value "nodev_routes")"
service_set_value "nodev_routes" "${nodev_routes}
${family} route del ${rtype} ${cmd}"