From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 1BB45158083 for ; Mon, 23 Sep 2024 01:07:30 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 328A12BC074; Mon, 23 Sep 2024 01:07:29 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 101F82BC074 for ; Mon, 23 Sep 2024 01:07:29 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 0706934347B for ; Mon, 23 Sep 2024 01:07:28 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 6979B27ED for ; Mon, 23 Sep 2024 01:07:26 +0000 (UTC) From: "Sam James" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Sam James" Message-ID: <1727053613.2ebde6581d1aa42be8c21c701217394e1b33c9a5.sam@gentoo> Subject: [gentoo-commits] repo/gentoo:master commit in: net-analyzer/cloudshark/ X-VCS-Repository: repo/gentoo X-VCS-Files: net-analyzer/cloudshark/cloudshark-1.0.4-r1.ebuild net-analyzer/cloudshark/cloudshark-1.0.4.ebuild X-VCS-Directories: net-analyzer/cloudshark/ X-VCS-Committer: sam X-VCS-Committer-Name: Sam James X-VCS-Revision: 2ebde6581d1aa42be8c21c701217394e1b33c9a5 X-VCS-Branch: master Date: Mon, 23 Sep 2024 01:07:26 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 420d583f-e70d-4db0-81d4-63e68e717b16 X-Archives-Hash: 32ee343f6ccd3431754bd640dafdda1c commit: 2ebde6581d1aa42be8c21c701217394e1b33c9a5 Author: Sam James gentoo org> AuthorDate: Mon Sep 23 01:05:43 2024 +0000 Commit: Sam James gentoo org> CommitDate: Mon Sep 23 01:06:53 2024 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2ebde658 net-analyzer/cloudshark: fix invalid PDEPEND use pkgcheck now reports: ``` net-analyzer/cloudshark BadDependency: version 1.0.4: ':=' operator is invalid in: PDEPEND="net-analyzer/wireshark:=[lua]" ``` This showed up in breaking CI when infra updated pkgcheck. As for the PDEPEND use here in general, it's invalid both because: a) PDEPEND should *only* be used for breaking circular dependencies; b) := is ill-defined in PDEPEND. This is a plugin for Wireshark hence needs to be in DEPEND+RDEPEND. Signed-off-by: Sam James gentoo.org> .../{cloudshark-1.0.4.ebuild => cloudshark-1.0.4-r1.ebuild} | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/net-analyzer/cloudshark/cloudshark-1.0.4.ebuild b/net-analyzer/cloudshark/cloudshark-1.0.4-r1.ebuild similarity index 90% rename from net-analyzer/cloudshark/cloudshark-1.0.4.ebuild rename to net-analyzer/cloudshark/cloudshark-1.0.4-r1.ebuild index 3904b2a51763..0eee6336f1e0 100644 --- a/net-analyzer/cloudshark/cloudshark-1.0.4.ebuild +++ b/net-analyzer/cloudshark/cloudshark-1.0.4-r1.ebuild @@ -1,4 +1,4 @@ -# Copyright 1999-2023 Gentoo Authors +# Copyright 1999-2024 Gentoo Authors # Distributed under the terms of the GNU General Public License v2 EAPI=8 @@ -12,8 +12,11 @@ SLOT="0" KEYWORDS="~amd64 ~arm ~x86" IUSE="" -PDEPEND="net-analyzer/wireshark:=[lua] - net-misc/curl" +RDEPEND=" + net-analyzer/wireshark:=[lua] + net-misc/curl +" +DEPEND="${RDEPEND}" S="${WORKDIR}/wireshark-plugin-${PV}"