From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <gentoo-commits+bounces-1667802-garchives=archives.gentoo.org@lists.gentoo.org> Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 9D51015808B for <garchives@archives.gentoo.org>; Thu, 5 Sep 2024 12:10:24 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 66CBCE2A19; Thu, 5 Sep 2024 12:10:23 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 4D521E2A19 for <gentoo-commits@lists.gentoo.org>; Thu, 5 Sep 2024 12:10:23 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 11E1B342F9D for <gentoo-commits@lists.gentoo.org>; Thu, 5 Sep 2024 12:10:22 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 3E1DF14D3 for <gentoo-commits@lists.gentoo.org>; Thu, 5 Sep 2024 12:10:20 +0000 (UTC) From: "Sam James" <sam@gentoo.org> To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Sam James" <sam@gentoo.org> Message-ID: <1725538185.82f9bef4ed76f656a3d79b607eecff526b78b7ee.sam@gentoo> Subject: [gentoo-commits] repo/gentoo:master commit in: eclass/ X-VCS-Repository: repo/gentoo X-VCS-Files: eclass/linux-mod-r1.eclass X-VCS-Directories: eclass/ X-VCS-Committer: sam X-VCS-Committer-Name: Sam James X-VCS-Revision: 82f9bef4ed76f656a3d79b607eecff526b78b7ee X-VCS-Branch: master Date: Thu, 5 Sep 2024 12:10:20 +0000 (UTC) Precedence: bulk List-Post: <mailto:gentoo-commits@lists.gentoo.org> List-Help: <mailto:gentoo-commits+help@lists.gentoo.org> List-Unsubscribe: <mailto:gentoo-commits+unsubscribe@lists.gentoo.org> List-Subscribe: <mailto:gentoo-commits+subscribe@lists.gentoo.org> List-Id: Gentoo Linux mail <gentoo-commits.gentoo.org> X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: a75f558b-8eb3-4244-8e37-7c2aa9b34adf X-Archives-Hash: e6e4fa9924a5db657d87427c50b5370b commit: 82f9bef4ed76f656a3d79b607eecff526b78b7ee Author: Sam James <sam <AT> gentoo <DOT> org> AuthorDate: Thu Sep 5 11:48:02 2024 +0000 Commit: Sam James <sam <AT> gentoo <DOT> org> CommitDate: Thu Sep 5 12:09:45 2024 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=82f9bef4 linux-mod-r1.eclass: BDEPEND on dev-util/pahole If the kernel is built with CONFIG_DEBUG_INFO_BTF_MODULES, external kernel module builds will try to call `pahole` to generate BTF and fail if it's not present. pahole is a small dependency and we're likely to enable BTF by default in more configurations going forward, so do it unconditionally. The alternatives aren't great anyway, we would have to instead: * RDEPEND in g-k-bin * BDEPEND in g-k-bin and break the binpkg case * Use an ewarn in the eclass if pahole isn't installed + config option is set so this is the best option available to us. Thanks-to: Ionen Wolkens <ionen <AT> gentoo.org> Reported-by: Sebastian Engel <sighunter <AT> gmx.de> Signed-off-by: Sam James <sam <AT> gentoo.org> eclass/linux-mod-r1.eclass | 1 + 1 file changed, 1 insertion(+) diff --git a/eclass/linux-mod-r1.eclass b/eclass/linux-mod-r1.eclass index 9911a6ddee12..120fb019d74a 100644 --- a/eclass/linux-mod-r1.eclass +++ b/eclass/linux-mod-r1.eclass @@ -121,6 +121,7 @@ DEPEND=" virtual/linux-sources " BDEPEND=" + dev-util/pahole sys-apps/kmod[tools] modules-sign? ( dev-libs/openssl