From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 427F9159C9B for ; Fri, 9 Aug 2024 14:30:47 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 74058E2BF7; Fri, 9 Aug 2024 14:30:46 +0000 (UTC) Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 5DA65E2BF7 for ; Fri, 9 Aug 2024 14:30:46 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 938CC33BE9F for ; Fri, 9 Aug 2024 14:30:45 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 036F7174C for ; Fri, 9 Aug 2024 14:30:44 +0000 (UTC) From: "Sam James" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Sam James" Message-ID: <1723213783.c1d510a5f4fcd477e94fb429925321d65d3b80ed.sam@gentoo> Subject: [gentoo-commits] repo/gentoo:master commit in: eclass/ X-VCS-Repository: repo/gentoo X-VCS-Files: eclass/toolchain.eclass X-VCS-Directories: eclass/ X-VCS-Committer: sam X-VCS-Committer-Name: Sam James X-VCS-Revision: c1d510a5f4fcd477e94fb429925321d65d3b80ed X-VCS-Branch: master Date: Fri, 9 Aug 2024 14:30:44 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: d31d6a58-b514-403d-bc91-5ddfd6410804 X-Archives-Hash: 3fd67a4915552b8a5776cfb4845722ef commit: c1d510a5f4fcd477e94fb429925321d65d3b80ed Author: Sam James gentoo org> AuthorDate: Fri Aug 9 14:29:43 2024 +0000 Commit: Sam James gentoo org> CommitDate: Fri Aug 9 14:29:43 2024 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c1d510a5 toolchain.eclass: tidy up src_test a bit more, another tweak * Disable -fno-semantic-interposition for tests as ASAN + contract violation checks rely on it * Consolidate the appends vs. filters Signed-off-by: Sam James gentoo.org> eclass/toolchain.eclass | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/eclass/toolchain.eclass b/eclass/toolchain.eclass index 89af435dfbf6..2acade8e4ca8 100644 --- a/eclass/toolchain.eclass +++ b/eclass/toolchain.eclass @@ -1926,23 +1926,25 @@ toolchain_src_test() { ( # Unexpected warnings confuse the tests. filter-flags -W* - # May break parsing. filter-flags '-fdiagnostics-color=*' '-fdiagnostics-urls=*' - # Gentoo QA flags which don't belong in tests filter-flags -frecord-gcc-switches filter-flags '-Wl,--defsym=__gentoo_check_ldflags__=0' + # Go doesn't support this and causes noisy warnings + filter-flags -Wbuiltin-declaration-mismatch + # The ASAN tests at least need LD_PRELOAD and the contract + # tests. + filter-flags -fno-semantic-interposition # Workaround our -Wformat-security default which breaks # various tests as it adds unexpected warning output. - # (Only for C/C++ here to avoid noise for Fortran.) - append-cflags -Wno-format-security -Wno-format - append-cxxflags -Wno-format-security -Wno-format + append-flags -Wno-format-security -Wno-format # Workaround our -Wtrampolines default which breaks # tests too. append-flags -Wno-trampolines - + # A handful of Ada (and objc++?) tests need an executable stack + append-ldflags -Wl,--no-warn-execstack # Avoid confusing tests like Fortran/C interop ones where # CFLAGS are used. append-flags -Wno-complain-wrong-lang @@ -1957,11 +1959,6 @@ toolchain_src_test() { # TODO: This isn't ideal given it obv. affects codegen # and we want to be sure it works. append-flags -fno-stack-clash-protection - # A handful of Ada (and objc++?) tests need an executable stack - append-ldflags -Wl,--no-warn-execstack - - # Go doesn't support this and causes noisy warnings - filter-flags -Wbuiltin-declaration-mismatch # configure defaults to '-O2 -g' and some tests expect it # accordingly.