From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id D409A159C96 for ; Wed, 24 Jul 2024 19:09:30 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 2A9E0E2AC7; Wed, 24 Jul 2024 19:09:30 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 08277E2AC7 for ; Wed, 24 Jul 2024 19:09:30 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 0DD9D335D2B for ; Wed, 24 Jul 2024 19:09:29 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 4E01D1E30 for ; Wed, 24 Jul 2024 19:09:27 +0000 (UTC) From: "Sam James" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Sam James" Message-ID: <1721848115.893fc8602102e9732a5c50e0dcffe13e4b6ef6ad.sam@gentoo> Subject: [gentoo-commits] repo/gentoo:master commit in: net-libs/nodejs/ X-VCS-Repository: repo/gentoo X-VCS-Files: net-libs/nodejs/nodejs-22.4.1-r1.ebuild net-libs/nodejs/nodejs-22.4.1.ebuild X-VCS-Directories: net-libs/nodejs/ X-VCS-Committer: sam X-VCS-Committer-Name: Sam James X-VCS-Revision: 893fc8602102e9732a5c50e0dcffe13e4b6ef6ad X-VCS-Branch: master Date: Wed, 24 Jul 2024 19:09:27 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 9ad0c0e5-7f09-428d-a2f4-892b8cac805d X-Archives-Hash: 8d8ddb1f978bac34ed207f18b4c4a169 commit: 893fc8602102e9732a5c50e0dcffe13e4b6ef6ad Author: Sasha Finkelstein gmail com> AuthorDate: Wed Jul 24 18:31:43 2024 +0000 Commit: Sam James gentoo org> CommitDate: Wed Jul 24 19:08:35 2024 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=893fc860 net-libs/nodejs: Adjust CFLAGS to prevent miscompilations. With -ftree-vectorize (enabled by default with -O2) GCC miscompiles node's exception handling code, causing it to fail to catch exceptions sometimes. Disable it. This bug also causes build fails for www-client/firefox. Upstream bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116057 [sam: Revbump to propagate the fixed binary.] Closes: https://bugs.gentoo.org/936013 Signed-off-by: Sasha Finkelstein gmail.com> Closes: https://github.com/gentoo/gentoo/pull/37651 Signed-off-by: Sam James gentoo.org> net-libs/nodejs/{nodejs-22.4.1.ebuild => nodejs-22.4.1-r1.ebuild} | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/net-libs/nodejs/nodejs-22.4.1.ebuild b/net-libs/nodejs/nodejs-22.4.1-r1.ebuild similarity index 96% rename from net-libs/nodejs/nodejs-22.4.1.ebuild rename to net-libs/nodejs/nodejs-22.4.1-r1.ebuild index 745f2560bf03..b6c767e67464 100644 --- a/net-libs/nodejs/nodejs-22.4.1.ebuild +++ b/net-libs/nodejs/nodejs-22.4.1-r1.ebuild @@ -116,6 +116,10 @@ src_configure() { # LTO compiler flags are handled by configure.py itself filter-lto + # GCC with -ftree-vectorize miscompiles node's exception handling code + # causing it to fail to catch exceptions sometimes + # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116057 + tc-is-gcc && append-cxxflags -fno-tree-vectorize # nodejs unconditionally links to libatomic #869992 # specifically it requires __atomic_is_lock_free which # is not yet implemented by sys-libs/compiler-rt (see @@ -274,6 +278,6 @@ src_test() { pkg_postinst() { if use npm; then ewarn "remember to run: source /etc/profile if you plan to use nodejs" - ewarn " in your current shell" + ewarn " in your current shell" fi }