From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id BD096158004 for ; Fri, 12 Jul 2024 18:59:43 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id BF3122BC021; Fri, 12 Jul 2024 18:59:42 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id A1E7D2BC021 for ; Fri, 12 Jul 2024 18:59:42 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id DCB5E335D6B for ; Fri, 12 Jul 2024 18:59:41 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 7C5501DCD for ; Fri, 12 Jul 2024 18:59:40 +0000 (UTC) From: "Horodniceanu Andrei" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Horodniceanu Andrei" Message-ID: <1720280621.f72da9c5e7b691f145a65839f3e9b0faf8fc67f6.a.horodniceanu@gentoo> Subject: [gentoo-commits] repo/user/dlang:master commit in: eclass/ X-VCS-Repository: repo/user/dlang X-VCS-Files: eclass/dmd-r1.eclass X-VCS-Directories: eclass/ X-VCS-Committer: a.horodniceanu X-VCS-Committer-Name: Horodniceanu Andrei X-VCS-Revision: f72da9c5e7b691f145a65839f3e9b0faf8fc67f6 X-VCS-Branch: master Date: Fri, 12 Jul 2024 18:59:40 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: d9909ffd-11e1-4752-a618-67c15e3baffc X-Archives-Hash: 04e2c31755c40d0e8c92d00d25c1a600 commit: f72da9c5e7b691f145a65839f3e9b0faf8fc67f6 Author: Andrei Horodniceanu proton me> AuthorDate: Sat Jul 6 15:15:38 2024 +0000 Commit: Horodniceanu Andrei proton me> CommitDate: Sat Jul 6 15:43:41 2024 +0000 URL: https://gitweb.gentoo.org/repo/user/dlang.git/commit/?id=f72da9c5 dmd-r1.eclass: clarify dependency on stdlib of host compiler The previous comment, saying that dmd doesn't link the standard lib of the host compiler, is plain wrong, it always does. The only particularity is that dmd doesn't seem to need phobos but it does need druntime. Regardless, a RDEPEND on the host compiler is needed. Another comment has been added trying to describe the reason why DLANG_DEPS should be present in DEPEND. My current understanding is that since the compiler needs to link libraries from SYSROOT (druntime and phobos) to produce the CHOST dmd executable then those libraries should be listed in DEPEND. I'm not 100% sure though. Signed-off-by: Andrei Horodniceanu proton.me> eclass/dmd-r1.eclass | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/eclass/dmd-r1.eclass b/eclass/dmd-r1.eclass index e34af81..49ec257 100644 --- a/eclass/dmd-r1.eclass +++ b/eclass/dmd-r1.eclass @@ -85,10 +85,10 @@ IDEPEND=">=app-eselect/eselect-dlang-20140709" BDEPEND="!selfhost? ( ${DLANG_DEPS} )" # We don't need anything in DEPEND, curl is dl-opened # so it belongs in RDEPEND. +# +# Thinking about this more ${DLANG_DEPS} should probably go in DEPEND. I +# want, however, to test this before making the fix. #DEPEND= -# Since 2.107.0, dmd links the standard library of the host -# compiler. Since this eclass is only used by >=dmd-2.107.0-r1 the -# dependency is added unconditionally. RDEPEND=" ${IDEPEND} net-misc/curl[${MULTILIB_USEDEP}]