[gentoo-commits] repo/gentoo:master commit in: net-p2p/retroshare/

["Sam James" <sam@gentoo.org>]

commit:     9b0a50bdb4a417142d4e87c154bcccf87576e268
Author:     gentoo-setan <gentoo-setan <AT> protonmail <DOT> com>
AuthorDate: Wed Jul  3 17:56:57 2024 +0000
Commit:     Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Thu Jul  4 01:22:20 2024 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9b0a50bd

net-p2p/retroshare: Swap 0.6.7 for 0.6.7-r1, fix miniupnpc API

Retroshare only recognizes API over 14:
https://github.com/RetroShare/libretroshare/blob/402f32eda026c3ec3e429b5fb842e87ebd985d73/src/rs_upnp/upnphandler_miniupnp.cc#L50

And miniupnp changed one of the functions core functions in API 18
https://github.com/miniupnp/miniupnp/blob/3911bace98ec1593dcc41953a09f3fd657c341be/miniupnpc/apiversions.txt#L6

Retroshare did not adapt so we need to pin the dep until the upstream
resolves this issue: https://github.com/RetroShare/RetroShare/issues/2865

Closes: https://bugs.gentoo.org/935043
Signed-off-by: gentoo-setan <gentoo-setan <AT> protonmail.com>
Closes: https://github.com/gentoo/gentoo/pull/37412
Signed-off-by: Sam James <sam <AT> gentoo.org>

 .../{retroshare-0.6.7.ebuild => retroshare-0.6.7-r1.ebuild}          | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/net-p2p/retroshare/retroshare-0.6.7.ebuild b/net-p2p/retroshare/retroshare-0.6.7-r1.ebuild
similarity index 95%
rename from net-p2p/retroshare/retroshare-0.6.7.ebuild
rename to net-p2p/retroshare/retroshare-0.6.7-r1.ebuild
index 75d54db90e7a..40334e72e45b 100644
--- a/net-p2p/retroshare/retroshare-0.6.7.ebuild
+++ b/net-p2p/retroshare/retroshare-0.6.7-r1.ebuild
@@ -10,6 +10,7 @@ HOMEPAGE="https://retroshare.cc"
 SRC_URI="https://download.opensuse.org/repositories/network:/retroshare/Debian_Testing/retroshare-common_${PV}.orig.tar.gz -> ${P}.tar.gz"
 S="${WORKDIR}/RetroShare"
 # NOTE: GitHub releases/archive is impractical to build so we use the OBS repo
+# but they squash point releases which is bad for us
 
 LICENSE="AGPL-3 Apache-2.0 CC-BY-SA-4.0 GPL-2 GPL-3 LGPL-3"
 SLOT="0"
@@ -40,14 +41,14 @@ RDEPEND="
 		x11-libs/libXScrnSaver
 	)
 	libupnp? ( net-libs/libupnp:= )
-	miniupnp? ( net-libs/miniupnpc:= )
+	miniupnp? ( <net-libs/miniupnpc-2.2.8:= )
 	sqlcipher? ( dev-db/sqlcipher )
 	!sqlcipher? ( dev-db/sqlite:3 )
 	plugins? (
 		media-libs/speex
 		media-libs/speexdsp
 		<media-video/ffmpeg-5
-	)"
+	)" # REVIEW: miniupnp pinned because retroshare does not support API 18 yet
 
 # NOTE(setan): rapidjson might not be needed if not using jsonapi. This is to be tested
 DEPEND="${RDEPEND}