public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Sam James" <sam@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: dev-libs/mimalloc/
Date: Mon, 20 May 2024 08:11:11 +0000 (UTC)	[thread overview]
Message-ID: <1716192651.79560e44184ed0241f7199722cf8c1dd3207b256.sam@gentoo> (raw)

commit:     79560e44184ed0241f7199722cf8c1dd3207b256
Author:     Matthew Smith <matthew <AT> gentoo <DOT> org>
AuthorDate: Fri May 17 08:57:18 2024 +0000
Commit:     Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Mon May 20 08:10:51 2024 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=79560e44

dev-libs/mimalloc: conditionally add -latomic

Some systems do not have libatomic, so forcing its use causes build
errors.

Bug: https://bugs.gentoo.org/931778
Signed-off-by: Matthew Smith <matthew <AT> gentoo.org>
Closes: https://github.com/gentoo/gentoo/pull/36716
Signed-off-by: Sam James <sam <AT> gentoo.org>

 dev-libs/mimalloc/mimalloc-2.1.4.ebuild | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/dev-libs/mimalloc/mimalloc-2.1.4.ebuild b/dev-libs/mimalloc/mimalloc-2.1.4.ebuild
index bd26f566a18c..a09a864cbf24 100644
--- a/dev-libs/mimalloc/mimalloc-2.1.4.ebuild
+++ b/dev-libs/mimalloc/mimalloc-2.1.4.ebuild
@@ -3,7 +3,7 @@
 
 EAPI=8
 
-inherit cmake-multilib
+inherit cmake-multilib flag-o-matic
 
 DESCRIPTION="A compact general purpose allocator with excellent performance"
 HOMEPAGE="https://github.com/microsoft/mimalloc"
@@ -25,13 +25,12 @@ src_configure() {
 		-DMI_BUILD_OBJECT=OFF
 		-DMI_BUILD_STATIC=OFF
 		-DMI_TRACK_VALGRIND=$(usex valgrind)
-
-		# Bug #923177
-		# find_library(... atomic) appears to not work. Fall back to -latomic
-		-DMI_USE_LIBATOMIC=ON
-
 		-DMI_LIBC_MUSL=$(usex elibc_musl)
 	)
 
+	# Bug #923177, #931778: append -latomic if it is available
+	test-flags-CCLD "-latomic" &>/dev/null &&
+		mycmakeargs+=( -DMI_USE_LIBATOMIC=ON )
+
 	cmake-multilib_src_configure
 }


             reply	other threads:[~2024-05-20  8:11 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-20  8:11 Sam James [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-07-05  4:53 [gentoo-commits] repo/gentoo:master commit in: dev-libs/mimalloc/ Sam James
2025-07-05  4:53 Sam James
2025-05-27 15:09 Sam James
2025-02-09  7:30 Sam James
2025-01-20  4:32 Sam James
2025-01-20  4:32 Sam James
2025-01-04 12:13 Sam James
2024-12-27 11:43 Sam James
2024-10-05 12:02 Arthur Zamarin
2024-08-29  5:10 Jakov Smolić
2024-08-12 18:53 Sam James
2024-07-14 10:41 James Le Cuirot
2024-06-02  5:46 Sam James
2024-05-20  8:11 Sam James
2024-04-23 17:36 Matthew Smith
2024-01-29  9:33 Matthew Smith
2023-11-25  5:28 Sam James
2023-11-13  4:35 Sam James
2023-11-13  4:35 Sam James
2023-06-25  7:05 Sam James
2023-05-16  1:52 Sam James
2023-04-25 14:02 Arthur Zamarin
2023-04-25  1:57 Sam James
2023-04-05 19:32 Georgy Yakovlev
2023-04-03 19:47 Georgy Yakovlev
2023-03-31 21:28 Sam James
2023-03-31 21:28 Sam James
2023-03-04  8:55 Arthur Zamarin
2023-01-27  6:27 Sam James
2023-01-23  7:25 Georgy Yakovlev
2022-12-30  7:32 Sam James
2022-11-15 20:19 Matthew Smith
2022-07-28 10:17 Sam James
2022-07-10  8:40 Matthew Smith
2022-05-28 10:03 Jakov Smolić
2022-05-24 16:07 WANG Xuerui
2022-04-17 16:44 Sam James
2022-04-16  3:07 Sam James
2022-04-13  9:44 Jakov Smolić
2022-04-05  5:27 Agostino Sarubbo
2022-03-14 12:26 Sam James
2022-03-12 17:37 Matthew Smith
2022-03-12 17:37 Matthew Smith
2022-03-12 17:37 Matthew Smith
2022-03-07 19:51 Patrick McLean
2022-02-20  5:51 Sam James
2022-02-18  0:40 Sam James
2022-02-18  0:40 Sam James
2022-01-01  9:39 Sam James
2021-12-20  5:08 Sam James
2021-12-20  4:44 Sam James
2021-12-15  5:42 Sam James

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1716192651.79560e44184ed0241f7199722cf8c1dd3207b256.sam@gentoo \
    --to=sam@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox