public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Sam James" <sam@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: games-action/supertuxkart/
Date: Tue, 19 Mar 2024 06:09:02 +0000 (UTC)	[thread overview]
Message-ID: <1710828355.cc04e9b38ec9b7b714f6f5d33e3c6f262d38ddea.sam@gentoo> (raw)

commit:     cc04e9b38ec9b7b714f6f5d33e3c6f262d38ddea
Author:     Eli Schwartz <eschwartz93 <AT> gmail <DOT> com>
AuthorDate: Tue Mar 19 05:54:38 2024 +0000
Commit:     Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Tue Mar 19 06:05:55 2024 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cc04e9b3

games-action/supertuxkart: mark as LTO-unsafe, strict-aliasing unsafe

Includes bundled sci-physics/bullet which has its own bug...

Closes: https://bugs.gentoo.org/858521
Signed-off-by: Eli Schwartz <eschwartz93 <AT> gmail.com>
Signed-off-by: Sam James <sam <AT> gentoo.org>

 games-action/supertuxkart/supertuxkart-1.3.ebuild    | 15 +++++++++++++--
 games-action/supertuxkart/supertuxkart-1.4-r1.ebuild | 15 +++++++++++++--
 2 files changed, 26 insertions(+), 4 deletions(-)

diff --git a/games-action/supertuxkart/supertuxkart-1.3.ebuild b/games-action/supertuxkart/supertuxkart-1.3.ebuild
index 54504fdfec32..d3a6aa690718 100644
--- a/games-action/supertuxkart/supertuxkart-1.3.ebuild
+++ b/games-action/supertuxkart/supertuxkart-1.3.ebuild
@@ -1,9 +1,9 @@
-# Copyright 1999-2022 Gentoo Authors
+# Copyright 1999-2024 Gentoo Authors
 # Distributed under the terms of the GNU General Public License v2
 
 EAPI=8
 
-inherit cmake desktop xdg
+inherit cmake desktop flag-o-matic xdg
 
 MY_P="SuperTuxKart-${PV}-src"
 DESCRIPTION="A kart racing game starring Tux, the linux penguin (TuxKart fork)"
@@ -63,6 +63,17 @@ src_prepare() {
 }
 
 src_configure() {
+	# -Werror=strict-aliasing
+	# https://bugs.gentoo.org/858521
+	# https://github.com/supertuxkart/stk-code/issues/5035
+	#
+	# The issue is bundled code from sci-physics/bullet which is unlikely to
+	# be debundled.
+	#
+	# Do not trust with LTO either.
+	append-flags -fno-strict-aliasing
+	filter-lto
+
 	local mycmakeargs=(
 		-DUSE_SQLITE3=$(usex sqlite)
 		-DUSE_SYSTEM_ANGELSCRIPT=ON

diff --git a/games-action/supertuxkart/supertuxkart-1.4-r1.ebuild b/games-action/supertuxkart/supertuxkart-1.4-r1.ebuild
index 7b2fcde8f196..85252331bd59 100644
--- a/games-action/supertuxkart/supertuxkart-1.4-r1.ebuild
+++ b/games-action/supertuxkart/supertuxkart-1.4-r1.ebuild
@@ -1,9 +1,9 @@
-# Copyright 1999-2023 Gentoo Authors
+# Copyright 1999-2024 Gentoo Authors
 # Distributed under the terms of the GNU General Public License v2
 
 EAPI=8
 
-inherit cmake desktop xdg
+inherit cmake desktop flag-o-matic xdg
 
 MY_P="SuperTuxKart-${PV}-src"
 DESCRIPTION="A kart racing game starring Tux, the linux penguin (TuxKart fork)"
@@ -59,6 +59,17 @@ PATCHES=(
 )
 
 src_configure() {
+	# -Werror=strict-aliasing
+	# https://bugs.gentoo.org/858521
+	# https://github.com/supertuxkart/stk-code/issues/5035
+	#
+	# The issue is bundled code from sci-physics/bullet which is unlikely to
+	# be debundled.
+	#
+	# Do not trust with LTO either.
+	append-flags -fno-strict-aliasing
+	filter-lto
+
 	local mycmakeargs=(
 		-DUSE_SQLITE3=$(usex sqlite)
 		-DUSE_SYSTEM_ANGELSCRIPT=ON


             reply	other threads:[~2024-03-19  6:09 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-19  6:09 Sam James [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-10-13 10:58 [gentoo-commits] repo/gentoo:master commit in: games-action/supertuxkart/ WANG Xuerui
2023-01-29 10:51 James Le Cuirot
2023-01-28  5:11 Sam James
2022-07-23 19:44 Sam James
2022-06-08  7:57 Jakov Smolić
2022-04-10 10:58 James Le Cuirot
2021-09-12 14:26 Yixun Lan
2021-05-03  7:01 Mikle Kolyada
2020-09-02  0:11 Sam James
2020-09-01 23:32 Sam James
2020-04-14 21:38 James Le Cuirot
2019-05-10 21:34 James Le Cuirot
2019-05-10 21:24 James Le Cuirot
2019-05-10 21:16 James Le Cuirot
2018-08-15 10:33 Michał Górny
2017-12-26 12:02 James Le Cuirot
2017-09-30  5:32 Michael Palimaka
2017-09-30  5:32 Michael Palimaka
2017-09-19 10:49 James Le Cuirot
2015-12-25 15:13 Agostino Sarubbo
2015-12-12 16:53 Michael Sterrett
2015-12-12 16:53 Michael Sterrett
2015-11-09 19:35 Michael Sterrett
2015-10-08  6:03 Michael Sterrett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1710828355.cc04e9b38ec9b7b714f6f5d33e3c6f262d38ddea.sam@gentoo \
    --to=sam@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox