[gentoo-commits] repo/gentoo:master commit in: dev-qt/qtwebengine/

["Ionen Wolkens" <ionen@gentoo.org>]

commit:     f3796a1139d1b7a5d7611803bbfc093251fdc491
Author:     Ionen Wolkens <ionen <AT> gentoo <DOT> org>
AuthorDate: Mon Mar  4 13:35:04 2024 +0000
Commit:     Ionen Wolkens <ionen <AT> gentoo <DOT> org>
CommitDate: Mon Mar  4 14:53:03 2024 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f3796a11

dev-qt/qtwebengine: add IUSE=webdriver to 6.7+

No deps but make it optional given most people do not need this
and it adds a bit of build time plus ~35MB to the install.

For the IUSE name, debated IUSE=webenginedriver as well but "webdriver"
is the name of the specification, and it felt redundant to have
webengine in the IUSE name for the webengine package.

wrt tests, unfortunately like most tools-related tests (see qttools),
it tries to use the system's tool and makes it difficult to specify
a path -- so skipping tst_webenginedriver for simplicity, it's not
a component that need to be overly worried about either way (haven't
tried but imagine may be further messy with sandbox too).

Signed-off-by: Ionen Wolkens <ionen <AT> gentoo.org>

 dev-qt/qtwebengine/metadata.xml                | 1 +
 dev-qt/qtwebengine/qtwebengine-6.7.9999.ebuild | 5 ++++-
 dev-qt/qtwebengine/qtwebengine-6.9999.ebuild   | 5 ++++-
 3 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/dev-qt/qtwebengine/metadata.xml b/dev-qt/qtwebengine/metadata.xml
index b7754632ca20..026c10e856ad 100644
--- a/dev-qt/qtwebengine/metadata.xml
+++ b/dev-qt/qtwebengine/metadata.xml
@@ -11,6 +11,7 @@
 		<flag name="pdfium">Build the QtPdf module based on chromium's PDFium library</flag>
 		<flag name="qml">Build QML/QtQuick bindings and imports</flag>
 		<flag name="system-icu">Use the system-wide <pkg>dev-libs/icu</pkg> instead of bundled.</flag>
+		<flag name="webdriver">Build tool for automated testing (ChromeDriver equivalent)</flag>
 		<flag name="widgets">Enable QtWidgets support</flag>
 	</use>
 	<upstream>

diff --git a/dev-qt/qtwebengine/qtwebengine-6.7.9999.ebuild b/dev-qt/qtwebengine/qtwebengine-6.7.9999.ebuild
index 08af1005ed95..f5f10a5f3ebd 100644
--- a/dev-qt/qtwebengine/qtwebengine-6.7.9999.ebuild
+++ b/dev-qt/qtwebengine/qtwebengine-6.7.9999.ebuild
@@ -20,7 +20,7 @@ fi
 IUSE="
 	+alsa bindist custom-cflags designer geolocation +jumbo-build
 	kerberos opengl pdfium pulseaudio qml screencast +system-icu
-	vaapi vulkan +widgets
+	vaapi vulkan webdriver +widgets
 "
 REQUIRED_USE="
 	designer? ( qml widgets )
@@ -171,6 +171,7 @@ src_configure() {
 	local mycmakeargs=(
 		$(qt_feature pdfium qtpdf_build)
 		$(qt_feature qml qtpdf_quick_build)
+		$(qt_feature webdriver webenginedriver)
 		$(qt_feature widgets qtpdf_widgets_build)
 		$(usev pdfium -DQT_FEATURE_pdf_v8=ON)
 
@@ -274,6 +275,8 @@ src_test() {
 		tst_qwebengineclientcertificatestore
 		# test is misperformed when qtbase is built USE=-test?
 		tst_touchinput
+		# currently requires webenginedriver to be already installed
+		tst_webenginedriver
 	)
 
 	# prevent using the system's qtwebengine

diff --git a/dev-qt/qtwebengine/qtwebengine-6.9999.ebuild b/dev-qt/qtwebengine/qtwebengine-6.9999.ebuild
index db61cb1b8cff..a8e50ac17067 100644
--- a/dev-qt/qtwebengine/qtwebengine-6.9999.ebuild
+++ b/dev-qt/qtwebengine/qtwebengine-6.9999.ebuild
@@ -20,7 +20,7 @@ fi
 IUSE="
 	+alsa bindist custom-cflags designer geolocation +jumbo-build
 	kerberos opengl pdfium pulseaudio qml screencast +system-icu
-	vaapi vulkan +widgets
+	vaapi vulkan webdriver +widgets
 "
 REQUIRED_USE="
 	designer? ( qml widgets )
@@ -170,6 +170,7 @@ src_configure() {
 	local mycmakeargs=(
 		$(qt_feature pdfium qtpdf_build)
 		$(qt_feature qml qtpdf_quick_build)
+		$(qt_feature webdriver webenginedriver)
 		$(qt_feature widgets qtpdf_widgets_build)
 		$(usev pdfium -DQT_FEATURE_pdf_v8=ON)
 
@@ -273,6 +274,8 @@ src_test() {
 		tst_qwebengineclientcertificatestore
 		# test is misperformed when qtbase is built USE=-test?
 		tst_touchinput
+		# currently requires webenginedriver to be already installed
+		tst_webenginedriver
 	)
 
 	# prevent using the system's qtwebengine