From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 2AD08158041 for ; Sun, 3 Mar 2024 05:52:14 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id E7CE1E29B4; Sun, 3 Mar 2024 05:52:12 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id C1149E29B4 for ; Sun, 3 Mar 2024 05:52:12 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id C3492343024 for ; Sun, 3 Mar 2024 05:52:11 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 6006214B6 for ; Sun, 3 Mar 2024 05:52:10 +0000 (UTC) From: "Sam James" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Sam James" Message-ID: <1709445072.bf8021b7878ce7a4dbd92639ca20ef93084514dc.sam@gentoo> Subject: [gentoo-commits] repo/gentoo:master commit in: app-i18n/xvnkb/ X-VCS-Repository: repo/gentoo X-VCS-Files: app-i18n/xvnkb/xvnkb-0.2.11.ebuild X-VCS-Directories: app-i18n/xvnkb/ X-VCS-Committer: sam X-VCS-Committer-Name: Sam James X-VCS-Revision: bf8021b7878ce7a4dbd92639ca20ef93084514dc X-VCS-Branch: master Date: Sun, 3 Mar 2024 05:52:10 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: b43e2dfa-d094-4a7b-b9fd-e8dadece5bf0 X-Archives-Hash: 39f6dead932e32d324c8a93210d3e3ac commit: bf8021b7878ce7a4dbd92639ca20ef93084514dc Author: Eli Schwartz gmail com> AuthorDate: Sun Mar 3 05:32:08 2024 +0000 Commit: Sam James gentoo org> CommitDate: Sun Mar 3 05:51:12 2024 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bf8021b7 app-i18n/xvnkb: error out immediately if no Makefile exists This package is absolutely horrible. It has the world's worst homebrew "configure" script, which fails but doesn't *error out* with -Wimplicit-int as a compiler default error, and also has: config.h:1:1: error: expected identifier or ‘(’ before ‘-’ token 1 | -e #ifndef __VK_CONFIG_H which is just... dandy... I too love unix command flags echo'ed into my headers... It's a wreck but we can at least detect when it cannot compile anything and abort with a clearer message. Bug: https://bugs.gentoo.org/900398 Signed-off-by: Eli Schwartz gmail.com> Signed-off-by: Sam James gentoo.org> app-i18n/xvnkb/xvnkb-0.2.11.ebuild | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app-i18n/xvnkb/xvnkb-0.2.11.ebuild b/app-i18n/xvnkb/xvnkb-0.2.11.ebuild index 98e4e14b988b..876fa3426ab7 100644 --- a/app-i18n/xvnkb/xvnkb-0.2.11.ebuild +++ b/app-i18n/xvnkb/xvnkb-0.2.11.ebuild @@ -1,4 +1,4 @@ -# Copyright 1999-2022 Gentoo Authors +# Copyright 1999-2024 Gentoo Authors # Distributed under the terms of the GNU General Public License v2 EAPI="8" @@ -37,6 +37,7 @@ src_configure() { $(usex xft '' '--no-xft') \ --use-extstroke \ || die "./configure failed" + [[ -f Makefile ]] || die "./configure failed to set an error code, but didn't create a Makefile either" } src_install() {