public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Sam James" <sam@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: app-i18n/xvnkb/
Date: Sun,  3 Mar 2024 05:52:10 +0000 (UTC)	[thread overview]
Message-ID: <1709445072.2cc6964f97c84b02944bf72ce1b53de8e5743e54.sam@gentoo> (raw)

commit:     2cc6964f97c84b02944bf72ce1b53de8e5743e54
Author:     Eli Schwartz <eschwartz93 <AT> gmail <DOT> com>
AuthorDate: Sun Mar  3 05:39:22 2024 +0000
Commit:     Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Sun Mar  3 05:51:12 2024 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2cc6964f

app-i18n/xvnkb: run configure with bash

config.h:1:1: error: expected identifier or ‘(’ before ‘-’ token
    1 | -e #ifndef __VK_CONFIG_H

This is just... dandy... I too love unix command flags echo'ed into my
headers...

It uses echo -e to a header, which breaks on non-bash shells and is
generally a problem.

Closes: https://bugs.gentoo.org/886069
Signed-off-by: Eli Schwartz <eschwartz93 <AT> gmail.com>
Signed-off-by: Sam James <sam <AT> gentoo.org>

 app-i18n/xvnkb/xvnkb-0.2.11.ebuild | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/app-i18n/xvnkb/xvnkb-0.2.11.ebuild b/app-i18n/xvnkb/xvnkb-0.2.11.ebuild
index 876fa3426ab7..a03d2ecadfdf 100644
--- a/app-i18n/xvnkb/xvnkb-0.2.11.ebuild
+++ b/app-i18n/xvnkb/xvnkb-0.2.11.ebuild
@@ -31,8 +31,8 @@ src_prepare() {
 }
 
 src_configure() {
-	# *not* autotools
-	./configure \
+	# *not* autotools. Uses broken logic that assumes all the world is a bash
+	bash ./configure \
 		$(usex spell '' '--no-spellcheck') \
 		$(usex xft '' '--no-xft') \
 		--use-extstroke \


             reply	other threads:[~2024-03-03  5:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-03  5:52 Sam James [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-03-03  5:52 [gentoo-commits] repo/gentoo:master commit in: app-i18n/xvnkb/ Sam James
2022-11-16 23:00 Sam James
2022-08-02  7:48 Joonas Niilola
2021-10-19 14:42 Akinori Hattori
2021-10-19 14:42 Akinori Hattori
2019-10-19 10:48 David Seifert
2016-05-14  8:49 Michał Górny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1709445072.2cc6964f97c84b02944bf72ce1b53de8e5743e54.sam@gentoo \
    --to=sam@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox