From: "Sam James" <sam@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: sys-libs/slang/files/, sys-libs/slang/
Date: Wed, 21 Feb 2024 07:10:05 +0000 (UTC) [thread overview]
Message-ID: <1708499269.e2b4a39461adb558b3dbe8bdcadde871a07c0c64.sam@gentoo> (raw)
commit: e2b4a39461adb558b3dbe8bdcadde871a07c0c64
Author: Michal Rostecki <vadorovsky <AT> protonmail <DOT> com>
AuthorDate: Thu Feb 1 07:10:21 2024 +0000
Commit: Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Wed Feb 21 07:07:49 2024 +0000
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e2b4a394
sys-libs/slang: Fix the build with LLD 17
LLD 17 rightfully complains about the undefined symbol being present
in the version script, which is also not used anywhere.
Closes: https://bugs.gentoo.org/915818
Signed-off-by: Michal Rostecki <vadorovsky <AT> protonmail.com>
Closes: https://github.com/gentoo/gentoo/pull/35129
Signed-off-by: Sam James <sam <AT> gentoo.org>
...move-undefined-symbol-from-version-script.patch | 30 ++++++++++++++++++++++
sys-libs/slang/slang-2.3.3.ebuild | 1 +
2 files changed, 31 insertions(+)
diff --git a/sys-libs/slang/files/slang-2.3.3-remove-undefined-symbol-from-version-script.patch b/sys-libs/slang/files/slang-2.3.3-remove-undefined-symbol-from-version-script.patch
new file mode 100644
index 000000000000..d3085797d1f8
--- /dev/null
+++ b/sys-libs/slang/files/slang-2.3.3-remove-undefined-symbol-from-version-script.patch
@@ -0,0 +1,30 @@
+From f0d959a496cf47482904c62c91312aba5153f423 Mon Sep 17 00:00:00 2001
+From: Michal Rostecki <vadorovsky@gmail.com>
+Date: Thu, 1 Feb 2024 08:02:44 +0100
+Subject: [PATCH] Remove the undefined SLang_Rline_Quit symbol from the version
+ script
+
+This symbol is not defined and not used anywhere, it was present only
+in the version file, which triggered the following error when linking
+with LLD 17:
+
+ ld.lld: error: version script assignment of 'SLANG2' to symbol 'SLang_Rline_Quit' failed: symbol not defined
+---
+ src/slang.ver | 1 -
+ 1 file changed, 1 deletion(-)
+
+diff --git a/src/slang.ver b/src/slang.ver
+index aa030c9..4b01f9f 100644
+--- a/src/slang.ver
++++ b/src/slang.ver
+@@ -70,7 +70,6 @@ SLANG2 {
+ SLang_Last_Key_Char;
+ SLang_Load_File_Hook;
+ SLang_Num_Function_Args;
+- SLang_Rline_Quit;
+ SLang_TT_Baud_Rate;
+ SLang_TT_Read_FD;
+ SLang_TT_Write_FD;
+--
+2.43.0
+
diff --git a/sys-libs/slang/slang-2.3.3.ebuild b/sys-libs/slang/slang-2.3.3.ebuild
index 2cf06ca437c9..1cf13c918011 100644
--- a/sys-libs/slang/slang-2.3.3.ebuild
+++ b/sys-libs/slang/slang-2.3.3.ebuild
@@ -37,6 +37,7 @@ MAKEOPTS+=" -j1"
PATCHES=(
"${FILESDIR}"/${PN}-2.3.3-slsh-libs.patch
+ "${FILESDIR}"/${PN}-2.3.3-remove-undefined-symbol-from-version-script.patch
)
src_prepare() {
next reply other threads:[~2024-02-21 7:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 7:10 Sam James [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-06-09 18:54 [gentoo-commits] repo/gentoo:master commit in: sys-libs/slang/files/, sys-libs/slang/ Matt Turner
2022-08-12 18:16 Sam James
2016-10-31 20:31 Lars Wendler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1708499269.e2b4a39461adb558b3dbe8bdcadde871a07c0c64.sam@gentoo \
--to=sam@gentoo.org \
--cc=gentoo-commits@lists.gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox