From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <gentoo-commits+bounces-1593249-garchives=archives.gentoo.org@lists.gentoo.org> Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 5789915838C for <garchives@archives.gentoo.org>; Mon, 22 Jan 2024 05:55:50 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id DE886E2A0A; Mon, 22 Jan 2024 05:55:47 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id C149FE2A0A for <gentoo-commits@lists.gentoo.org>; Mon, 22 Jan 2024 05:55:47 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id D28AD343245 for <gentoo-commits@lists.gentoo.org>; Mon, 22 Jan 2024 05:55:46 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 77D4714BD for <gentoo-commits@lists.gentoo.org>; Mon, 22 Jan 2024 05:55:45 +0000 (UTC) From: "Sam James" <sam@gentoo.org> To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Sam James" <sam@gentoo.org> Message-ID: <1705902889.4674452c9296bc324d1af8bb45e30a39d2a181a2.sam@gentoo> Subject: [gentoo-commits] repo/gentoo:master commit in: net-p2p/qbittorrent/ X-VCS-Repository: repo/gentoo X-VCS-Files: net-p2p/qbittorrent/qbittorrent-4.5.5-r2.ebuild net-p2p/qbittorrent/qbittorrent-9999.ebuild X-VCS-Directories: net-p2p/qbittorrent/ X-VCS-Committer: sam X-VCS-Committer-Name: Sam James X-VCS-Revision: 4674452c9296bc324d1af8bb45e30a39d2a181a2 X-VCS-Branch: master Date: Mon, 22 Jan 2024 05:55:45 +0000 (UTC) Precedence: bulk List-Post: <mailto:gentoo-commits@lists.gentoo.org> List-Help: <mailto:gentoo-commits+help@lists.gentoo.org> List-Unsubscribe: <mailto:gentoo-commits+unsubscribe@lists.gentoo.org> List-Subscribe: <mailto:gentoo-commits+subscribe@lists.gentoo.org> List-Id: Gentoo Linux mail <gentoo-commits.gentoo.org> X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: ade5edb3-1dca-47f4-81e5-0b4ace6f3c90 X-Archives-Hash: c0ccb9ff932bff960059b3dcd11965ce commit: 4674452c9296bc324d1af8bb45e30a39d2a181a2 Author: Eli Schwartz <eschwartz93 <AT> gmail <DOT> com> AuthorDate: Sun Jan 21 18:38:29 2024 +0000 Commit: Sam James <sam <AT> gentoo <DOT> org> CommitDate: Mon Jan 22 05:54:49 2024 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4674452c net-p2p/qbittorrent: remove libiconv dependency It was silently removed from 4.6.x as part of a bump. It was *added* long ago in commit 6b33e72d8933aca72a03b23870178adc55ec3998 with the informative and explanatory message: > Add virtual/libiconv dep I don't believe there's any valid justification for this. The application makes heavy use of Qt, and that includes using Qt's string translation features, which means it will use whatever Qt's APIs happen to use internally. Nowhere in the source code is iconv mentioned at all. If the virtual is needed then it is firmly in the realm of "citation needed". Remove it from 4.5 as well -- and the live ebuild. Signed-off-by: Eli Schwartz <eschwartz93 <AT> gmail.com> Signed-off-by: Sam James <sam <AT> gentoo.org> net-p2p/qbittorrent/qbittorrent-4.5.5-r2.ebuild | 1 - net-p2p/qbittorrent/qbittorrent-9999.ebuild | 1 - 2 files changed, 2 deletions(-) diff --git a/net-p2p/qbittorrent/qbittorrent-4.5.5-r2.ebuild b/net-p2p/qbittorrent/qbittorrent-4.5.5-r2.ebuild index 38a602fd3418..58cb4c88dc3d 100644 --- a/net-p2p/qbittorrent/qbittorrent-4.5.5-r2.ebuild +++ b/net-p2p/qbittorrent/qbittorrent-4.5.5-r2.ebuild @@ -29,7 +29,6 @@ RDEPEND=" >=dev-libs/openssl-1.1.1:= >=net-libs/libtorrent-rasterbar-1.2.18:= >=sys-libs/zlib-1.2.11 - virtual/libiconv gui? ( dev-libs/geoip !qt6? ( diff --git a/net-p2p/qbittorrent/qbittorrent-9999.ebuild b/net-p2p/qbittorrent/qbittorrent-9999.ebuild index c49dc5560c20..790d481629c6 100644 --- a/net-p2p/qbittorrent/qbittorrent-9999.ebuild +++ b/net-p2p/qbittorrent/qbittorrent-9999.ebuild @@ -29,7 +29,6 @@ RDEPEND=" >=dev-libs/openssl-1.1.1:= >=net-libs/libtorrent-rasterbar-1.2.19:= >=sys-libs/zlib-1.2.11 - virtual/libiconv gui? ( dev-libs/geoip !qt6? (