From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 93B2A158451 for ; Mon, 8 Jan 2024 16:43:04 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id C79EAE2BCB; Mon, 8 Jan 2024 16:43:03 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id A2B54E2BCB for ; Mon, 8 Jan 2024 16:43:03 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 7DBFB3431ED for ; Mon, 8 Jan 2024 16:43:02 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id E383995D for ; Mon, 8 Jan 2024 16:43:00 +0000 (UTC) From: "Ionen Wolkens" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Ionen Wolkens" Message-ID: <1704732111.f6c788b3553a3ad73bf999f19ce0ffb34a32e760.ionen@gentoo> Subject: [gentoo-commits] repo/gentoo:master commit in: dev-qt/qtwebengine/ X-VCS-Repository: repo/gentoo X-VCS-Files: dev-qt/qtwebengine/qtwebengine-6.6.1.ebuild dev-qt/qtwebengine/qtwebengine-6.6.9999.ebuild dev-qt/qtwebengine/qtwebengine-6.7.9999.ebuild dev-qt/qtwebengine/qtwebengine-6.9999.ebuild X-VCS-Directories: dev-qt/qtwebengine/ X-VCS-Committer: ionen X-VCS-Committer-Name: Ionen Wolkens X-VCS-Revision: f6c788b3553a3ad73bf999f19ce0ffb34a32e760 X-VCS-Branch: master Date: Mon, 8 Jan 2024 16:43:00 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 91f59cd1-118d-4b9d-a41d-46a1449c36ef X-Archives-Hash: 4416549b3ac45b08f0ca34b8e8d23c6c commit: f6c788b3553a3ad73bf999f19ce0ffb34a32e760 Author: Ionen Wolkens gentoo org> AuthorDate: Mon Jan 8 13:08:46 2024 +0000 Commit: Ionen Wolkens gentoo org> CommitDate: Mon Jan 8 16:41:51 2024 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f6c788b3 dev-qt/qtwebengine: do the install sanity-check from qt5 in qt6 too The check was removed before I touched these and didn't know it existed. Was fair to think it wouldn't be needed anymore with cmake but it is, e.g. it installs nothing if bison is not found without hard failure. File path is hopefully correct for Qt6, did give it two test builds (one "bad" that's empty, and one full build) just in case. Albeit haven't retried prefix (it's included in QT6_LIBDIR though). The qt6-build eclass does force fatal errors for a few "build nothing" cases, but not qtwebengine's custom ones. Kind of wonder if a similar end result file check should be done for all of dev-qt/* (aka fail if does not install anything but cmake files and docs). May revisit if Qt has more original ways to build nothing not limited to qtwebengine. Signed-off-by: Ionen Wolkens gentoo.org> dev-qt/qtwebengine/qtwebengine-6.6.1.ebuild | 7 +++++++ dev-qt/qtwebengine/qtwebengine-6.6.9999.ebuild | 7 +++++++ dev-qt/qtwebengine/qtwebengine-6.7.9999.ebuild | 7 +++++++ dev-qt/qtwebengine/qtwebengine-6.9999.ebuild | 7 +++++++ 4 files changed, 28 insertions(+) diff --git a/dev-qt/qtwebengine/qtwebengine-6.6.1.ebuild b/dev-qt/qtwebengine/qtwebengine-6.6.1.ebuild index 7557170168d7..52405bc44e44 100644 --- a/dev-qt/qtwebengine/qtwebengine-6.6.1.ebuild +++ b/dev-qt/qtwebengine/qtwebengine-6.6.1.ebuild @@ -281,6 +281,13 @@ src_test() { qt6-build_src_test -j1 } +src_install() { + qt6-build_src_install + + [[ -e ${D}${QT6_LIBDIR}/libQt6WebEngineCore.so ]] || #601472 + die "${CATEGORY}/${PF} failed to build anything. Please report to https://bugs.gentoo.org/" +} + pkg_postinst() { # plugin may also be found in $HOME if provided by chrome or firefox use amd64 && diff --git a/dev-qt/qtwebengine/qtwebengine-6.6.9999.ebuild b/dev-qt/qtwebengine/qtwebengine-6.6.9999.ebuild index 46450368b95d..a2fb38c98575 100644 --- a/dev-qt/qtwebengine/qtwebengine-6.6.9999.ebuild +++ b/dev-qt/qtwebengine/qtwebengine-6.6.9999.ebuild @@ -281,6 +281,13 @@ src_test() { qt6-build_src_test -j1 } +src_install() { + qt6-build_src_install + + [[ -e ${D}${QT6_LIBDIR}/libQt6WebEngineCore.so ]] || #601472 + die "${CATEGORY}/${PF} failed to build anything. Please report to https://bugs.gentoo.org/" +} + pkg_postinst() { # plugin may also be found in $HOME if provided by chrome or firefox use amd64 && diff --git a/dev-qt/qtwebengine/qtwebengine-6.7.9999.ebuild b/dev-qt/qtwebengine/qtwebengine-6.7.9999.ebuild index c5e7a9912cc0..e7cca530e966 100644 --- a/dev-qt/qtwebengine/qtwebengine-6.7.9999.ebuild +++ b/dev-qt/qtwebengine/qtwebengine-6.7.9999.ebuild @@ -281,6 +281,13 @@ src_test() { qt6-build_src_test -j1 } +src_install() { + qt6-build_src_install + + [[ -e ${D}${QT6_LIBDIR}/libQt6WebEngineCore.so ]] || #601472 + die "${CATEGORY}/${PF} failed to build anything. Please report to https://bugs.gentoo.org/" +} + pkg_postinst() { # plugin may also be found in $HOME if provided by chrome or firefox use amd64 && diff --git a/dev-qt/qtwebengine/qtwebengine-6.9999.ebuild b/dev-qt/qtwebengine/qtwebengine-6.9999.ebuild index c5e7a9912cc0..e7cca530e966 100644 --- a/dev-qt/qtwebengine/qtwebengine-6.9999.ebuild +++ b/dev-qt/qtwebengine/qtwebengine-6.9999.ebuild @@ -281,6 +281,13 @@ src_test() { qt6-build_src_test -j1 } +src_install() { + qt6-build_src_install + + [[ -e ${D}${QT6_LIBDIR}/libQt6WebEngineCore.so ]] || #601472 + die "${CATEGORY}/${PF} failed to build anything. Please report to https://bugs.gentoo.org/" +} + pkg_postinst() { # plugin may also be found in $HOME if provided by chrome or firefox use amd64 &&