From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id E9C52158099 for ; Fri, 1 Dec 2023 10:56:51 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 2D43B2BC014; Fri, 1 Dec 2023 10:56:51 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id DBA172BC014 for ; Fri, 1 Dec 2023 10:56:50 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id DC842335D6B for ; Fri, 1 Dec 2023 10:56:49 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 50B2DFB7 for ; Fri, 1 Dec 2023 10:56:48 +0000 (UTC) From: "Mike Pagano" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Mike Pagano" Message-ID: <1701428191.646f5f5f3b31729f900a5cd9da56e19951d42c75.mpagano@gentoo> Subject: [gentoo-commits] proj/linux-patches:5.15 commit in: / X-VCS-Repository: proj/linux-patches X-VCS-Files: 2010_Fix_randomize_layout_crash_in_struct_neigh.patch X-VCS-Directories: / X-VCS-Committer: mpagano X-VCS-Committer-Name: Mike Pagano X-VCS-Revision: 646f5f5f3b31729f900a5cd9da56e19951d42c75 X-VCS-Branch: 5.15 Date: Fri, 1 Dec 2023 10:56:48 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 59a4ef1c-3982-459e-acf9-8cc83427e3c7 X-Archives-Hash: c6ed049814ac4837ad7624398526873d commit: 646f5f5f3b31729f900a5cd9da56e19951d42c75 Author: Mike Pagano gentoo org> AuthorDate: Fri Dec 1 10:56:31 2023 +0000 Commit: Mike Pagano gentoo org> CommitDate: Fri Dec 1 10:56:31 2023 +0000 URL: https://gitweb.gentoo.org/proj/linux-patches.git/commit/?id=646f5f5f Fix up neighbour patch Signed-off-by: Mike Pagano gentoo.org> ...ix_randomize_layout_crash_in_struct_neigh.patch | 41 +++------------------- 1 file changed, 4 insertions(+), 37 deletions(-) diff --git a/2010_Fix_randomize_layout_crash_in_struct_neigh.patch b/2010_Fix_randomize_layout_crash_in_struct_neigh.patch index 8ee50b2f..23c790ea 100644 --- a/2010_Fix_randomize_layout_crash_in_struct_neigh.patch +++ b/2010_Fix_randomize_layout_crash_in_struct_neigh.patch @@ -1,44 +1,11 @@ -From 45b3fae4675dc1d4ee2d7aefa19d85ee4f891377 Mon Sep 17 00:00:00 2001 -From: "Gustavo A. R. Silva" -Date: Sat, 25 Nov 2023 15:33:58 -0600 -Subject: neighbour: Fix __randomize_layout crash in struct neighbour - -Previously, one-element and zero-length arrays were treated as true -flexible arrays, even though they are actually "fake" flex arrays. -The __randomize_layout would leave them untouched at the end of the -struct, similarly to proper C99 flex-array members. - -However, this approach changed with commit 1ee60356c2dc ("gcc-plugins: -randstruct: Only warn about true flexible arrays"). Now, only C99 -flexible-array members will remain untouched at the end of the struct, -while one-element and zero-length arrays will be subject to randomization. - -Fix a `__randomize_layout` crash in `struct neighbour` by transforming -zero-length array `primary_key` into a proper C99 flexible-array member. - -Fixes: 1ee60356c2dc ("gcc-plugins: randstruct: Only warn about true flexible arrays") -Closes: https://lore.kernel.org/linux-hardening/20231124102458.GB1503258@e124191.cambridge.arm.com/ -Signed-off-by: Gustavo A. R. Silva -Reviewed-by: Kees Cook -Tested-by: Joey Gouly -Link: https://lore.kernel.org/r/ZWJoRsJGnCPdJ3+2@work -Signed-off-by: Paolo Abeni ---- - include/net/neighbour.h | 2 +- - 1 file changed, 1 insertion(+), 1 deletion(-) - -diff --git a/include/net/neighbour.h b/include/net/neighbour.h -index 07022bb0d44d4b..0d28172193fa63 100644 ---- a/include/net/neighbour.h -+++ b/include/net/neighbour.h -@@ -162,7 +162,7 @@ struct neighbour { +--- a/include/net/neighbour.h 2023-12-01 05:54:45.041790265 -0500 ++++ b/include/net/neighbour.h 2023-12-01 05:55:23.751858231 -0500 +@@ -157,7 +157,7 @@ struct neighbour { + struct list_head gc_list; struct rcu_head rcu; struct net_device *dev; - netdevice_tracker dev_tracker; - u8 primary_key[0]; + u8 primary_key[]; } __randomize_layout; struct neigh_ops { --- -cgit