public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Sam James" <sam@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] proj/portage:master commit in: lib/portage/sync/modules/git/
Date: Sun, 22 Oct 2023 19:03:33 +0000 (UTC)	[thread overview]
Message-ID: <1698001172.c1977b8672d3af2abc5d7034fd30f35bfad76d38.sam@gentoo> (raw)

commit:     c1977b8672d3af2abc5d7034fd30f35bfad76d38
Author:     Florian Schmaus <flow <AT> gentoo <DOT> org>
AuthorDate: Sun Oct 22 08:58:42 2023 +0000
Commit:     Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Sun Oct 22 18:59:32 2023 +0000
URL:        https://gitweb.gentoo.org/proj/portage.git/commit/?id=c1977b86

sync: git: fetch/clone with --verbose if verbose is enabled

Invoking git fetch/clone with --verbose shows the URL of the remote,
which is viable information. Otherwise the user may believe that they
are using a different remote then they are actually using.

Signed-off-by: Florian Schmaus <flow <AT> gentoo.org>
Closes: https://github.com/gentoo/portage/pull/1143
Signed-off-by: Sam James <sam <AT> gentoo.org>

 lib/portage/sync/modules/git/git.py | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/lib/portage/sync/modules/git/git.py b/lib/portage/sync/modules/git/git.py
index 1914122d9d..24389ca02a 100644
--- a/lib/portage/sync/modules/git/git.py
+++ b/lib/portage/sync/modules/git/git.py
@@ -139,8 +139,12 @@ class GitSync(NewBase):
         """
         if not self.has_bin:
             return (1, False)
+
+        opts = self.options.get("emerge_config").opts
+
         git_cmd_opts = ""
         quiet = self.settings.get("PORTAGE_QUIET") == "1"
+        verbose = "--verbose" in opts
 
         # We don't want to operate with a .git outside of the given
         # repo in any circumstances.
@@ -170,6 +174,8 @@ class GitSync(NewBase):
 
         if quiet:
             git_cmd_opts += " --quiet"
+        elif verbose:
+            git_cmd_opts += " --verbose"
 
         # The logic here is a bit delicate. We need to balance two things:
         # 1. Having a robust sync mechanism which works unattended.


             reply	other threads:[~2023-10-22 19:03 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-22 19:03 Sam James [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-05-12 16:20 [gentoo-commits] proj/portage:master commit in: lib/portage/sync/modules/git/ Sam James
2023-12-14  4:30 Sam James
2023-10-31  0:35 Sam James
2023-10-22 19:03 Sam James
2023-10-22 19:03 Sam James
2023-08-17  6:59 Sam James
2023-08-17  6:53 Sam James
2023-02-27  6:15 Sam James
2023-02-25 23:22 Sam James
2023-02-24  9:22 Sam James
2023-02-24  9:22 Sam James
2023-02-24  9:22 Sam James
2022-12-21  1:28 Sam James
2022-12-21  1:28 Sam James
2022-12-21  1:28 Sam James
2022-11-20  3:12 Sam James
2022-07-03  0:56 Mike Gilbert
2020-07-02 22:08 Zac Medico
2018-07-23 19:58 Zac Medico
2018-07-23 18:52 Zac Medico

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1698001172.c1977b8672d3af2abc5d7034fd30f35bfad76d38.sam@gentoo \
    --to=sam@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox