From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <gentoo-commits+bounces-1556740-garchives=archives.gentoo.org@lists.gentoo.org> Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 1C5DC158089 for <garchives@archives.gentoo.org>; Sat, 23 Sep 2023 12:26:26 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 5CAD32BC01B; Sat, 23 Sep 2023 12:26:25 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 434DC2BC01B for <gentoo-commits@lists.gentoo.org>; Sat, 23 Sep 2023 12:26:25 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 7AD6933DF47 for <gentoo-commits@lists.gentoo.org>; Sat, 23 Sep 2023 12:26:24 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id BF60711BC for <gentoo-commits@lists.gentoo.org>; Sat, 23 Sep 2023 12:26:22 +0000 (UTC) From: "Sam James" <sam@gentoo.org> To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Sam James" <sam@gentoo.org> Message-ID: <1695471689.c92086906ae712ffe5cd5dde9ad470f3950695d8.sam@gentoo> Subject: [gentoo-commits] proj/crossdev:master commit in: / X-VCS-Repository: proj/crossdev X-VCS-Files: crossdev X-VCS-Directories: / X-VCS-Committer: sam X-VCS-Committer-Name: Sam James X-VCS-Revision: c92086906ae712ffe5cd5dde9ad470f3950695d8 X-VCS-Branch: master Date: Sat, 23 Sep 2023 12:26:22 +0000 (UTC) Precedence: bulk List-Post: <mailto:gentoo-commits@lists.gentoo.org> List-Help: <mailto:gentoo-commits+help@lists.gentoo.org> List-Unsubscribe: <mailto:gentoo-commits+unsubscribe@lists.gentoo.org> List-Subscribe: <mailto:gentoo-commits+subscribe@lists.gentoo.org> List-Id: Gentoo Linux mail <gentoo-commits.gentoo.org> X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 064e67a3-e544-4f92-8299-102f89fd52de X-Archives-Hash: fa0f3d5b18a763773abf97a4fb3bebad commit: c92086906ae712ffe5cd5dde9ad470f3950695d8 Author: Benjamin Gilbert <bgilbert <AT> backtick <DOT> net> AuthorDate: Sat Sep 23 11:09:50 2023 +0000 Commit: Sam James <sam <AT> gentoo <DOT> org> CommitDate: Sat Sep 23 12:21:29 2023 +0000 URL: https://gitweb.gentoo.org/proj/crossdev.git/commit/?id=c9208690 Fix check for installed LLVM It always succeeds, and then if LLVM isn't installed, crossdev fails with a confusing error: Target architecture not supported by installed LLVM toolchain Signed-off-by: Benjamin Gilbert <bgilbert <AT> backtick.net> Closes: https://github.com/gentoo/crossdev/pull/14 Signed-off-by: Sam James <sam <AT> gentoo.org> crossdev | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crossdev b/crossdev index b84b757..f6ad232 100755 --- a/crossdev +++ b/crossdev @@ -1722,7 +1722,7 @@ if ! ex_fast ; then # stage 0: binutils if [[ "${LLVM}" == "yes" ]] ; then - if [[ $(portageq has_version / "sys-devel/llvm") -ne 0 ]] ; then + if ! portageq has_version / "sys-devel/llvm" ; then eerror "LLVM is not installed" exit 1 fi