From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <gentoo-commits+bounces-1548468-garchives=archives.gentoo.org@lists.gentoo.org> Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id F0FE715800A for <garchives@archives.gentoo.org>; Tue, 22 Aug 2023 06:03:40 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 435742BC013; Tue, 22 Aug 2023 06:03:40 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 28F8B2BC013 for <gentoo-commits@lists.gentoo.org>; Tue, 22 Aug 2023 06:03:40 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 0CF9234122C for <gentoo-commits@lists.gentoo.org>; Tue, 22 Aug 2023 06:03:39 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 44ED71045 for <gentoo-commits@lists.gentoo.org>; Tue, 22 Aug 2023 06:03:37 +0000 (UTC) From: "Ulrich Müller" <ulm@gentoo.org> To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Ulrich Müller" <ulm@gentoo.org> Message-ID: <1692684196.29978d077d271058b31a4578617880013448093d.ulm@gentoo> Subject: [gentoo-commits] proj/devmanual:master commit in: general-concepts/use-flags/ X-VCS-Repository: proj/devmanual X-VCS-Files: general-concepts/use-flags/text.xml X-VCS-Directories: general-concepts/use-flags/ X-VCS-Committer: ulm X-VCS-Committer-Name: Ulrich Müller X-VCS-Revision: 29978d077d271058b31a4578617880013448093d X-VCS-Branch: master Date: Tue, 22 Aug 2023 06:03:37 +0000 (UTC) Precedence: bulk List-Post: <mailto:gentoo-commits@lists.gentoo.org> List-Help: <mailto:gentoo-commits+help@lists.gentoo.org> List-Unsubscribe: <mailto:gentoo-commits+unsubscribe@lists.gentoo.org> List-Subscribe: <mailto:gentoo-commits+subscribe@lists.gentoo.org> List-Id: Gentoo Linux mail <gentoo-commits.gentoo.org> X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 703dcd47-f0ff-4011-96dc-3af5d976bc64 X-Archives-Hash: 54d099b090d989733a765476fcf09485 commit: 29978d077d271058b31a4578617880013448093d Author: Jonas Frei <freijon <AT> pm <DOT> me> AuthorDate: Tue Aug 22 03:17:10 2023 +0000 Commit: Ulrich Müller <ulm <AT> gentoo <DOT> org> CommitDate: Tue Aug 22 06:03:16 2023 +0000 URL: https://gitweb.gentoo.org/proj/devmanual.git/commit/?id=29978d07 general-concepts/use-flags: Clarification about compiler flags Signed-off-by: Jonas Frei <freijon <AT> pm.me> [Whitespace fixed.] Signed-off-by: Ulrich Müller <ulm <AT> gentoo.org> general-concepts/use-flags/text.xml | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/general-concepts/use-flags/text.xml b/general-concepts/use-flags/text.xml index 7d0047a..5caa430 100644 --- a/general-concepts/use-flags/text.xml +++ b/general-concepts/use-flags/text.xml @@ -82,10 +82,10 @@ instead, or controlled by a flag such as <c>minimal</c>. </p> <p> -You should not introduce USE flags that merely manipulate <c>CFLAGS</c>, -<c>FEATURES</c> or similar variables configured directly by the user. Instead, -packages should avoid manipulating them at all, and let users set them directly. -Common mistakes include: +You should not introduce USE flags that manipulate compiler flags or similar +variables configured directly by the user (e.g. <c>-O3</c>, <c>-flto</c>). +Instead, packages should avoid manipulating them at all, and let users set +them directly. Common mistakes include: </p> <ol> @@ -114,7 +114,8 @@ There might be corner cases where these rules do not apply. For example, a few upstreams require users to use specific <c>CFLAGS</c> and reject bug reports against builds using other values. In this case, it is customary to strip flags by default and provide <c>custom-cflags</c> flag to allow users to force their -preferred flags. +preferred flags. Another exception are <c>CFLAGS</c> that enable/disable +features at compile time (via pre-processor macros). </p> </body> </section>