From: "Ulrich Müller" <ulm@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] proj/devmanual:master commit in: general-concepts/use-flags/
Date: Tue, 22 Aug 2023 06:03:37 +0000 (UTC) [thread overview]
Message-ID: <1692684196.29978d077d271058b31a4578617880013448093d.ulm@gentoo> (raw)
commit: 29978d077d271058b31a4578617880013448093d
Author: Jonas Frei <freijon <AT> pm <DOT> me>
AuthorDate: Tue Aug 22 03:17:10 2023 +0000
Commit: Ulrich Müller <ulm <AT> gentoo <DOT> org>
CommitDate: Tue Aug 22 06:03:16 2023 +0000
URL: https://gitweb.gentoo.org/proj/devmanual.git/commit/?id=29978d07
general-concepts/use-flags: Clarification about compiler flags
Signed-off-by: Jonas Frei <freijon <AT> pm.me>
[Whitespace fixed.]
Signed-off-by: Ulrich Müller <ulm <AT> gentoo.org>
general-concepts/use-flags/text.xml | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/general-concepts/use-flags/text.xml b/general-concepts/use-flags/text.xml
index 7d0047a..5caa430 100644
--- a/general-concepts/use-flags/text.xml
+++ b/general-concepts/use-flags/text.xml
@@ -82,10 +82,10 @@ instead, or controlled by a flag such as <c>minimal</c>.
</p>
<p>
-You should not introduce USE flags that merely manipulate <c>CFLAGS</c>,
-<c>FEATURES</c> or similar variables configured directly by the user. Instead,
-packages should avoid manipulating them at all, and let users set them directly.
-Common mistakes include:
+You should not introduce USE flags that manipulate compiler flags or similar
+variables configured directly by the user (e.g. <c>-O3</c>, <c>-flto</c>).
+Instead, packages should avoid manipulating them at all, and let users set
+them directly. Common mistakes include:
</p>
<ol>
@@ -114,7 +114,8 @@ There might be corner cases where these rules do not apply. For example, a few
upstreams require users to use specific <c>CFLAGS</c> and reject bug reports
against builds using other values. In this case, it is customary to strip flags
by default and provide <c>custom-cflags</c> flag to allow users to force their
-preferred flags.
+preferred flags. Another exception are <c>CFLAGS</c> that enable/disable
+features at compile time (via pre-processor macros).
</p>
</body>
</section>
next reply other threads:[~2023-08-22 6:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 6:03 Ulrich Müller [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-12-09 18:29 [gentoo-commits] proj/devmanual:master commit in: general-concepts/use-flags/ Ulrich Müller
2022-02-21 21:40 Sam James
2021-08-01 2:13 Sam James
2021-08-01 2:08 Sam James
2021-04-10 7:03 Ulrich Müller
2021-04-10 7:03 Ulrich Müller
2021-04-10 7:03 Ulrich Müller
2021-04-02 7:00 Ulrich Müller
2019-05-24 8:40 Ulrich Müller
2019-05-22 19:37 Göktürk Yüksek
2019-05-22 19:37 Göktürk Yüksek
2019-05-22 19:37 Göktürk Yüksek
2019-05-22 19:37 Göktürk Yüksek
2019-05-22 19:37 Göktürk Yüksek
2018-06-22 18:25 Ulrich Müller
2014-04-06 15:51 Markos Chandras
2012-04-05 14:22 Torsten Veller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1692684196.29978d077d271058b31a4578617880013448093d.ulm@gentoo \
--to=ulm@gentoo.org \
--cc=gentoo-commits@lists.gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox