From: "Sam James" <sam@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: media-libs/speex/, media-libs/speex/files/
Date: Tue, 16 May 2023 03:56:39 +0000 (UTC) [thread overview]
Message-ID: <1684209313.f6baa20f72862687508e23181f49972f8e428a50.sam@gentoo> (raw)
commit: f6baa20f72862687508e23181f49972f8e428a50
Author: Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Tue May 16 03:55:13 2023 +0000
Commit: Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Tue May 16 03:55:13 2023 +0000
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f6baa20f
media-libs/speex: fix valgrind build
Closes: https://bugs.gentoo.org/906455
Thanks-to: Andrei Slavoiu <ansla80 <AT> yahoo.com>
Signed-off-by: Sam James <sam <AT> gentoo.org>
media-libs/speex/files/speex-1.2.1-valgrind.patch | 53 +++++++++++++++++++++++
media-libs/speex/speex-1.2.1-r1.ebuild | 1 +
media-libs/speex/speex-1.2.1.ebuild | 5 ++-
3 files changed, 58 insertions(+), 1 deletion(-)
diff --git a/media-libs/speex/files/speex-1.2.1-valgrind.patch b/media-libs/speex/files/speex-1.2.1-valgrind.patch
new file mode 100644
index 000000000000..a9fd9789a127
--- /dev/null
+++ b/media-libs/speex/files/speex-1.2.1-valgrind.patch
@@ -0,0 +1,53 @@
+https://gitlab.xiph.org/xiph/speex/-/merge_requests/13
+
+From b15993fd560c90658ff2e4974e8b3a1afcfcfff2 Mon Sep 17 00:00:00 2001
+From: Andrei Slavoiu <ansla80@yahoo.com>
+Date: Tue, 16 May 2023 04:49:45 +0100
+Subject: [PATCH] Fix --enable-valgrind build
+
+VALGRIND_MAKE_READABLE has been replaced with VALGRIND_MAKE_MEM_DEFINED
+starting with version 3.2 (2006) https://valgrind.org/docs/manual/dist.news.old.html.
+
+Bug: https://bugs.gentoo.org/906455
+--- a/libspeex/nb_celp.c
++++ b/libspeex/nb_celp.c
+@@ -172,7 +172,7 @@ void *nb_encoder_init(const SpeexMode *m)
+ st->highpass_enabled = 1;
+
+ #ifdef ENABLE_VALGRIND
+- VALGRIND_MAKE_READABLE(st, NB_ENC_STACK);
++ VALGRIND_MAKE_MEM_DEFINED(st, NB_ENC_STACK);
+ #endif
+ return st;
+ }
+@@ -1113,7 +1113,7 @@ void *nb_decoder_init(const SpeexMode *m)
+ st->highpass_enabled = 1;
+
+ #ifdef ENABLE_VALGRIND
+- VALGRIND_MAKE_READABLE(st, NB_DEC_STACK);
++ VALGRIND_MAKE_MEM_DEFINED(st, NB_DEC_STACK);
+ #endif
+ return st;
+ }
+--- a/libspeex/sb_celp.c
++++ b/libspeex/sb_celp.c
+@@ -223,7 +223,7 @@ void *sb_encoder_init(const SpeexMode *m)
+ speex_encoder_ctl(st->st_low, SPEEX_GET_SAMPLING_RATE, &st->sampling_rate);
+ st->sampling_rate*=2;
+ #ifdef ENABLE_VALGRIND
+- VALGRIND_MAKE_READABLE(st, (st->stack-(char*)st));
++ VALGRIND_MAKE_MEM_DEFINED(st, (st->stack-(char*)st));
+ #endif
+ return st;
+ }
+@@ -1017,7 +1017,7 @@ void *sb_decoder_init(const SpeexMode *m)
+ st->seed = 1000;
+
+ #ifdef ENABLE_VALGRIND
+- VALGRIND_MAKE_READABLE(st, (st->stack-(char*)st));
++ VALGRIND_MAKE_MEM_DEFINED(st, (st->stack-(char*)st));
+ #endif
+ return st;
+ }
+--
+GitLab
diff --git a/media-libs/speex/speex-1.2.1-r1.ebuild b/media-libs/speex/speex-1.2.1-r1.ebuild
index c966d61c2a6e..f84f46069fda 100644
--- a/media-libs/speex/speex-1.2.1-r1.ebuild
+++ b/media-libs/speex/speex-1.2.1-r1.ebuild
@@ -33,6 +33,7 @@ S="${WORKDIR}/${MY_P}"
PATCHES=(
"${FILESDIR}"/${PN}-1.2.0-configure.patch
"${FILESDIR}"/${P}-vla-detection.patch
+ "${FILESDIR}"/${PN}-1.2.1-valgrind.patch
)
src_prepare() {
diff --git a/media-libs/speex/speex-1.2.1.ebuild b/media-libs/speex/speex-1.2.1.ebuild
index eecc7ebf0031..a79308db25b2 100644
--- a/media-libs/speex/speex-1.2.1.ebuild
+++ b/media-libs/speex/speex-1.2.1.ebuild
@@ -30,7 +30,10 @@ BDEPEND="virtual/pkgconfig"
S="${WORKDIR}/${MY_P}"
-PATCHES=( "${FILESDIR}"/${PN}-1.2.0-configure.patch )
+PATCHES=(
+ "${FILESDIR}"/${PN}-1.2.0-configure.patch
+ "${FILESDIR}"/${PN}-1.2.1-valgrind.patch
+)
src_prepare() {
default
next reply other threads:[~2023-05-16 3:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-16 3:56 Sam James [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-12-13 9:35 [gentoo-commits] repo/gentoo:master commit in: media-libs/speex/, media-libs/speex/files/ Sam James
2023-05-15 6:47 Sam James
2017-03-03 23:11 Michael Palimaka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1684209313.f6baa20f72862687508e23181f49972f8e428a50.sam@gentoo \
--to=sam@gentoo.org \
--cc=gentoo-commits@lists.gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox