[gentoo-commits] repo/gentoo:master commit in: media-libs/vigra/

["Sam James" <sam@gentoo.org>]

commit:     031e152dafaa74c07068f677c853b71b5f350ec1
Author:     Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Sun May 14 00:19:34 2023 +0000
Commit:     Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Sun May 14 00:31:22 2023 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=031e152d

media-libs/vigra: drop invalid USE=valgrind flag (for test suite)

We don't, in general, run Valgrind for test suites in Gentoo because it's
not portable enough and gives inconsistent results, especially under sandbox.

Plus it's confusing given USE=valgrind is effectively a global USE flag (even
if it isn't in use.desc yet) for meaning "enable annotations to enable better
debugging under Valgrind", rather than "run tests under it".

Signed-off-by: Sam James <sam <AT> gentoo.org>

 media-libs/vigra/metadata.xml           | 3 ---
 media-libs/vigra/vigra-1.11.1-r8.ebuild | 5 ++---
 media-libs/vigra/vigra-1.11.1-r9.ebuild | 5 ++---
 media-libs/vigra/vigra-9999.ebuild      | 5 ++---
 4 files changed, 6 insertions(+), 12 deletions(-)

diff --git a/media-libs/vigra/metadata.xml b/media-libs/vigra/metadata.xml
index 14449893ddbe..42f024b353cf 100644
--- a/media-libs/vigra/metadata.xml
+++ b/media-libs/vigra/metadata.xml
@@ -5,9 +5,6 @@
 		<email>printing@gentoo.org</email>
 		<name>Gentoo Printing Project</name>
 	</maintainer>
-	<use>
-		<flag name="valgrind">Enable valgrind in make check</flag>
-	</use>
 	<upstream>
 		<remote-id type="github">ukoethe/vigra</remote-id>
 	</upstream>

diff --git a/media-libs/vigra/vigra-1.11.1-r8.ebuild b/media-libs/vigra/vigra-1.11.1-r8.ebuild
index 2c819e907573..8e05bebbabd4 100644
--- a/media-libs/vigra/vigra-1.11.1-r8.ebuild
+++ b/media-libs/vigra/vigra-1.11.1-r8.ebuild
@@ -20,7 +20,7 @@ fi
 
 LICENSE="MIT"
 SLOT="0"
-IUSE="doc +fftw +hdf5 +jpeg mpi openexr +png +python test +tiff valgrind +zlib"
+IUSE="doc +fftw +hdf5 +jpeg mpi openexr +png +python test +tiff +zlib"
 
 REQUIRED_USE="
 	python? ( hdf5 ${PYTHON_REQUIRED_USE} )
@@ -29,7 +29,6 @@ REQUIRED_USE="
 BDEPEND="
 	test? (
 		>=dev-python/nose-1.1.2-r1[${PYTHON_USEDEP}]
-		valgrind? ( dev-util/valgrind )
 	)
 "
 # runtime dependency on python is required by the vigra-config script
@@ -113,7 +112,7 @@ src_configure() {
 			-DDOCINSTALL="share/doc/${PF}/html"
 			-DWITH_HDF5=$(usex hdf5)
 			-DWITH_OPENEXR=$(usex openexr)
-			-DWITH_VALGRIND=$(usex valgrind)
+			-DWITH_VALGRIND=OFF # only used for tests
 			-DWITH_VIGRANUMPY=$(usex python)
 		)
 		cmake_src_configure

diff --git a/media-libs/vigra/vigra-1.11.1-r9.ebuild b/media-libs/vigra/vigra-1.11.1-r9.ebuild
index beb3622e9ca0..ef5236cfe1b7 100644
--- a/media-libs/vigra/vigra-1.11.1-r9.ebuild
+++ b/media-libs/vigra/vigra-1.11.1-r9.ebuild
@@ -20,7 +20,7 @@ fi
 
 LICENSE="MIT"
 SLOT="0"
-IUSE="doc +fftw +hdf5 +jpeg mpi openexr +png +python test +tiff valgrind +zlib"
+IUSE="doc +fftw +hdf5 +jpeg mpi openexr +png +python test +tiff +zlib"
 
 REQUIRED_USE="
 	python? ( hdf5 ${PYTHON_REQUIRED_USE} )
@@ -29,7 +29,6 @@ REQUIRED_USE="
 BDEPEND="
 	test? (
 		>=dev-python/nose-1.1.2-r1[${PYTHON_USEDEP}]
-		valgrind? ( dev-util/valgrind )
 	)
 "
 # runtime dependency on python is required by the vigra-config script
@@ -114,7 +113,7 @@ src_configure() {
 			-DDOCINSTALL="share/doc/${PF}/html"
 			-DWITH_HDF5=$(usex hdf5)
 			-DWITH_OPENEXR=$(usex openexr)
-			-DWITH_VALGRIND=$(usex valgrind)
+			-DWITH_VALGRIND=OFF # only used for tests
 			-DWITH_VIGRANUMPY=$(usex python)
 		)
 		cmake_src_configure

diff --git a/media-libs/vigra/vigra-9999.ebuild b/media-libs/vigra/vigra-9999.ebuild
index 9d414e9529c7..5a2feab44ca9 100644
--- a/media-libs/vigra/vigra-9999.ebuild
+++ b/media-libs/vigra/vigra-9999.ebuild
@@ -20,7 +20,7 @@ fi
 
 LICENSE="MIT"
 SLOT="0"
-IUSE="doc +fftw +hdf5 +jpeg mpi openexr +png +python test +tiff valgrind +zlib"
+IUSE="doc +fftw +hdf5 +jpeg mpi openexr +png +python test +tiff +zlib"
 
 REQUIRED_USE="
 	python? ( hdf5 ${PYTHON_REQUIRED_USE} )
@@ -29,7 +29,6 @@ REQUIRED_USE="
 BDEPEND="
 	test? (
 		>=dev-python/nose-1.1.2-r1[${PYTHON_USEDEP}]
-		valgrind? ( dev-util/valgrind )
 	)
 "
 # runtime dependency on python is required by the vigra-config script
@@ -107,7 +106,7 @@ src_configure() {
 			-DDOCINSTALL="share/doc/${PF}/html"
 			-DWITH_HDF5=$(usex hdf5)
 			-DWITH_OPENEXR=$(usex openexr)
-			-DWITH_VALGRIND=$(usex valgrind)
+			-DWITH_VALGRIND=OFF # only used for tests
 			-DWITH_VIGRANUMPY=$(usex python)
 		)
 		cmake_src_configure