From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gentoo-commits+bounces-1506368-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits))
	(No client certificate requested)
	by finch.gentoo.org (Postfix) with ESMTPS id EA02415ACFB
	for <garchives@archives.gentoo.org>; Mon, 10 Apr 2023 07:18:37 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id 3812AE084F;
	Mon, 10 Apr 2023 07:18:37 +0000 (UTC)
Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits))
	(No client certificate requested)
	by pigeon.gentoo.org (Postfix) with ESMTPS id 1FE0AE084F
	for <gentoo-commits@lists.gentoo.org>; Mon, 10 Apr 2023 07:18:37 +0000 (UTC)
Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits))
	(No client certificate requested)
	by smtp.gentoo.org (Postfix) with ESMTPS id 5392333BEF5
	for <gentoo-commits@lists.gentoo.org>; Mon, 10 Apr 2023 07:18:36 +0000 (UTC)
Received: from localhost.localdomain (localhost [IPv6:::1])
	by oystercatcher.gentoo.org (Postfix) with ESMTP id C60CAA3A
	for <gentoo-commits@lists.gentoo.org>; Mon, 10 Apr 2023 07:18:34 +0000 (UTC)
From: "Ulrich Müller" <ulm@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Content-Transfer-Encoding: 8bit
Content-type: text/plain; charset=UTF-8
Reply-To: gentoo-dev@lists.gentoo.org, "Ulrich Müller" <ulm@gentoo.org>
Message-ID: <1681111030.6a3293622a5bc481c0cd4ca74d480632b681c563.ulm@gentoo>
Subject: [gentoo-commits] proj/pms:eapi-9 commit in: /
X-VCS-Repository: proj/pms
X-VCS-Files: eapi-differences.tex profiles.tex
X-VCS-Directories: /
X-VCS-Committer: ulm
X-VCS-Committer-Name: Ulrich Müller
X-VCS-Revision: 6a3293622a5bc481c0cd4ca74d480632b681c563
X-VCS-Branch: eapi-9
Date: Mon, 10 Apr 2023 07:18:34 +0000 (UTC)
Precedence: bulk
List-Post: <mailto:gentoo-commits@lists.gentoo.org>
List-Help: <mailto:gentoo-commits+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-commits+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-commits+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-commits.gentoo.org>
X-BeenThere: gentoo-commits@lists.gentoo.org
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
X-Archives-Salt: ed1b8612-4bf3-4d01-b318-39444551f5d2
X-Archives-Hash: a24120c4131321ed7adb3ef6b7edb4c3

commit:     6a3293622a5bc481c0cd4ca74d480632b681c563
Author:     Ulrich Müller <ulm <AT> gentoo <DOT> org>
AuthorDate: Mon Feb 21 18:30:11 2022 +0000
Commit:     Ulrich Müller <ulm <AT> gentoo <DOT> org>
CommitDate: Mon Apr 10 07:17:10 2023 +0000
URL:        https://gitweb.gentoo.org/proj/pms.git/commit/?id=6a329362

EAPI 9 profile parent files can contain comments

Bug: https://bugs.gentoo.org/470094
Signed-off-by: Ulrich Müller <ulm <AT> gentoo.org>

 eapi-differences.tex |  5 ++++-
 profiles.tex         | 20 +++++++++++++++++++-
 2 files changed, 23 insertions(+), 2 deletions(-)

diff --git a/eapi-differences.tex b/eapi-differences.tex
index 2df5361..79b3931 100644
--- a/eapi-differences.tex
+++ b/eapi-differences.tex
@@ -32,6 +32,9 @@ have identical entries for all listed EAPIs.}
 Less strict filenames in \t{updates} & \compactfeatureref{updates-filenames} &
     No & No & Yes & Yes \\
 
+Comments in profiles \t{parent} file & \compactfeatureref{parent-comments} &
+    No & No & No & Yes \\
+
 Profile files as directories & \compactfeatureref{profile-file-dirs} &
     No & Yes & Yes & Yes \\
 
@@ -352,7 +355,7 @@ EAPI 8 is EAPI 7 with the following changes:
 EAPI 9 is EAPI 8 with the following changes:
 
 \begin{compactitem}
-\item None
+\item Comments in profiles \t{parent} file, \featureref{parent-comments}.
 \end{compactitem}
 
 \ChangeWhenAddingAnEAPI{9}

diff --git a/profiles.tex b/profiles.tex
index 8d8226a..6fa8a1c 100644
--- a/profiles.tex
+++ b/profiles.tex
@@ -25,7 +25,25 @@ first, left to right, with duplicate parent paths being sourced for every time t
 It is illegal for a profile's parent tree to contain cycles. Package manager behaviour upon
 encountering a cycle is undefined.
 
-This file must not contain comments, blank lines or make use of line continuations.
+This file must not make use of line continuations.
+
+\featurelabel{parent-comments} For EAPIs listed in table~\ref{tab:profile-parent-comments} as
+allowing comments, blank lines and lines beginning with a \t{\#} are discarded. For other EAPIs,
+this file must not contain comments or blank lines.
+
+\ChangeWhenAddingAnEAPI{9}
+\begin{centertable}{EAPIs allowing comments in \t{parent} file}
+    \label{tab:profile-parent-comments}
+    \begin{tabular}{ll}
+      \toprule
+      \multicolumn{1}{c}{\textbf{EAPI}} &
+      \multicolumn{1}{c}{\textbf{Allows comments?}} \\
+      \midrule
+      0, 1, 2, 3, 4, 5, 6, 7, 8 & No  \\
+      9                         & Yes \\
+      \bottomrule
+    \end{tabular}
+\end{centertable}
 
 \subsection{The eapi file}
 \label{sec:profile-eapi}