From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 39EA41586A0 for ; Sun, 26 Mar 2023 12:28:46 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 39AD4E07E0; Sun, 26 Mar 2023 12:28:45 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 12371E07E0 for ; Sun, 26 Mar 2023 12:28:45 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 0CAC93411F7 for ; Sun, 26 Mar 2023 12:28:44 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 2C6E795B for ; Sun, 26 Mar 2023 12:28:42 +0000 (UTC) From: "Andreas Sturmlechner" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Andreas Sturmlechner" Message-ID: <1679833674.e73c0e589e11913b9a6f15e9e4186af48359d885.asturm@gentoo> Subject: [gentoo-commits] proj/qt:master commit in: eclass/ X-VCS-Repository: proj/qt X-VCS-Files: eclass/qt5-build.eclass X-VCS-Directories: eclass/ X-VCS-Committer: asturm X-VCS-Committer-Name: Andreas Sturmlechner X-VCS-Revision: e73c0e589e11913b9a6f15e9e4186af48359d885 X-VCS-Branch: master Date: Sun, 26 Mar 2023 12:28:42 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 4aad934a-b29e-4e4a-b938-62943393734e X-Archives-Hash: bc7f9af9ed6eda92331a28d04511d18b commit: e73c0e589e11913b9a6f15e9e4186af48359d885 Author: Ulrich Müller gentoo org> AuthorDate: Thu Mar 23 16:40:00 2023 +0000 Commit: Andreas Sturmlechner gentoo org> CommitDate: Sun Mar 26 12:27:54 2023 +0000 URL: https://gitweb.gentoo.org/proj/qt.git/commit/?id=e73c0e58 qt5-build.eclass: Quote argument of ":" command This avoids globbing, see: https://www.shellcheck.net/wiki/SC2223 Signed-off-by: Ulrich Müller gentoo.org> Signed-off-by: Andreas Sturmlechner gentoo.org> eclass/qt5-build.eclass | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/eclass/qt5-build.eclass b/eclass/qt5-build.eclass index ae74c2e0..25499b0c 100644 --- a/eclass/qt5-build.eclass +++ b/eclass/qt5-build.eclass @@ -51,7 +51,7 @@ readonly QT5_BUILD_TYPE # @DESCRIPTION: # The upstream name of the module this package belongs to. Used for # SRC_URI and EGIT_REPO_URI. Must be set before inheriting the eclass. -: ${QT5_MODULE:=${PN}} +: "${QT5_MODULE:=${PN}}" # @ECLASS_VARIABLE: QT5_PV # @DESCRIPTION: @@ -100,7 +100,7 @@ readonly QT5_PV # For proper description see virtualx.eclass man page. # Here we redefine default value to be manual, if your package needs virtualx # for tests you should proceed with setting VIRTUALX_REQUIRED=test. -: ${VIRTUALX_REQUIRED:=manual} +: "${VIRTUALX_REQUIRED:=manual}" inherit estack flag-o-matic toolchain-funcs virtualx @@ -140,7 +140,7 @@ fi # @OUTPUT_VARIABLE # @DESCRIPTION: # Build directory for out-of-source builds. -: ${QT5_BUILD_DIR:=${S}_build} +: "${QT5_BUILD_DIR:=${S}_build}" LICENSE="|| ( GPL-2 GPL-3 LGPL-3 ) FDL-1.3"