From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 3290A15864F for ; Sun, 26 Mar 2023 12:11:23 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 7C10DE07F0; Sun, 26 Mar 2023 12:11:22 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 46789E07F0 for ; Sun, 26 Mar 2023 12:11:22 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 4B8243411EA for ; Sun, 26 Mar 2023 12:11:21 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 0F31195A for ; Sun, 26 Mar 2023 12:11:19 +0000 (UTC) From: "Andreas Sturmlechner" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Andreas Sturmlechner" Message-ID: <1679832660.a32a7a70e9120a1f14d51e4f2795b02ff9fa4c76.asturm@gentoo> Subject: [gentoo-commits] proj/kde:master commit in: eclass/ X-VCS-Repository: proj/kde X-VCS-Files: eclass/ecm.eclass X-VCS-Directories: eclass/ X-VCS-Committer: asturm X-VCS-Committer-Name: Andreas Sturmlechner X-VCS-Revision: a32a7a70e9120a1f14d51e4f2795b02ff9fa4c76 X-VCS-Branch: master Date: Sun, 26 Mar 2023 12:11:19 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 9c2ad748-4cff-4598-968c-6935130d4535 X-Archives-Hash: 0e703bdbd2790dfc74ced450b23d4d68 commit: a32a7a70e9120a1f14d51e4f2795b02ff9fa4c76 Author: Ulrich Müller gentoo org> AuthorDate: Thu Mar 23 16:39:30 2023 +0000 Commit: Andreas Sturmlechner gentoo org> CommitDate: Sun Mar 26 12:11:00 2023 +0000 URL: https://gitweb.gentoo.org/proj/kde.git/commit/?id=a32a7a70 ecm.eclass: Quote argument of ":" command This avoids globbing, see: https://www.shellcheck.net/wiki/SC2223 Signed-off-by: Ulrich Müller gentoo.org> Signed-off-by: Andreas Sturmlechner gentoo.org> eclass/ecm.eclass | 34 +++++++++++++++++----------------- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/eclass/ecm.eclass b/eclass/ecm.eclass index 5d4ec3c7f2..139be799fe 100644 --- a/eclass/ecm.eclass +++ b/eclass/ecm.eclass @@ -34,7 +34,7 @@ _ECM_ECLASS=1 # For proper description see virtualx.eclass manpage. # Here we redefine default value to be manual, if your package needs virtualx # for tests you should proceed with setting VIRTUALX_REQUIRED=test. -: ${VIRTUALX_REQUIRED:=manual} +: "${VIRTUALX_REQUIRED:=manual}" inherit cmake flag-o-matic toolchain-funcs virtualx @@ -46,9 +46,9 @@ inherit cmake flag-o-matic toolchain-funcs virtualx # kde-frameworks/oxygen-icons and run the xdg.eclass routines for pkg_preinst, # pkg_postinst and pkg_postrm. If set to "true", do nothing. if [[ ${CATEGORY} = kde-frameworks ]] ; then - : ${ECM_NONGUI:=true} + : "${ECM_NONGUI:=true}" fi -: ${ECM_NONGUI:=false} +: "${ECM_NONGUI:=false}" if [[ ${ECM_NONGUI} = false ]] ; then inherit xdg @@ -58,25 +58,25 @@ fi # @DESCRIPTION: # Assume the package is using KDEInstallDirs macro and switch # KDE_INSTALL_USE_QT_SYS_PATHS to ON. If set to "false", do nothing. -: ${ECM_KDEINSTALLDIRS:=true} +: "${ECM_KDEINSTALLDIRS:=true}" # @ECLASS_VARIABLE: ECM_DEBUG # @DESCRIPTION: # Add "debug" to IUSE. If !debug, add -DQT_NO_DEBUG to CPPFLAGS. If set to # "false", do nothing. -: ${ECM_DEBUG:=true} +: "${ECM_DEBUG:=true}" # @ECLASS_VARIABLE: ECM_DESIGNERPLUGIN # @DESCRIPTION: # If set to "true", add "designer" to IUSE to toggle build of designer plugins # and add the necessary BDEPEND. If set to "false", do nothing. -: ${ECM_DESIGNERPLUGIN:=false} +: "${ECM_DESIGNERPLUGIN:=false}" # @ECLASS_VARIABLE: ECM_EXAMPLES # @DESCRIPTION: # By default unconditionally ignore a top-level examples subdirectory. # If set to "true", add "examples" to IUSE to toggle adding that subdirectory. -: ${ECM_EXAMPLES:=false} +: "${ECM_EXAMPLES:=false}" # @ECLASS_VARIABLE: ECM_HANDBOOK # @DESCRIPTION: @@ -90,20 +90,20 @@ fi # when !handbook. In case package requires KF5KDELibs4Support, see next: # If set to "forceoptional", remove a KF5DocTools dependency from the root # CMakeLists.txt in addition to the above. -: ${ECM_HANDBOOK:=false} +: "${ECM_HANDBOOK:=false}" # @ECLASS_VARIABLE: ECM_HANDBOOK_DIR # @DESCRIPTION: # Specifies the directory containing the docbook file(s) relative to ${S} to # be processed by KF5DocTools (kdoctools_install). -: ${ECM_HANDBOOK_DIR:=doc} +: "${ECM_HANDBOOK_DIR:=doc}" # @ECLASS_VARIABLE: ECM_PO_DIRS # @DESCRIPTION: # Specifies directories of l10n files relative to ${S} to be processed by # KF5I18n (ki18n_install). If IUSE nls exists and is disabled then disable # build of these directories in CMakeLists.txt. -: ${ECM_PO_DIRS:="po poqm"} +: "${ECM_PO_DIRS:="po poqm"}" # @ECLASS_VARIABLE: ECM_QTHELP # @DEFAULT_UNSET @@ -113,9 +113,9 @@ fi # -DBUILD_QCH=ON generate and install Qt compressed help files when USE=doc. # If set to "false", do nothing. if [[ ${CATEGORY} = kde-frameworks ]]; then - : ${ECM_QTHELP:=true} + : "${ECM_QTHELP:=true}" fi -: ${ECM_QTHELP:=false} +: "${ECM_QTHELP:=false}" # @ECLASS_VARIABLE: ECM_TEST # @DEFAULT_UNSET @@ -135,9 +135,9 @@ fi # meant as a short-term fix and creates ${T}/${P}-tests-optional.patch to # refine and submit upstream. if [[ ${CATEGORY} = kde-frameworks ]]; then - : ${ECM_TEST:=true} + : "${ECM_TEST:=true}" fi -: ${ECM_TEST:=false} +: "${ECM_TEST:=false}" # @ECLASS_VARIABLE: KFMIN # @DEFAULT_UNSET @@ -147,15 +147,15 @@ fi # changed unless we also bump EAPI, which usually implies (rev-)bumping. # Version will also be used to differentiate between KF5/Qt5 and KF6/Qt6. if [[ ${CATEGORY} = kde-frameworks ]]; then - : ${KFMIN:=$(ver_cut 1-2)} + : "${KFMIN:=$(ver_cut 1-2)}" fi -: ${KFMIN:=5.82.0} +: "${KFMIN:=5.82.0}" # @ECLASS_VARIABLE: _KFSLOT # @INTERNAL # @DESCRIPTION: # KDE Frameworks and Qt slot dependency, implied by KFMIN version. -: ${_KFSLOT:=5} +: "${_KFSLOT:=5}" [[ ${KFMIN/.*} == 6 ]] && _KFSLOT=6 case ${ECM_NONGUI} in