From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 972FE15A7D9 for ; Tue, 14 Mar 2023 17:39:56 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id E28A6E0729; Tue, 14 Mar 2023 17:39:55 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id CAF01E0729 for ; Tue, 14 Mar 2023 17:39:55 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id B2DDD335C60 for ; Tue, 14 Mar 2023 17:39:54 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 4C7E988F for ; Tue, 14 Mar 2023 17:39:52 +0000 (UTC) From: "Michał Górny" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Michał Górny" Message-ID: <1678815588.e74f0208753fdb6868b70a7ebda11b4773720d8e.mgorny@gentoo> Subject: [gentoo-commits] proj/gentoo-syntax:master commit in: plugin/ X-VCS-Repository: proj/gentoo-syntax X-VCS-Files: plugin/newebuild.vim X-VCS-Directories: plugin/ X-VCS-Committer: mgorny X-VCS-Committer-Name: Michał Górny X-VCS-Revision: e74f0208753fdb6868b70a7ebda11b4773720d8e X-VCS-Branch: master Date: Tue, 14 Mar 2023 17:39:52 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 45b4e1fe-0dfa-4bcb-afb5-fb20fe885d2d X-Archives-Hash: 49ae1ff97a2d09550558710178b23592 commit: e74f0208753fdb6868b70a7ebda11b4773720d8e Author: Yuan Liao gmail com> AuthorDate: Tue Mar 14 16:24:10 2023 +0000 Commit: Michał Górny gentoo org> CommitDate: Tue Mar 14 17:39:48 2023 +0000 URL: https://gitweb.gentoo.org/proj/gentoo-syntax.git/commit/?id=e74f0208 newebuild: Do not use *.zip SRC_URI in dev-java ebuild template Many Java packages' source archives are available in tarball formats like .tar.gz already, and tarballs are more preferable than Zip archives for SRC_URI (pkgcheck has a check for this). However, instead of replacing '.zip' with '.tar.gz', it could be better to just leave the value of SRC_URI in the template empty, just like in the dev-python ebuild template. Signed-off-by: Yuan Liao gmail.com> Closes: https://github.com/gentoo/gentoo-syntax/pull/58 Signed-off-by: Michał Górny gentoo.org> plugin/newebuild.vim | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugin/newebuild.vim b/plugin/newebuild.vim index e5a54e4..2fa7acb 100644 --- a/plugin/newebuild.vim +++ b/plugin/newebuild.vim @@ -128,7 +128,7 @@ fun! MakeNewEbuild() put ='' put ='DESCRIPTION=\"\"' put ='HOMEPAGE=\"\"' - put ='SRC_URI=\"${P}.zip\"' + put ='SRC_URI=\"\"' put ='' put ='LICENSE=\"\"' put ='SLOT=\"0\"'