From: "Sam James" <sam@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: dev-util/rocminfo/
Date: Sat, 11 Mar 2023 16:26:40 +0000 (UTC) [thread overview]
Message-ID: <1678551916.65f5eec96be908fc0fc6ff1a4811242d049b8ef6.sam@gentoo> (raw)
commit: 65f5eec96be908fc0fc6ff1a4811242d049b8ef6
Author: Stijn Tintel <stijn <AT> linux-ipv6 <DOT> be>
AuthorDate: Sun Sep 4 19:22:22 2022 +0000
Commit: Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Sat Mar 11 16:25:16 2023 +0000
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=65f5eec9
dev-util/rocminfo: enable release build
The rocminfo CMake file uses a custom variable named ROCRTST_BLD_TYPE to
set CMAKE_BUILD_TYPE. When not set, this defaults to Debug, which adds
-O0 to CXXFLAGS. This overrides the optimization flags in CXXFLAGS in
make.conf.
When the CXXFLAGS in make.conf contain _FORTIFY_SOURCE, this breaks
compilation with the following error:
/usr/include/features.h:412:4: error: #warning _FORTIFY_SOURCE requires compiling with optimization (-O) [-Werror=cpp]
412 | # warning _FORTIFY_SOURCE requires compiling with optimization (-O)
| ^~~~~~~
Fix this by setting the ROCRTST_BLD_TYPE variable to Release in
mycmakeargs.
Closes: https://bugs.gentoo.org/887583
Package-Manager: Portage-3.0.30, Repoman-3.0.3
Signed-off-by: Stijn Tintel <stijn <AT> linux-ipv6.be>
Closes: https://github.com/gentoo/gentoo/pull/27145
Signed-off-by: Sam James <sam <AT> gentoo.org>
dev-util/rocminfo/rocminfo-5.1.3.ebuild | 5 +++++
dev-util/rocminfo/rocminfo-5.3.3.ebuild | 5 +++++
dev-util/rocminfo/rocminfo-5.4.3.ebuild | 5 +++++
dev-util/rocminfo/rocminfo-9999.ebuild | 5 +++++
4 files changed, 20 insertions(+)
diff --git a/dev-util/rocminfo/rocminfo-5.1.3.ebuild b/dev-util/rocminfo/rocminfo-5.1.3.ebuild
index c090c863e060..6c175c0a3bd4 100644
--- a/dev-util/rocminfo/rocminfo-5.1.3.ebuild
+++ b/dev-util/rocminfo/rocminfo-5.1.3.ebuild
@@ -29,3 +29,8 @@ src_prepare() {
sed -e "/num_change_since_prev_pkg(/cset(NUM_COMMITS 0)" -i cmake_modules/utils.cmake || die # Fix QA issue on "git not found"
cmake_src_prepare
}
+
+src_configure() {
+ local mycmakeargs=( -DROCRTST_BLD_TYPE=Release )
+ cmake_src_configure
+}
diff --git a/dev-util/rocminfo/rocminfo-5.3.3.ebuild b/dev-util/rocminfo/rocminfo-5.3.3.ebuild
index c090c863e060..6c175c0a3bd4 100644
--- a/dev-util/rocminfo/rocminfo-5.3.3.ebuild
+++ b/dev-util/rocminfo/rocminfo-5.3.3.ebuild
@@ -29,3 +29,8 @@ src_prepare() {
sed -e "/num_change_since_prev_pkg(/cset(NUM_COMMITS 0)" -i cmake_modules/utils.cmake || die # Fix QA issue on "git not found"
cmake_src_prepare
}
+
+src_configure() {
+ local mycmakeargs=( -DROCRTST_BLD_TYPE=Release )
+ cmake_src_configure
+}
diff --git a/dev-util/rocminfo/rocminfo-5.4.3.ebuild b/dev-util/rocminfo/rocminfo-5.4.3.ebuild
index 34df3ab7b44e..15e50f8d07fa 100644
--- a/dev-util/rocminfo/rocminfo-5.4.3.ebuild
+++ b/dev-util/rocminfo/rocminfo-5.4.3.ebuild
@@ -29,3 +29,8 @@ src_prepare() {
sed -e "/num_change_since_prev_pkg(/cset(NUM_COMMITS 0)" -i cmake_modules/utils.cmake || die # Fix QA issue on "git not found"
cmake_src_prepare
}
+
+src_configure() {
+ local mycmakeargs=( -DROCRTST_BLD_TYPE=Release )
+ cmake_src_configure
+}
diff --git a/dev-util/rocminfo/rocminfo-9999.ebuild b/dev-util/rocminfo/rocminfo-9999.ebuild
index c993e808caf5..2668b8684942 100644
--- a/dev-util/rocminfo/rocminfo-9999.ebuild
+++ b/dev-util/rocminfo/rocminfo-9999.ebuild
@@ -21,3 +21,8 @@ SLOT="0/$(ver_cut 1-2)"
RDEPEND="dev-libs/rocr-runtime"
DEPEND="${RDEPEND}"
+
+src_configure() {
+ local mycmakeargs=( -DROCRTST_BLD_TYPE=Release )
+ cmake_src_configure
+}
next reply other threads:[~2023-03-11 16:26 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-11 16:26 Sam James [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-03-04 10:55 [gentoo-commits] repo/gentoo:master commit in: dev-util/rocminfo/ Patrick Lauer
2025-02-08 10:07 Patrick Lauer
2024-07-28 8:04 Patrick Lauer
2023-12-23 16:10 罗百科
2023-10-25 9:10 罗百科
2023-10-09 13:34 罗百科
2023-08-03 17:12 Andreas Sturmlechner
2023-03-02 16:30 罗百科
2022-12-20 9:26 罗百科
2022-12-19 14:00 Andreas Sturmlechner
2022-03-26 0:27 Sam James
2022-03-22 4:09 Benda XU
2021-06-28 20:05 Craig Andrews
2021-03-28 21:20 Craig Andrews
2020-12-21 12:55 Craig Andrews
2020-12-06 19:04 Craig Andrews
2020-11-14 21:02 Craig Andrews
2020-09-22 18:00 Craig Andrews
2020-08-25 21:08 Craig Andrews
2020-08-24 17:20 Craig Andrews
2020-08-22 18:08 Craig Andrews
2020-06-06 18:00 Craig Andrews
2020-03-31 16:36 Craig Andrews
2020-02-27 13:26 Craig Andrews
2019-12-17 18:46 Craig Andrews
2019-11-24 17:10 Craig Andrews
2019-10-01 20:42 Craig Andrews
2019-09-25 18:14 Craig Andrews
2019-09-25 18:14 Craig Andrews
2019-08-15 17:29 Craig Andrews
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1678551916.65f5eec96be908fc0fc6ff1a4811242d049b8ef6.sam@gentoo \
--to=sam@gentoo.org \
--cc=gentoo-commits@lists.gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox